* [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
2023-06-22 15:56 [PATCH 0/2] Hook up 8280 SCM icc Konrad Dybcio
@ 2023-06-22 15:56 ` Konrad Dybcio
2023-06-22 19:55 ` Conor Dooley
2023-06-22 15:56 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp: Add missing SCM interconnect Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2023-06-22 15:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Das Srinagesh, Johan Hovold
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Konrad Dybcio, Konrad Dybcio
Just like all other Qualcomm SoCs, SC8280XP SCM should be fed an
interconnect path. Do so.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
index 09073e1d88ff..42d064be753b 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
@@ -174,6 +174,7 @@ allOf:
contains:
enum:
- qcom,scm-qdu1000
+ - qcom,scm-sc8280xp
- qcom,scm-sm8450
- qcom,scm-sm8550
then:
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
2023-06-22 15:56 ` [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP Konrad Dybcio
@ 2023-06-22 19:55 ` Conor Dooley
0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2023-06-22 19:55 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Das Srinagesh, Johan Hovold,
Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Konrad Dybcio
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Thu, Jun 22, 2023 at 05:56:15PM +0200, Konrad Dybcio wrote:
> Just like all other Qualcomm SoCs, SC8280XP SCM should be fed an
> interconnect path. Do so.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 09073e1d88ff..42d064be753b 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -174,6 +174,7 @@ allOf:
> contains:
> enum:
> - qcom,scm-qdu1000
> + - qcom,scm-sc8280xp
> - qcom,scm-sm8450
> - qcom,scm-sm8550
> then:
>
> --
> 2.41.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
2023-06-22 15:56 [PATCH 0/2] Hook up 8280 SCM icc Konrad Dybcio
2023-06-22 15:56 ` [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP Konrad Dybcio
@ 2023-06-22 15:56 ` Konrad Dybcio
2023-06-28 7:49 ` [PATCH 0/2] Hook up 8280 SCM icc Johan Hovold
2023-07-10 5:07 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-06-22 15:56 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Das Srinagesh, Johan Hovold
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Konrad Dybcio, Konrad Dybcio
The SCM interconnect path was missing. Add it.
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index ac0596dfdbc4..0756b7c141ff 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -298,6 +298,7 @@ CLUSTER_SLEEP_0: cluster-sleep-0 {
firmware {
scm: scm {
compatible = "qcom,scm-sc8280xp", "qcom,scm";
+ interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
};
};
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Hook up 8280 SCM icc
2023-06-22 15:56 [PATCH 0/2] Hook up 8280 SCM icc Konrad Dybcio
2023-06-22 15:56 ` [PATCH 1/2] dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP Konrad Dybcio
2023-06-22 15:56 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp: Add missing SCM interconnect Konrad Dybcio
@ 2023-06-28 7:49 ` Johan Hovold
2023-07-10 5:07 ` (subset) " Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2023-06-28 7:49 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Robert Marko, Das Srinagesh, Johan Hovold,
Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Konrad Dybcio
On Thu, Jun 22, 2023 at 05:56:14PM +0200, Konrad Dybcio wrote:
> The icc handle for SCM was missing on 8280. Add it.
> Konrad Dybcio (2):
> dt-bindings: firmware: qcom,scm: Allow interconnect on SC8280XP
> arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
Appears to work and matches the vendor dts, but no sign of any
"performance benefit" as mentioned in 65b7ebda5028 ("firmware: qcom_scm:
Add bw voting support to the SCM interface") during fw load at boot.
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: (subset) [PATCH 0/2] Hook up 8280 SCM icc
2023-06-22 15:56 [PATCH 0/2] Hook up 8280 SCM icc Konrad Dybcio
` (2 preceding siblings ...)
2023-06-28 7:49 ` [PATCH 0/2] Hook up 8280 SCM icc Johan Hovold
@ 2023-07-10 5:07 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-07-10 5:07 UTC (permalink / raw)
To: Andy Gross, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Robert Marko, Das Srinagesh, Johan Hovold, Konrad Dybcio
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Konrad Dybcio
On Thu, 22 Jun 2023 17:56:14 +0200, Konrad Dybcio wrote:
> The icc handle for SCM was missing on 8280. Add it.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: sc8280xp: Add missing SCM interconnect
commit: 0a69ccf20b0837db857abfc94d7e3bacf1cb771b
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread