From: Dmitry Rokosov <ddrokosov@sberdevices.ru>
To: <gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<neil.armstrong@linaro.org>, <jbrunet@baylibre.com>,
<jirislaby@kernel.org>, <khilman@baylibre.com>,
<martin.blumenstingl@googlemail.com>
Cc: <kelvin.zhang@amlogic.com>, <xianwei.zhao@amlogic.com>,
<kernel@sberdevices.ru>, <rockosov@gmail.com>,
<linux-amlogic@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>
Subject: [PATCH v1 1/5] tty: serial: meson: use dev_err_probe
Date: Tue, 4 Jul 2023 16:59:32 +0300 [thread overview]
Message-ID: <20230704135936.14697-2-ddrokosov@sberdevices.ru> (raw)
In-Reply-To: <20230704135936.14697-1-ddrokosov@sberdevices.ru>
Use dev_err_probe() helper for error checking and standard logging.
It makes the driver's probe() function a little bit shorter.
Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
---
drivers/tty/serial/meson_uart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
index 2501db5a7aaf..169f028956ae 100644
--- a/drivers/tty/serial/meson_uart.c
+++ b/drivers/tty/serial/meson_uart.c
@@ -726,8 +726,8 @@ static int meson_uart_probe(struct platform_device *pdev)
of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
if (meson_ports[pdev->id]) {
- dev_err(&pdev->dev, "port %d already allocated\n", pdev->id);
- return -EBUSY;
+ return dev_err_probe(&pdev->dev, -EBUSY,
+ "port %d already allocated\n", pdev->id);
}
port = devm_kzalloc(&pdev->dev, sizeof(struct uart_port), GFP_KERNEL);
--
2.36.0
next prev parent reply other threads:[~2023-07-04 13:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 13:59 [PATCH v1 0/5] tty: serial: meson: support ttyS devname Dmitry Rokosov
2023-07-04 13:59 ` Dmitry Rokosov [this message]
2023-07-04 13:59 ` [PATCH v1 2/5] tty: serial: meson: redesign the module to platform_driver Dmitry Rokosov
2023-07-04 14:46 ` neil.armstrong
2023-07-04 15:19 ` Dmitry Rokosov
2023-07-04 17:06 ` Dmitry Rokosov
2023-07-04 13:59 ` [PATCH v1 3/5] tty: serial: meson: apply ttyS devname instead of ttyAML for new SoCs Dmitry Rokosov
2023-07-04 14:42 ` neil.armstrong
2023-07-04 14:59 ` Dmitry Rokosov
2023-07-04 15:29 ` neil.armstrong
2023-07-04 16:00 ` Dmitry Rokosov
2023-07-04 16:57 ` Conor Dooley
2023-07-04 17:13 ` Dmitry Rokosov
2023-07-04 19:14 ` Conor Dooley
2023-07-04 13:59 ` [PATCH v1 4/5] dt-bindings: serial: amlogic,meson-uart: support Amlogic A1 Dmitry Rokosov
2023-07-05 19:00 ` Rob Herring
2023-07-04 13:59 ` [PATCH v1 5/5] arm64: dts: meson: a1: change uart compatible string Dmitry Rokosov
2023-07-04 17:02 ` Conor Dooley
2023-07-04 17:08 ` Dmitry Rokosov
2023-07-04 17:10 ` Conor Dooley
2023-07-04 17:19 ` Dmitry Rokosov
2023-07-05 9:46 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704135936.14697-2-ddrokosov@sberdevices.ru \
--to=ddrokosov@sberdevices.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jirislaby@kernel.org \
--cc=kelvin.zhang@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox