From: Andreas Kemnade <andreas@kemnade.info>
To: Marek Vasut <marex@denx.de>
Cc: linux-leds@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value
Date: Tue, 4 Jul 2023 22:44:11 +0200 [thread overview]
Message-ID: <20230704224411.17dbbf7c@aktux> (raw)
In-Reply-To: <20230704202929.91962-1-marex@denx.de>
Hi Marek,
you are right.
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
On Tue, 4 Jul 2023 22:29:29 +0200
Marek Vasut <marex@denx.de> wrote:
> Since the chip can drive up to 6 lines, the maximum
> register number should be only 5, not 6.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> ---
> Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> index 14700a2e5feaa..44dd91aa239de 100644
> --- a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> @@ -35,7 +35,7 @@ properties:
> description: GPIO pin to enable/disable the device.
>
> patternProperties:
> - "^led@[0-6]$":
> + "^led@[0-5]$":
> type: object
> $ref: common.yaml#
> unevaluatedProperties: false
> @@ -43,7 +43,7 @@ patternProperties:
> properties:
> reg:
> minimum: 0
> - maximum: 6
> + maximum: 5
>
> required:
> - reg
next prev parent reply other threads:[~2023-07-04 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 20:29 [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value Marek Vasut
2023-07-04 20:44 ` Andreas Kemnade [this message]
2023-07-05 19:07 ` Rob Herring
2023-07-13 13:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704224411.17dbbf7c@aktux \
--to=andreas@kemnade.info \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marex@denx.de \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox