* [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value
@ 2023-07-04 20:29 Marek Vasut
2023-07-04 20:44 ` Andreas Kemnade
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marek Vasut @ 2023-07-04 20:29 UTC (permalink / raw)
To: linux-leds
Cc: Marek Vasut, Andreas Kemnade, Conor Dooley, Krzysztof Kozlowski,
Lee Jones, Pavel Machek, Rob Herring, devicetree
Since the chip can drive up to 6 lines, the maximum
register number should be only 5, not 6.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Andreas Kemnade <andreas@kemnade.info>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-leds@vger.kernel.org
---
Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
index 14700a2e5feaa..44dd91aa239de 100644
--- a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
+++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
@@ -35,7 +35,7 @@ properties:
description: GPIO pin to enable/disable the device.
patternProperties:
- "^led@[0-6]$":
+ "^led@[0-5]$":
type: object
$ref: common.yaml#
unevaluatedProperties: false
@@ -43,7 +43,7 @@ patternProperties:
properties:
reg:
minimum: 0
- maximum: 6
+ maximum: 5
required:
- reg
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value
2023-07-04 20:29 [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value Marek Vasut
@ 2023-07-04 20:44 ` Andreas Kemnade
2023-07-05 19:07 ` Rob Herring
2023-07-13 13:36 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Kemnade @ 2023-07-04 20:44 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-leds, Conor Dooley, Krzysztof Kozlowski, Lee Jones,
Pavel Machek, Rob Herring, devicetree
Hi Marek,
you are right.
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
On Tue, 4 Jul 2023 22:29:29 +0200
Marek Vasut <marex@denx.de> wrote:
> Since the chip can drive up to 6 lines, the maximum
> register number should be only 5, not 6.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> ---
> Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> index 14700a2e5feaa..44dd91aa239de 100644
> --- a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml
> @@ -35,7 +35,7 @@ properties:
> description: GPIO pin to enable/disable the device.
>
> patternProperties:
> - "^led@[0-6]$":
> + "^led@[0-5]$":
> type: object
> $ref: common.yaml#
> unevaluatedProperties: false
> @@ -43,7 +43,7 @@ patternProperties:
> properties:
> reg:
> minimum: 0
> - maximum: 6
> + maximum: 5
>
> required:
> - reg
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value
2023-07-04 20:29 [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value Marek Vasut
2023-07-04 20:44 ` Andreas Kemnade
@ 2023-07-05 19:07 ` Rob Herring
2023-07-13 13:36 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2023-07-05 19:07 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, Conor Dooley, Pavel Machek, Krzysztof Kozlowski,
Lee Jones, Andreas Kemnade, linux-leds, Rob Herring
On Tue, 04 Jul 2023 22:29:29 +0200, Marek Vasut wrote:
> Since the chip can drive up to 6 lines, the maximum
> register number should be only 5, not 6.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> ---
> Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value
2023-07-04 20:29 [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value Marek Vasut
2023-07-04 20:44 ` Andreas Kemnade
2023-07-05 19:07 ` Rob Herring
@ 2023-07-13 13:36 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-07-13 13:36 UTC (permalink / raw)
To: Marek Vasut
Cc: linux-leds, Andreas Kemnade, Conor Dooley, Krzysztof Kozlowski,
Pavel Machek, Rob Herring, devicetree
On Tue, 04 Jul 2023, Marek Vasut wrote:
> Since the chip can drive up to 6 lines, the maximum
> register number should be only 5, not 6.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andreas Kemnade <andreas@kemnade.info>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Lee Jones <lee@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-leds@vger.kernel.org
> ---
> Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-13 13:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 20:29 [PATCH] [RFC] dt-bindings: leds: bd2606mvv: Fix maximum register value Marek Vasut
2023-07-04 20:44 ` Andreas Kemnade
2023-07-05 19:07 ` Rob Herring
2023-07-13 13:36 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox