[PATCH] mfd: rk808: turn MFD_RK8XX into a tristate

[PATCH] mfd: rk808: turn MFD_RK8XX into a tristate

[Ivan Babrou]

Prior to commit c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
it was possible to build rk808 as a module and have CONFIG_MFD_CORE=m too.
After that the intermediary CONFIG_MFD_RK8XX was added as a boolean,
forcing mfd_core to be compiled in whenever rk808 was enabled,
even if it was still built as a module.

Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
Fixes: c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
---
 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6f5b259a6d6a..f6b519eaaa71 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1197,7 +1197,7 @@ config MFD_RC5T583
 	  different functionality of the device.
 
 config MFD_RK8XX
-	bool
+	tristate
 	select MFD_CORE
 
 config MFD_RK8XX_I2C
-- 
2.41.0

Re: [PATCH] mfd: rk808: turn MFD_RK8XX into a tristate

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

Hi,

On Sun, Jul 09, 2023 at 04:25:07PM -0700, Ivan Babrou wrote:
> Prior to commit c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
> it was possible to build rk808 as a module and have CONFIG_MFD_CORE=m too.
> After that the intermediary CONFIG_MFD_RK8XX was added as a boolean,
> forcing mfd_core to be compiled in whenever rk808 was enabled,
> even if it was still built as a module.
> 
> Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
> Fixes: c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
> ---

The same fix has already been send by Geert some days ago:

https://lore.kernel.org/all/d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@glider.be/

-- Sebastian

>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6f5b259a6d6a..f6b519eaaa71 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1197,7 +1197,7 @@ config MFD_RC5T583
>  	  different functionality of the device.
>  
>  config MFD_RK8XX
> -	bool
> +	tristate
>  	select MFD_CORE
>  
>  config MFD_RK8XX_I2C
> -- 
> 2.41.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] mfd: rk808: turn MFD_RK8XX into a tristate

[Ivan Babrou]

On Sun, Jul 9, 2023 at 5:16 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Hi,
>
> On Sun, Jul 09, 2023 at 04:25:07PM -0700, Ivan Babrou wrote:
> > Prior to commit c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
> > it was possible to build rk808 as a module and have CONFIG_MFD_CORE=m too.
> > After that the intermediary CONFIG_MFD_RK8XX was added as a boolean,
> > forcing mfd_core to be compiled in whenever rk808 was enabled,
> > even if it was still built as a module.
> >
> > Signed-off-by: Ivan Babrou <ivan@cloudflare.com>
> > Fixes: c20e8c5b1203 ("mfd: rk808: Split into core and i2c")
> > ---
>
> The same fix has already been send by Geert some days ago:
>
> https://lore.kernel.org/all/d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@glider.be/

Ah, I looked through the devicetree mailing list archive (where the
original patch was sent) and haven't found anything there.