[PATCH v5 0/2] Remove power-domains property for devices with compatible ti,am62-sa3ul

[PATCH v5 0/2] Remove power-domains property for devices with compatible ti,am62-sa3ul

[Kamlesh Gurudasani]

SYSFW don't allow access to power of devices with compatible ti,am62-sa3ul
from main domain.

Power-domains property, if present will try to access the power of the
device, which will result into failure in probing of driver for that
device.

Make power-domains property as false for devices with compatible
ti,am62-sa3ul.

Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
Changes in v5:
- Update recipient list
- Link to v4: https://lore.kernel.org/r/20230614-sa3ul-v4-0-7c969f626796@ti.com

Changes in v4:
- s/items/contains/ for dt-binding patch
- Added "fixes commit" for dt-binding patch
- Link to v3: https://lore.kernel.org/r/20230614-sa3ul-v3-0-2eeb810327a1@ti.com

Changes in v3:
- Add patch dt-bindings: crypto: ti,sa2ul: make power-domains conditional
- Link to v2: https://lore.kernel.org/r/20230614-sa3ul-v2-1-3a832b82339c@ti.com

Changes in v2:
- Make commit message clearer

---
Kamlesh Gurudasani (2):
      dt-bindings: crypto: ti,sa2ul: make power-domains conditional
      arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node

 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi               |  1 -
 2 files changed, 13 insertions(+), 2 deletions(-)
---
base-commit: 53ab6975c12d1ad86c599a8927e8c698b144d669
change-id: 20230614-sa3ul-cb4bd1bb4d08

Best regards,
-- 
Kamlesh Gurudasani <kamlesh@ti.com>

[PATCH v5 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional

[Kamlesh Gurudasani]

Devices specific to compatible ti,am62-sa3ul don't have control over
power of SA3UL from main domain.

"power-domains" property in crypto node tries to access
the SA3UL power, for which it gets NACK and hence, driver doesn't
probe properly for those particular devices.

Make "power-domains" property as false for devices with
compatible ti,am62-sa3ul.

Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation")

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
index 77ec8bc70bf7..f0ef7685550a 100644
--- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
@@ -66,10 +66,22 @@ patternProperties:
 required:
   - compatible
   - reg
-  - power-domains
   - dmas
   - dma-names
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: ti,am62-sa3ul
+    then:
+      properties:
+        power-domains: false
+    else:
+      required:
+        - power-domains
+
 additionalProperties: false
 
 examples:

-- 
2.34.1

[PATCH v5 2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node

[Kamlesh Gurudasani]

Only SYSFW has control of SA3UL power.
From SYSFW 08.04.00.002, for security reasons, device ID for power
management of SA3UL has been removed.

"power-domains" property in crypto node tries to access
the SA3UL, for which it gets NACK and hence, SA3UL driver doesn't
probe properly.

Fixes: 8af893654c02 ("arm64: dts: ti: k3-am62-main: Enable crypto accelerator")

Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index b3e4857bbbe4..18a6e9ffaf58 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -174,7 +174,6 @@ k3_reset: reset-controller {
 	crypto: crypto@40900000 {
 		compatible = "ti,am62-sa3ul";
 		reg = <0x00 0x40900000 0x00 0x1200>;
-		power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>;
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;

-- 
2.34.1

Re: [PATCH v5 1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional

[Nishanth Menon]

On 14:42-20230714, Kamlesh Gurudasani wrote:
> Devices specific to compatible ti,am62-sa3ul don't have control over
> power of SA3UL from main domain.
> 
> "power-domains" property in crypto node tries to access
> the SA3UL power, for which it gets NACK and hence, driver doesn't
> probe properly for those particular devices.
> 
> Make "power-domains" property as false for devices with
> compatible ti,am62-sa3ul.
> 
> Fixes: 2ce9a7299bf6 ("dt-bindings: crypto: Add TI SA2UL crypto accelerator documentation")
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
>  Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

Herbert, Do you see a problem if I pick this patch via TI SoC Tree?

if you are OK, I'd like to take the series to keep it clean.

> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 77ec8bc70bf7..f0ef7685550a 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,10 +66,22 @@ patternProperties:
>  required:
>    - compatible
>    - reg
> -  - power-domains
>    - dmas
>    - dma-names
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,am62-sa3ul
> +    then:
> +      properties:
> +        power-domains: false
> +    else:
> +      required:
> +        - power-domains
> +
>  additionalProperties: false
>  
>  examples:
> 
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v5 0/2] Remove power-domains property for devices with compatible ti,am62-sa3ul

[Nishanth Menon]

Herbert,

I am going to assume that you are ok with me picking this series up as this
results in a few broken boots for various boards. Let me know if that is not
the case, and I will drop the series from my tree.

Hi Kamlesh Gurudasani,

On Fri, 14 Jul 2023 14:42:40 +0530, Kamlesh Gurudasani wrote:
> SYSFW don't allow access to power of devices with compatible ti,am62-sa3ul
> from main domain.
> 
> Power-domains property, if present will try to access the power of the
> device, which will result into failure in probing of driver for that
> device.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] dt-bindings: crypto: ti,sa2ul: make power-domains conditional
      commit: e1f7d17a734c5c617d05c3d188939d5032d3d5a2
[2/2] arm64: dts: ti: k3-am62-main: Remove power-domains from crypto node
      commit: b573bf35ef3f113c1717fa22cefdfdfbb83aec70

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v5 0/2] Remove power-domains property for devices with compatible ti,am62-sa3ul

[Herbert Xu]

On Tue, Jul 25, 2023 at 06:39:48AM -0500, Nishanth Menon wrote:
> Herbert,
> 
> I am going to assume that you are ok with me picking this series up as this
> results in a few broken boots for various boards. Let me know if that is not
> the case, and I will drop the series from my tree.

Sure, no problems.

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt