* [PATCH V2 0/2] Add watchdog support for Amlogic C3 SoCs @ 2023-09-26 5:55 Huqiang Qin 2023-09-26 5:55 ` [PATCH V2 1/2] dt-bindings: watchdog: Add " Huqiang Qin 2023-09-26 5:55 ` [PATCH V2 2/2] arm64: dts: Add watchdog node " Huqiang Qin 0 siblings, 2 replies; 6+ messages in thread From: Huqiang Qin @ 2023-09-26 5:55 UTC (permalink / raw) To: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl Cc: linux-watchdog, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Huqiang Qin Amlogic C3 has the same watchdog controller as Amlogic T7. [PATCH 1/2]: V1 -> V2: Added compatibles. [PATCH 2/2]: V1 -> V2: Increase compatibles of C3 watchdog. Huqiang Qin (2): dt-bindings: watchdog: Add support for Amlogic C3 SoCs arm64: dts: Add watchdog node for Amlogic C3 SoCs .../bindings/watchdog/amlogic,meson-gxbb-wdt.yaml | 1 + arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++ 2 files changed, 7 insertions(+) base-commit: 8fff9184d1b5810dca5dd1a02726d4f844af88fc -- 2.42.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 1/2] dt-bindings: watchdog: Add support for Amlogic C3 SoCs 2023-09-26 5:55 [PATCH V2 0/2] Add watchdog support for Amlogic C3 SoCs Huqiang Qin @ 2023-09-26 5:55 ` Huqiang Qin 2023-09-27 8:01 ` Krzysztof Kozlowski 2023-09-26 5:55 ` [PATCH V2 2/2] arm64: dts: Add watchdog node " Huqiang Qin 1 sibling, 1 reply; 6+ messages in thread From: Huqiang Qin @ 2023-09-26 5:55 UTC (permalink / raw) To: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl Cc: linux-watchdog, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Huqiang Qin Update dt-binding document for watchdog of Amlogic C3 SoCs. Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> --- V1 -> V2: Added compatibles. .../devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml index 443e2e7ab467..b7e8e453c0ef 100644 --- a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml @@ -17,6 +17,7 @@ properties: compatible: enum: - amlogic,meson-gxbb-wdt + - amlogic,c3-wdt - amlogic,t7-wdt reg: -- 2.42.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: watchdog: Add support for Amlogic C3 SoCs 2023-09-26 5:55 ` [PATCH V2 1/2] dt-bindings: watchdog: Add " Huqiang Qin @ 2023-09-27 8:01 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-09-27 8:01 UTC (permalink / raw) To: Huqiang Qin, wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl Cc: linux-watchdog, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 26/09/2023 07:55, Huqiang Qin wrote: > Update dt-binding document for watchdog of Amlogic C3 SoCs. > > Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> > --- > > V1 -> V2: Added compatibles. > > .../devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml > index 443e2e7ab467..b7e8e453c0ef 100644 > --- a/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-gxbb-wdt.yaml > @@ -17,6 +17,7 @@ properties: > compatible: > enum: > - amlogic,meson-gxbb-wdt > + - amlogic,c3-wdt Nothing improved... this won't even work :/ It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 2/2] arm64: dts: Add watchdog node for Amlogic C3 SoCs 2023-09-26 5:55 [PATCH V2 0/2] Add watchdog support for Amlogic C3 SoCs Huqiang Qin 2023-09-26 5:55 ` [PATCH V2 1/2] dt-bindings: watchdog: Add " Huqiang Qin @ 2023-09-26 5:55 ` Huqiang Qin 2023-09-26 8:03 ` Conor Dooley 1 sibling, 1 reply; 6+ messages in thread From: Huqiang Qin @ 2023-09-26 5:55 UTC (permalink / raw) To: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl Cc: linux-watchdog, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel, Huqiang Qin Add watchdog device. Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> --- V1 -> V2: Increase compatibles of C3 watchdog. arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi index 998f5050795c..2ad1f8eef199 100644 --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi @@ -81,6 +81,12 @@ apb4: bus@fe000000 { #size-cells = <2>; ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; + watchdog@2100 { + compatible = "amlogic,c3-wdt", "amlogic,t7-wdt"; + reg = <0x0 0x2100 0x0 0x10>; + clocks = <&xtal>; + }; + periphs_pinctrl: pinctrl@4000 { compatible = "amlogic,c3-periphs-pinctrl"; #address-cells = <2>; -- 2.42.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] arm64: dts: Add watchdog node for Amlogic C3 SoCs 2023-09-26 5:55 ` [PATCH V2 2/2] arm64: dts: Add watchdog node " Huqiang Qin @ 2023-09-26 8:03 ` Conor Dooley 2023-09-27 5:59 ` Huqiang Qin 0 siblings, 1 reply; 6+ messages in thread From: Conor Dooley @ 2023-09-26 8:03 UTC (permalink / raw) To: Huqiang Qin Cc: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, linux-watchdog, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1080 bytes --] On Tue, Sep 26, 2023 at 01:55:12PM +0800, Huqiang Qin wrote: > Add watchdog device. > > Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com> > --- > > V1 -> V2: Increase compatibles of C3 watchdog. > > arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi > index 998f5050795c..2ad1f8eef199 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi > +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi > @@ -81,6 +81,12 @@ apb4: bus@fe000000 { > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; > > + watchdog@2100 { > + compatible = "amlogic,c3-wdt", "amlogic,t7-wdt"; Does this pass dtbs_check? The binding patch doesn't seem to permit this combo.. > + reg = <0x0 0x2100 0x0 0x10>; > + clocks = <&xtal>; > + }; > + > periphs_pinctrl: pinctrl@4000 { > compatible = "amlogic,c3-periphs-pinctrl"; > #address-cells = <2>; > -- > 2.42.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] arm64: dts: Add watchdog node for Amlogic C3 SoCs 2023-09-26 8:03 ` Conor Dooley @ 2023-09-27 5:59 ` Huqiang Qin 0 siblings, 0 replies; 6+ messages in thread From: Huqiang Qin @ 2023-09-27 5:59 UTC (permalink / raw) To: Conor Dooley Cc: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, linux-watchdog, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel On 2023/9/26 16:03, Conor Dooley wrote: >> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi >> @@ -81,6 +81,12 @@ apb4: bus@fe000000 { >> #size-cells = <2>; >> ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; >> >> + watchdog@2100 { >> + compatible = "amlogic,c3-wdt", "amlogic,t7-wdt"; > Does this pass dtbs_check? > The binding patch doesn't seem to permit this combo.. > Ah... I ran dtbs_check again, and there is indeed `watchdog@2100: compatible: ['amlogic,c3-wdt', 'amlogic,t7-wdt'] is too long` in the output. I'll correct it in the next version, thanks for pointing it out. Best regards, Huqiang Qin ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-27 8:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-26 5:55 [PATCH V2 0/2] Add watchdog support for Amlogic C3 SoCs Huqiang Qin 2023-09-26 5:55 ` [PATCH V2 1/2] dt-bindings: watchdog: Add " Huqiang Qin 2023-09-27 8:01 ` Krzysztof Kozlowski 2023-09-26 5:55 ` [PATCH V2 2/2] arm64: dts: Add watchdog node " Huqiang Qin 2023-09-26 8:03 ` Conor Dooley 2023-09-27 5:59 ` Huqiang Qin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox