public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Arun Ramadoss <arun.ramadoss@microchip.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
	"Russell King (Oracle)" <linux@armlinux.org.uk>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/7] net: dsa: microchip: Set unique MAC at startup for WoL support
Date: Fri, 13 Oct 2023 15:32:49 +0300	[thread overview]
Message-ID: <20231013123249.bhigwsezy6afb5qt@skbuf> (raw)
In-Reply-To: <20231013122405.3745475-3-o.rempel@pengutronix.de>

On Fri, Oct 13, 2023 at 02:24:00PM +0200, Oleksij Rempel wrote:
> Set a unique global MAC address for each switch on the network at system
> startup by syncing the switch's global MAC address with the Ethernet
> address of the DSA master interface. This is crucial for supporting
> Wake-on-LAN (WoL) functionality, as it requires a unique address for
> each switch.
> 
> Although the operation is performed only at system start and won't sync
> if the master Ethernet address changes dynamically, it lays the
> groundwork for WoL support by ensuring a unique MAC address for each
> switch.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

Why not take the MAC address of the user port at ksz9477_set_wol() time,
and use the existing ksz_switch_macaddr_get() API that was just added so
that this use case could work?

  reply	other threads:[~2023-10-13 12:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 12:23 [PATCH net-next v3 0/7] net: dsa: microchip: provide Wake on LAN support Oleksij Rempel
2023-10-13 12:23 ` [PATCH net-next v3 1/7] net: dsa: microchip: Add missing MAC address register offset for ksz8863 Oleksij Rempel
2023-10-14 16:55   ` Andrew Lunn
2023-10-15 21:14   ` Florian Fainelli
2023-10-13 12:24 ` [PATCH net-next v3 2/7] net: dsa: microchip: Set unique MAC at startup for WoL support Oleksij Rempel
2023-10-13 12:32   ` Vladimir Oltean [this message]
2023-10-15 21:18     ` Florian Fainelli
2023-10-16 10:15       ` Vladimir Oltean
2023-10-14 17:01   ` Andrew Lunn
2023-10-13 12:24 ` [PATCH net-next v3 3/7] net: dsa: microchip: ksz9477: add Wake on LAN support Oleksij Rempel
2023-10-14 17:14   ` Andrew Lunn
2023-10-16 10:17   ` Vladimir Oltean
2023-10-13 12:24 ` [PATCH net-next v3 4/7] net: dsa: microchip: ksz9477: add Wake on PHY event support Oleksij Rempel
2023-10-14 17:20   ` Andrew Lunn
2023-10-13 12:24 ` [PATCH net-next v3 5/7] dt-bindings: net: dsa: microchip: add wakeup-source property Oleksij Rempel
2023-10-13 12:24 ` [PATCH net-next v3 6/7] net: dsa: microchip: use wakeup-source DT property to enable PME output Oleksij Rempel
2023-10-14 17:25   ` Andrew Lunn
2023-10-13 12:24 ` [PATCH net-next v3 7/7] net: dsa: microchip: do not shut down the switch if WoL is active Oleksij Rempel
2023-10-16 10:22   ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231013123249.bhigwsezy6afb5qt@skbuf \
    --to=olteanv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=arun.ramadoss@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox