From: Vladimir Oltean <olteanv@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/7] net: dsa: microchip: ksz9477: add Wake on LAN support
Date: Mon, 16 Oct 2023 13:17:21 +0300 [thread overview]
Message-ID: <20231016101721.ktc6mrpewrxsh7nv@skbuf> (raw)
In-Reply-To: <20231013122405.3745475-4-o.rempel@pengutronix.de> <20231013122405.3745475-4-o.rempel@pengutronix.de>
On Fri, Oct 13, 2023 at 02:24:01PM +0200, Oleksij Rempel wrote:
> diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
> index db0ef4ad181e..bef1951fe6f2 100644
> --- a/drivers/net/dsa/microchip/ksz_common.c
> +++ b/drivers/net/dsa/microchip/ksz_common.c
> @@ -319,6 +319,8 @@ static const struct ksz_dev_ops ksz9477_dev_ops = {
> .mdb_del = ksz9477_mdb_del,
> .change_mtu = ksz9477_change_mtu,
> .phylink_mac_link_up = ksz9477_phylink_mac_link_up,
> + .wol_get = ksz9477_get_wol,
> + .wol_set = ksz9477_set_wol,
Can the dev_ops function pointers also be named get_wol() and set_wol()
for consistency with everything else?
> .config_cpu_port = ksz9477_config_cpu_port,
> .tc_cbs_set_cinc = ksz9477_tc_cbs_set_cinc,
> .enable_stp_addr = ksz9477_enable_stp_addr,
> @@ -2935,6 +2937,28 @@ static int ksz_set_mac_eee(struct dsa_switch *ds, int port,
> return 0;
> }
next prev parent reply other threads:[~2023-10-16 10:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 12:23 [PATCH net-next v3 0/7] net: dsa: microchip: provide Wake on LAN support Oleksij Rempel
2023-10-13 12:23 ` [PATCH net-next v3 1/7] net: dsa: microchip: Add missing MAC address register offset for ksz8863 Oleksij Rempel
2023-10-14 16:55 ` Andrew Lunn
2023-10-15 21:14 ` Florian Fainelli
2023-10-13 12:24 ` [PATCH net-next v3 2/7] net: dsa: microchip: Set unique MAC at startup for WoL support Oleksij Rempel
2023-10-13 12:32 ` Vladimir Oltean
2023-10-15 21:18 ` Florian Fainelli
2023-10-16 10:15 ` Vladimir Oltean
2023-10-14 17:01 ` Andrew Lunn
2023-10-13 12:24 ` [PATCH net-next v3 3/7] net: dsa: microchip: ksz9477: add Wake on LAN support Oleksij Rempel
2023-10-14 17:14 ` Andrew Lunn
2023-10-16 10:17 ` Vladimir Oltean [this message]
2023-10-13 12:24 ` [PATCH net-next v3 4/7] net: dsa: microchip: ksz9477: add Wake on PHY event support Oleksij Rempel
2023-10-14 17:20 ` Andrew Lunn
2023-10-13 12:24 ` [PATCH net-next v3 5/7] dt-bindings: net: dsa: microchip: add wakeup-source property Oleksij Rempel
2023-10-13 12:24 ` [PATCH net-next v3 6/7] net: dsa: microchip: use wakeup-source DT property to enable PME output Oleksij Rempel
2023-10-14 17:25 ` Andrew Lunn
2023-10-13 12:24 ` [PATCH net-next v3 7/7] net: dsa: microchip: do not shut down the switch if WoL is active Oleksij Rempel
2023-10-16 10:22 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016101721.ktc6mrpewrxsh7nv@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox