* Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"
2023-10-20 17:02 [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias" Rob Herring
@ 2023-10-22 17:34 ` Conor Dooley
2023-10-22 20:17 ` Laurent Pinchart
2023-10-30 20:05 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-10-22 17:34 UTC (permalink / raw)
To: Rob Herring
Cc: Tomi Valkeinen, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Conor Dooley, Sakari Ailus, Laurent Pinchart, linux-media,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> Every DT property needs a type defined, but "i2c-alias" is missing any
> type definition. It's a "uint32", so add a type reference.
>
> Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 289737721c2c..0b71e6f911a8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -69,6 +69,7 @@ properties:
> maxItems: 1
>
> i2c-alias:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description:
> The I2C address used for the serializer. Transactions to this
> address on the I2C bus where the deserializer resides are
> --
> 2.42.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"
2023-10-20 17:02 [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias" Rob Herring
2023-10-22 17:34 ` Conor Dooley
@ 2023-10-22 20:17 ` Laurent Pinchart
2023-10-22 20:59 ` Rob Herring
2023-10-30 20:05 ` Rob Herring
2 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2023-10-22 20:17 UTC (permalink / raw)
To: Rob Herring
Cc: Tomi Valkeinen, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Conor Dooley, Sakari Ailus, linux-media, devicetree, linux-kernel
Hi Rob,
Thank you for the patch.
On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> Every DT property needs a type defined, but "i2c-alias" is missing any
> type definition. It's a "uint32", so add a type reference.
>
> Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> Signed-off-by: Rob Herring <robh@kernel.org>
This is something I should have paid more attention when reviewing the
bindings. I'll try to keep it in mind for the future.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 289737721c2c..0b71e6f911a8 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -69,6 +69,7 @@ properties:
> maxItems: 1
>
> i2c-alias:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description:
> The I2C address used for the serializer. Transactions to this
> address on the I2C bus where the deserializer resides are
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"
2023-10-22 20:17 ` Laurent Pinchart
@ 2023-10-22 20:59 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-10-22 20:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Tomi Valkeinen, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Conor Dooley, Sakari Ailus, linux-media, devicetree, linux-kernel
On Sun, Oct 22, 2023 at 3:17 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> > Every DT property needs a type defined, but "i2c-alias" is missing any
> > type definition. It's a "uint32", so add a type reference.
> >
> > Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> This is something I should have paid more attention when reviewing the
> bindings. I'll try to keep it in mind for the future.
No need, the tools will check for you now. :)
But the same property defined multiple times is not yet checked
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"
2023-10-20 17:02 [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias" Rob Herring
2023-10-22 17:34 ` Conor Dooley
2023-10-22 20:17 ` Laurent Pinchart
@ 2023-10-30 20:05 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-10-30 20:05 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Conor Dooley, linux-kernel, Laurent Pinchart,
Tomi Valkeinen, Krzysztof Kozlowski, Mauro Carvalho Chehab,
Sakari Ailus, linux-media
On Fri, 20 Oct 2023 12:02:24 -0500, Rob Herring wrote:
> Every DT property needs a type defined, but "i2c-alias" is missing any
> type definition. It's a "uint32", so add a type reference.
>
> Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-Link III Deserializer")
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread