[PATCH v1 0/2] usb: misc: onboard-hub: add support for Microchip USB5744

[PATCH v1 0/2] usb: misc: onboard-hub: add support for Microchip USB5744

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add support for the Microchip USB5744 USB3.0 and USB2.0 Hub.

Stefan Eichenberger (2):
  dt-bindings: usb: microchip,usb5744: Add second supply
  usb: misc: onboard-hub: add support for Microchip USB5744

 .../devicetree/bindings/usb/microchip,usb5744.yaml         | 7 ++++++-
 drivers/usb/misc/onboard_usb_hub.c                         | 2 ++
 drivers/usb/misc/onboard_usb_hub.h                         | 7 +++++++
 3 files changed, 15 insertions(+), 1 deletion(-)

-- 
2.25.1

[PATCH v1 1/2] dt-bindings: usb: microchip,usb5744: Add second supply

[Francesco Dolcini]

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the
second supply to the USB5744 DT binding.

Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 .../devicetree/bindings/usb/microchip,usb5744.yaml         | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
index ff3a1707ef57..6d4cfd943f58 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
@@ -36,7 +36,11 @@ properties:
 
   vdd-supply:
     description:
-      VDD power supply to the hub
+      3V3 power supply to the hub
+
+  vdd2-supply:
+    description:
+      1V2 power supply to the hub
 
   peer-hub:
     $ref: /schemas/types.yaml#/definitions/phandle
@@ -62,6 +66,7 @@ allOf:
       properties:
         reset-gpios: false
         vdd-supply: false
+        vdd2-supply: false
         peer-hub: false
         i2c-bus: false
     else:
-- 
2.25.1

Re: [PATCH v1 1/2] dt-bindings: usb: microchip,usb5744: Add second supply

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

On Mon, Nov 13, 2023 at 03:59:20PM +0100, Francesco Dolcini wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the
> second supply to the USB5744 DT binding.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  .../devicetree/bindings/usb/microchip,usb5744.yaml         | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> index ff3a1707ef57..6d4cfd943f58 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> @@ -36,7 +36,11 @@ properties:
>  
>    vdd-supply:
>      description:
> -      VDD power supply to the hub
> +      3V3 power supply to the hub
> +
> +  vdd2-supply:
> +    description:
> +      1V2 power supply to the hub

How about v1p2-supply?

>  
>    peer-hub:
>      $ref: /schemas/types.yaml#/definitions/phandle
> @@ -62,6 +66,7 @@ allOf:
>        properties:
>          reset-gpios: false
>          vdd-supply: false
> +        vdd2-supply: false
>          peer-hub: false
>          i2c-bus: false
>      else:
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v1 1/2] dt-bindings: usb: microchip,usb5744: Add second supply

[Francesco Dolcini]

Hello Conor,
thanks for the review.

On Mon, Nov 13, 2023 at 07:55:20PM +0000, Conor Dooley wrote:
> On Mon, Nov 13, 2023 at 03:59:20PM +0100, Francesco Dolcini wrote:
> > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > 
> > The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the
> > second supply to the USB5744 DT binding.
> > 
> > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> >  .../devicetree/bindings/usb/microchip,usb5744.yaml         | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> > index ff3a1707ef57..6d4cfd943f58 100644
> > --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> > +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> > @@ -36,7 +36,11 @@ properties:
> >  
> >    vdd-supply:
> >      description:
> > -      VDD power supply to the hub
> > +      3V3 power supply to the hub
> > +
> > +  vdd2-supply:
> > +    description:
> > +      1V2 power supply to the hub
> 
> How about v1p2-supply?

The reason for vdd2 is this

/*
 * Use generic names, as the actual names might differ between hubs. If a new
 * hub requires more than the currently supported supplies, add a new one here.
 */
static const char * const supply_names[] = {
	"vdd",
	"vdd2",
};

from drivers/usb/misc/onboard_usb_hub.c.

Francesco

Re: [PATCH v1 1/2] dt-bindings: usb: microchip,usb5744: Add second supply

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Mon, Nov 13, 2023 at 09:08:10PM +0100, Francesco Dolcini wrote:
> Hello Conor,
> thanks for the review.
> 
> On Mon, Nov 13, 2023 at 07:55:20PM +0000, Conor Dooley wrote:
> > On Mon, Nov 13, 2023 at 03:59:20PM +0100, Francesco Dolcini wrote:
> > > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > > 
> > > The USB5744 has two power supplies one for 3V3 and one for 1V2. Add the
> > > second supply to the USB5744 DT binding.
> > > 
> > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > ---
> > >  .../devicetree/bindings/usb/microchip,usb5744.yaml         | 7 ++++++-
> > >  1 file changed, 6 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> > > index ff3a1707ef57..6d4cfd943f58 100644
> > > --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> > > @@ -36,7 +36,11 @@ properties:
> > >  
> > >    vdd-supply:
> > >      description:
> > > -      VDD power supply to the hub
> > > +      3V3 power supply to the hub
> > > +
> > > +  vdd2-supply:
> > > +    description:
> > > +      1V2 power supply to the hub
> > 
> > How about v1p2-supply?
> 
> The reason for vdd2 is this

I see.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]