* [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ
@ 2023-11-27 5:36 Ziqi Chen
2023-11-27 17:40 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Ziqi Chen @ 2023-11-27 5:36 UTC (permalink / raw)
To: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_ziqichen, quic_nguyenb, quic_nitirawa
Cc: linux-scsi, Alim Akhtar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Miquel Raynal, Linus Walleij, Wolfram Sang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
The Message Signaled Interrupts (MSI) support has been introduced in
UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
msi-parent property that point to the hardware entity which serves as
the MSI controller for this UFS controller.
Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
V2 -> V3: Wrap commit message to meet Linux coding style.
V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
incorporate the details about when MCQ/MSI got introduced.
---
Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index 985ea8f..31fe7f3 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -87,6 +87,8 @@ properties:
description:
Specifies max. load that can be drawn from VCCQ2 supply.
+ msi-parent: true
+
dependencies:
freq-table-hz: [ clocks ]
operating-points-v2: [ clocks, clock-names ]
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-27 5:36 [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
@ 2023-11-27 17:40 ` Conor Dooley
2023-11-27 17:42 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2023-11-27 17:40 UTC (permalink / raw)
To: Ziqi Chen
Cc: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa, linux-scsi,
Alim Akhtar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Miquel Raynal, Linus Walleij, Wolfram Sang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]
On Mon, Nov 27, 2023 at 01:36:02PM +0800, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) support has been introduced in
> UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> msi-parent property that point to the hardware entity which serves as
> the MSI controller for this UFS controller.
>
> Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
>
> V2 -> V3: Wrap commit message to meet Linux coding style.
> V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
> incorporate the details about when MCQ/MSI got introduced.
This should be below the --- line FYI. With that fixed,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index 985ea8f..31fe7f3 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -87,6 +87,8 @@ properties:
> description:
> Specifies max. load that can be drawn from VCCQ2 supply.
>
> + msi-parent: true
> +
> dependencies:
> freq-table-hz: [ clocks ]
> operating-points-v2: [ clocks, clock-names ]
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ
2023-11-27 17:40 ` Conor Dooley
@ 2023-11-27 17:42 ` Conor Dooley
0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-11-27 17:42 UTC (permalink / raw)
To: Ziqi Chen
Cc: quic_asutoshd, quic_cang, bvanassche, mani, stanley.chu,
adrian.hunter, beanhuo, avri.altman, junwoo80.lee,
martin.petersen, quic_nguyenb, quic_nitirawa, linux-scsi,
Alim Akhtar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Miquel Raynal, Linus Walleij, Wolfram Sang,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On Mon, Nov 27, 2023 at 05:40:45PM +0000, Conor Dooley wrote:
> On Mon, Nov 27, 2023 at 01:36:02PM +0800, Ziqi Chen wrote:
> > The Message Signaled Interrupts (MSI) support has been introduced in
> > UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> > approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> > msi-parent property that point to the hardware entity which serves as
> > the MSI controller for this UFS controller.
> >
> > Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com>
> >
>
> > V2 -> V3: Wrap commit message to meet Linux coding style.
> > V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
> > incorporate the details about when MCQ/MSI got introduced.
>
> This should be below the --- line FYI. With that fixed,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Also, you omitted an ack from Krzysztof in
<ae2f2dc9-4c08-4db8-bfae-80608723d8c3@linaro.org>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-27 17:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-27 5:36 [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ Ziqi Chen
2023-11-27 17:40 ` Conor Dooley
2023-11-27 17:42 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox