[PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[Dmitry Rokosov]

It is primarily based on the G12A thermal controller, with only a slight
variation in the offset value of the efuse parameters. Therefore, this
patch series provides appropriate platform data and dt-bindings to
ensure proper support.

Changes v2 since v1 at [1]:
    - provide Neil RvB
    - remove 'amlogic,a1-thermal' fallback, cause it's not needed

Links:
    [1] https://lore.kernel.org/all/20240328133802.15651-1-ddrokosov@salutedevices.com/

Dmitry Rokosov (2):
  dt-bindings: thermal: amlogic: add support for A1 thermal sensor
  thermal: amlogic: support A1 SoC family Thermal Sensor controller

 .../devicetree/bindings/thermal/amlogic,thermal.yaml | 12 +++++++-----
 drivers/thermal/amlogic_thermal.c                    | 10 ++++++++++
 2 files changed, 17 insertions(+), 5 deletions(-)

-- 
2.43.0

[PATCH v2 1/2] dt-bindings: thermal: amlogic: add support for A1 thermal sensor

[Dmitry Rokosov]

Provide right compatible properties for Amlogic A1 Thermal Sensor
controller. A1 family supports only one thermal node - CPU thermal
sensor.

Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
---
 .../devicetree/bindings/thermal/amlogic,thermal.yaml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
index 20f8f9b3b971..01fccdfc4178 100644
--- a/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/amlogic,thermal.yaml
@@ -13,11 +13,13 @@ description: Binding for Amlogic Thermal
 
 properties:
   compatible:
-    items:
-      - enum:
-          - amlogic,g12a-cpu-thermal
-          - amlogic,g12a-ddr-thermal
-      - const: amlogic,g12a-thermal
+    oneOf:
+      - items:
+          - enum:
+              - amlogic,g12a-cpu-thermal
+              - amlogic,g12a-ddr-thermal
+          - const: amlogic,g12a-thermal
+      - const: amlogic,a1-cpu-thermal
 
   reg:
     maxItems: 1
-- 
2.43.0

Re: [PATCH v2 1/2] dt-bindings: thermal: amlogic: add support for A1 thermal sensor

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

On Thu, Mar 28, 2024 at 10:13:10PM +0300, Dmitry Rokosov wrote:
> Provide right compatible properties for Amlogic A1 Thermal Sensor
> controller. A1 family supports only one thermal node - CPU thermal
> sensor.
> 
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH v2 2/2] thermal: amlogic: support A1 SoC family Thermal Sensor controller

[Dmitry Rokosov]

In comparison to other Amlogic chips, there is one key difference.
The offset for the sec_ao base, also known as u_efuse_off, is special,
while other aspects remain the same.

Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/thermal/amlogic_thermal.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index 5877cde25b79..1d23afd32013 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -222,6 +222,12 @@ static const struct amlogic_thermal_data amlogic_thermal_g12a_ddr_param = {
 	.regmap_config = &amlogic_thermal_regmap_config_g12a,
 };
 
+static const struct amlogic_thermal_data amlogic_thermal_a1_cpu_param = {
+	.u_efuse_off = 0x114,
+	.calibration_parameters = &amlogic_thermal_g12a,
+	.regmap_config = &amlogic_thermal_regmap_config_g12a,
+};
+
 static const struct of_device_id of_amlogic_thermal_match[] = {
 	{
 		.compatible = "amlogic,g12a-ddr-thermal",
@@ -231,6 +237,10 @@ static const struct of_device_id of_amlogic_thermal_match[] = {
 		.compatible = "amlogic,g12a-cpu-thermal",
 		.data = &amlogic_thermal_g12a_cpu_param,
 	},
+	{
+		.compatible = "amlogic,a1-cpu-thermal",
+		.data = &amlogic_thermal_a1_cpu_param,
+	},
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, of_amlogic_thermal_match);
-- 
2.43.0

Re: [PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[Daniel Lezcano]

On 28/03/2024 20:13, Dmitry Rokosov wrote:
> It is primarily based on the G12A thermal controller, with only a slight
> variation in the offset value of the efuse parameters. Therefore, this
> patch series provides appropriate platform data and dt-bindings to
> ensure proper support.


Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[Dmitry Rokosov]

Hello Daniel,

Could you please let me know in which repository you have applied this
change? I am trying to cherry-pick the original applied commit and apply
it to our internal mainline branch instead of the internal commit.
However, I am unable to find the applied series in any of the
repositories on git.kernel.org.

On Thu, Apr 04, 2024 at 02:23:21PM +0200, Daniel Lezcano wrote:
> On 28/03/2024 20:13, Dmitry Rokosov wrote:
> > It is primarily based on the G12A thermal controller, with only a slight
> > variation in the offset value of the efuse parameters. Therefore, this
> > patch series provides appropriate platform data and dt-bindings to
> > ensure proper support.
> 
> 
> Applied, thanks

-- 
Thank you,
Dmitry

Re: [PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[Dmitry Rokosov]

Hello Neil,

I hope you're doing well. I was wondering if you could assist me with
below problem.

I'm a bit confused about which kernel repository the series was applied
to. I asked Daniel about it, but unfortunately, I didn't receive any
feedback from him. Could you provide some clarification on this matter?

Thank you in advance for your help.

On Wed, Apr 17, 2024 at 11:40:07AM +0300, Dmitry Rokosov wrote:
> Hello Daniel,
> 
> Could you please let me know in which repository you have applied this
> change? I am trying to cherry-pick the original applied commit and apply
> it to our internal mainline branch instead of the internal commit.
> However, I am unable to find the applied series in any of the
> repositories on git.kernel.org.
> 
> On Thu, Apr 04, 2024 at 02:23:21PM +0200, Daniel Lezcano wrote:
> > On 28/03/2024 20:13, Dmitry Rokosov wrote:
> > > It is primarily based on the G12A thermal controller, with only a slight
> > > variation in the offset value of the efuse parameters. Therefore, this
> > > patch series provides appropriate platform data and dt-bindings to
> > > ensure proper support.
> > 
> > 
> > Applied, thanks
> 

-- 
Thank you,
Dmitry

Re: [PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[Daniel Lezcano]

Hi Dmitry,

On 26/04/2024 09:31, Dmitry Rokosov wrote:
> Hello Neil,
> 
> I hope you're doing well. I was wondering if you could assist me with
> below problem.
> 
> I'm a bit confused about which kernel repository the series was applied
> to. I asked Daniel about it, but unfortunately, I didn't receive any
> feedback from him. Could you provide some clarification on this matter?
> 
> Thank you in advance for your help.

I was OoO the last two weeks.

Your series is in my tree [1], which is pulled automatically by the 
linux-pm tree in its bleeding-edge branch.

Today, this branch will move to the linux-next branch [2] which will 
also be pulled by the linux-pm/next branch automatically.

Hope that helps and sorry for the delay to answer

   -- Daniel

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/bleeding-edge

[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/linux-next




-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH v2 0/2] thermal: amlogic: introduce A1 SoC family Thermal Sensor controller

[Dmitry Rokosov]

Hello Daniel,

On Fri, Apr 26, 2024 at 09:57:29AM +0200, Daniel Lezcano wrote:
> 
> Hi Dmitry,
> 
> On 26/04/2024 09:31, Dmitry Rokosov wrote:
> > Hello Neil,
> > 
> > I hope you're doing well. I was wondering if you could assist me with
> > below problem.
> > 
> > I'm a bit confused about which kernel repository the series was applied
> > to. I asked Daniel about it, but unfortunately, I didn't receive any
> > feedback from him. Could you provide some clarification on this matter?
> > 
> > Thank you in advance for your help.
> 
> I was OoO the last two weeks.
> 
> Your series is in my tree [1], which is pulled automatically by the linux-pm
> tree in its bleeding-edge branch.
> 
> Today, this branch will move to the linux-next branch [2] which will also be
> pulled by the linux-pm/next branch automatically.
> 
> Hope that helps and sorry for the delay to answer
> 
>   -- Daniel
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/bleeding-edge
> 
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/linux-next

Thanks a lot for the update! Now I see the patches in the above repos.

-- 
Thank you,
Dmitry