* [PATCH] arm64: dts: allwinner: h616: Fix I2C0 pins
@ 2024-03-29 10:38 Andre Przywara
2024-04-14 9:31 ` Jernej Škrabec
2024-04-15 21:28 ` Jernej Škrabec
0 siblings, 2 replies; 3+ messages in thread
From: Andre Przywara @ 2024-03-29 10:38 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland
Cc: devicetree, linux-sunxi
Currently we specify the pins for the I2C0 function as PI6 and PI7, even
though they are actually PI5 and PI6. Linux' pinctrl driver and the H616
user manual confirm this.
Fix the pin names in the pins property. None of the existing DTs in the
tree seems to use I2C0, which explains why this went unnoticed.
Fixes: 0d17c8651188 ("arm64: dts: allwinner: Add Allwinner H616 .dtsi file")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
index f756a396ea3da..95f09204337f0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
@@ -227,7 +227,7 @@ ext_rgmii_pins: rgmii-pins {
};
i2c0_pins: i2c0-pins {
- pins = "PI6", "PI7";
+ pins = "PI5", "PI6";
function = "i2c0";
};
--
2.35.8
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: allwinner: h616: Fix I2C0 pins
2024-03-29 10:38 [PATCH] arm64: dts: allwinner: h616: Fix I2C0 pins Andre Przywara
@ 2024-04-14 9:31 ` Jernej Škrabec
2024-04-15 21:28 ` Jernej Škrabec
1 sibling, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2024-04-14 9:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Samuel Holland, Andre Przywara
Cc: devicetree, linux-sunxi
Dne petek, 29. marec 2024 ob 11:38:25 CEST je Andre Przywara napisal(a):
> Currently we specify the pins for the I2C0 function as PI6 and PI7, even
> though they are actually PI5 and PI6. Linux' pinctrl driver and the H616
> user manual confirm this.
>
> Fix the pin names in the pins property. None of the existing DTs in the
> tree seems to use I2C0, which explains why this went unnoticed.
>
> Fixes: 0d17c8651188 ("arm64: dts: allwinner: Add Allwinner H616 .dtsi file")
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index f756a396ea3da..95f09204337f0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -227,7 +227,7 @@ ext_rgmii_pins: rgmii-pins {
> };
>
> i2c0_pins: i2c0-pins {
> - pins = "PI6", "PI7";
> + pins = "PI5", "PI6";
> function = "i2c0";
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: allwinner: h616: Fix I2C0 pins
2024-03-29 10:38 [PATCH] arm64: dts: allwinner: h616: Fix I2C0 pins Andre Przywara
2024-04-14 9:31 ` Jernej Škrabec
@ 2024-04-15 21:28 ` Jernej Škrabec
1 sibling, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2024-04-15 21:28 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Samuel Holland, Andre Przywara
Cc: devicetree, linux-sunxi
Dne petek, 29. marec 2024 ob 11:38:25 GMT +2 je Andre Przywara napisal(a):
> Currently we specify the pins for the I2C0 function as PI6 and PI7, even
> though they are actually PI5 and PI6. Linux' pinctrl driver and the H616
> user manual confirm this.
>
> Fix the pin names in the pins property. None of the existing DTs in the
> tree seems to use I2C0, which explains why this went unnoticed.
>
> Fixes: 0d17c8651188 ("arm64: dts: allwinner: Add Allwinner H616 .dtsi file")
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Queued for 6.10 as it doesn't affect any current DT.
Best regards,
Jernej
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index f756a396ea3da..95f09204337f0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -227,7 +227,7 @@ ext_rgmii_pins: rgmii-pins {
> };
>
> i2c0_pins: i2c0-pins {
> - pins = "PI6", "PI7";
> + pins = "PI5", "PI6";
> function = "i2c0";
> };
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-15 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-29 10:38 [PATCH] arm64: dts: allwinner: h616: Fix I2C0 pins Andre Przywara
2024-04-14 9:31 ` Jernej Škrabec
2024-04-15 21:28 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox