From: Jonathan Cameron <jic23@kernel.org>
To: Angelo Dureghello <adureghello@baylibre.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
nuno.sa@analog.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range
Date: Sat, 4 May 2024 12:30:47 +0100 [thread overview]
Message-ID: <20240504123047.0b4299c5@jic23-huawei> (raw)
In-Reply-To: <20240503185528.2043127-1-adureghello@baylibre.org>
On Fri, 3 May 2024 20:55:28 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Fix output range, as per datasheet must be -2.5 to 7.5.
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
When resending to add people and lists to CC, say that somewhere, or just
mark it as a v2 with the change being to increase the cc list.
Otherwise tooling and maintainers can both get confused!
Patch looks fine to me.
Jonathan
> Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> index 96340a05754c..8265d709094d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> @@ -139,7 +139,7 @@ allOf:
> Voltage output range of the channel as <minimum, maximum>
> Required connections:
> Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
> - Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
> + Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
> oneOf:
> - items:
> - const: 0
next prev parent reply other threads:[~2024-05-04 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 18:55 [PATCH] dt-bindings: iio: dac: fix ad354xr output range Angelo Dureghello
2024-05-04 11:30 ` Jonathan Cameron [this message]
2024-05-04 11:43 ` Krzysztof Kozlowski
2024-05-05 10:04 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504123047.0b4299c5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=adureghello@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox