* [PATCH] dt-bindings: iio: dac: fix ad354xr output range
@ 2024-05-03 18:55 Angelo Dureghello
2024-05-04 11:30 ` Jonathan Cameron
2024-05-04 11:43 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Angelo Dureghello @ 2024-05-03 18:55 UTC (permalink / raw)
To: lars, Michael.Hennerich, nuno.sa, jic23, robh, krzk+dt, conor+dt
Cc: linux-iio, devicetree, linux-kernel, Angelo Dureghello
From: Angelo Dureghello <adureghello@baylibre.com>
Fix output range, as per datasheet must be -2.5 to 7.5.
Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
---
Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
index 96340a05754c..8265d709094d 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
@@ -139,7 +139,7 @@ allOf:
Voltage output range of the channel as <minimum, maximum>
Required connections:
Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
- Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
+ Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
oneOf:
- items:
- const: 0
--
2.45.0.rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range
2024-05-03 18:55 [PATCH] dt-bindings: iio: dac: fix ad354xr output range Angelo Dureghello
@ 2024-05-04 11:30 ` Jonathan Cameron
2024-05-04 11:43 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-05-04 11:30 UTC (permalink / raw)
To: Angelo Dureghello
Cc: lars, Michael.Hennerich, nuno.sa, robh, krzk+dt, conor+dt,
linux-iio, devicetree, linux-kernel
On Fri, 3 May 2024 20:55:28 +0200
Angelo Dureghello <adureghello@baylibre.com> wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Fix output range, as per datasheet must be -2.5 to 7.5.
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
When resending to add people and lists to CC, say that somewhere, or just
mark it as a v2 with the change being to increase the cc list.
Otherwise tooling and maintainers can both get confused!
Patch looks fine to me.
Jonathan
> Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> index 96340a05754c..8265d709094d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> @@ -139,7 +139,7 @@ allOf:
> Voltage output range of the channel as <minimum, maximum>
> Required connections:
> Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
> - Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
> + Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
> oneOf:
> - items:
> - const: 0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range
2024-05-03 18:55 [PATCH] dt-bindings: iio: dac: fix ad354xr output range Angelo Dureghello
2024-05-04 11:30 ` Jonathan Cameron
@ 2024-05-04 11:43 ` Krzysztof Kozlowski
2024-05-05 10:04 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-04 11:43 UTC (permalink / raw)
To: Angelo Dureghello, lars, Michael.Hennerich, nuno.sa, jic23, robh,
krzk+dt, conor+dt
Cc: linux-iio, devicetree, linux-kernel
On 03/05/2024 20:55, Angelo Dureghello wrote:
> From: Angelo Dureghello <adureghello@baylibre.com>
>
> Fix output range, as per datasheet must be -2.5 to 7.5.
>
> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> ---
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range
2024-05-04 11:43 ` Krzysztof Kozlowski
@ 2024-05-05 10:04 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-05-05 10:04 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Angelo Dureghello, lars, Michael.Hennerich, nuno.sa, robh,
krzk+dt, conor+dt, linux-iio, devicetree, linux-kernel
On Sat, 4 May 2024 13:43:07 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 03/05/2024 20:55, Angelo Dureghello wrote:
> > From: Angelo Dureghello <adureghello@baylibre.com>
> >
> > Fix output range, as per datasheet must be -2.5 to 7.5.
> >
> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
> > ---
>
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Best regards,
> Krzysztof
>
I added a fixes tag to the commit that introduced this doc.
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-05 10:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-03 18:55 [PATCH] dt-bindings: iio: dac: fix ad354xr output range Angelo Dureghello
2024-05-04 11:30 ` Jonathan Cameron
2024-05-04 11:43 ` Krzysztof Kozlowski
2024-05-05 10:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox