* [PATCH v1 0/2] Adding iommus property and setting max link speed for PCIe @ 2024-04-30 16:31 Mrinmay Sarkar 2024-04-30 16:31 ` [PATCH v1 1/2] arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes Mrinmay Sarkar 2024-04-30 16:31 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie Mrinmay Sarkar 0 siblings, 2 replies; 6+ messages in thread From: Mrinmay Sarkar @ 2024-04-30 16:31 UTC (permalink / raw) To: andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, manivannan.sadhasivam Cc: quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, quic_krichai, quic_vbadigan, quic_schintav, Mrinmay Sarkar, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel This series adds 'iommus' DT property for PCIe RC nodes so that IOMMU can be used for address translation. and setting pcie max link speed to gen4 that was linited to gen3 ealier. Dependency for Patch 2 ---------------------- Depends on: https://lore.kernel.org/all/1714492540-15419-1-git-send-email-quic_msarkar@quicinc.com/ https://lore.kernel.org/all/1714494089-7917-1-git-send-email-quic_msarkar@quicinc.com/ Mrinmay Sarkar (2): arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie arch/arm64/boot/dts/qcom/sa8775p.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 1/2] arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes 2024-04-30 16:31 [PATCH v1 0/2] Adding iommus property and setting max link speed for PCIe Mrinmay Sarkar @ 2024-04-30 16:31 ` Mrinmay Sarkar 2024-05-24 14:51 ` Manivannan Sadhasivam 2024-04-30 16:31 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie Mrinmay Sarkar 1 sibling, 1 reply; 6+ messages in thread From: Mrinmay Sarkar @ 2024-04-30 16:31 UTC (permalink / raw) To: andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, manivannan.sadhasivam Cc: quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, quic_krichai, quic_vbadigan, quic_schintav, Mrinmay Sarkar, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel 'iommus' is a list of phandle and IOMMU specifier pairs that describe the IOMMU master interfaces of the device. Specified this property in PCIe DT nodes so that IOMMU can be used for address translation. Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 9065645..0c52180 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3666,6 +3666,7 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; interconnect-names = "pcie-mem", "cpu-pcie"; + iommus = <&pcie_smmu 0x0000 0x7f>; iommu-map = <0x0 &pcie_smmu 0x0000 0x1>, <0x100 &pcie_smmu 0x0001 0x1>; @@ -3822,6 +3823,7 @@ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_1 0>; interconnect-names = "pcie-mem", "cpu-pcie"; + iommus = <&pcie_smmu 0x0080 0x7f>; iommu-map = <0x0 &pcie_smmu 0x0080 0x1>, <0x100 &pcie_smmu 0x0081 0x1>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes 2024-04-30 16:31 ` [PATCH v1 1/2] arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes Mrinmay Sarkar @ 2024-05-24 14:51 ` Manivannan Sadhasivam 0 siblings, 0 replies; 6+ messages in thread From: Manivannan Sadhasivam @ 2024-05-24 14:51 UTC (permalink / raw) To: Mrinmay Sarkar Cc: andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, quic_krichai, quic_vbadigan, quic_schintav, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel On Tue, Apr 30, 2024 at 10:01:50PM +0530, Mrinmay Sarkar wrote: > 'iommus' is a list of phandle and IOMMU specifier pairs that describe > the IOMMU master interfaces of the device. Specified this property in > PCIe DT nodes so that IOMMU can be used for address translation. > This patch description is heavily misleading. Even without the 'iommus' property, there will be IOMMU translation because of 'iommu-map'. And I recently got rid of 'iommus' property from all DTs because it is not really required for the translation (it allows the host bridge to bind to IOMMU, but that's not what we want). This patch is intented to fix the IOMMU fault that occurs whenever the EP is attached to the host. But you never described or even mentioned about the IOMMU fault. Please describe the problem clearly and explain how the patch fixes that in patch description. Now for the IOMMU fault, I did some investigation and found that the fault is happening due to some AER generated by the bridge whenever the device is attached to the host. Interestingly, there was no AER IRQ received on the host. But that can be expected due to the IOMMU fault as that could've blocked the AER MSI from reaching the interrupt controller. And 'lspci' shows that the bridge (even device) generated CE error (RxErr): CESta: RxErr+ BadTLP- BadDLLP- Rollover- Timeout+ AdvNonFatalErr- But I dont' know why the IOMMU fault occurs. I also tried to manually inject the AER errors and I saw the AER IRQs are generated correctly. So this confirms that there is no problem with AER itself. For experimenting, I reduced the PCIe bandwidth to Gen 2, and the above error was gone. So this hints that there could be something wrong with the PHY. And yes, adding the 'iommus' property indeed makes the IOMMU fault go away, but still I can see the AER error in lspci, but no actual IRQ received (weird). So this patch is not really _fixing_ the issue, but just masking it in some form. Please investigate on why the RxErr is being generated and how that ended up as an IOMMU fault instead of an IRQ. - Mani > Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 9065645..0c52180 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -3666,6 +3666,7 @@ > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_0 0>; > interconnect-names = "pcie-mem", "cpu-pcie"; > > + iommus = <&pcie_smmu 0x0000 0x7f>; > iommu-map = <0x0 &pcie_smmu 0x0000 0x1>, > <0x100 &pcie_smmu 0x0001 0x1>; > > @@ -3822,6 +3823,7 @@ > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_PCIE_1 0>; > interconnect-names = "pcie-mem", "cpu-pcie"; > > + iommus = <&pcie_smmu 0x0080 0x7f>; > iommu-map = <0x0 &pcie_smmu 0x0080 0x1>, > <0x100 &pcie_smmu 0x0081 0x1>; > > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம் ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie 2024-04-30 16:31 [PATCH v1 0/2] Adding iommus property and setting max link speed for PCIe Mrinmay Sarkar 2024-04-30 16:31 ` [PATCH v1 1/2] arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes Mrinmay Sarkar @ 2024-04-30 16:31 ` Mrinmay Sarkar 2024-04-30 17:50 ` Dmitry Baryshkov 1 sibling, 1 reply; 6+ messages in thread From: Mrinmay Sarkar @ 2024-04-30 16:31 UTC (permalink / raw) To: andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, manivannan.sadhasivam Cc: quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, quic_krichai, quic_vbadigan, quic_schintav, Mrinmay Sarkar, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel Adding this change to set max link speed to gen4 as sa8775p supports gen4 so that pcie link can be enumerated as gen4. Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 0c52180..aad2cd7 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -3730,7 +3730,7 @@ power-domains = <&gcc PCIE_0_GDSC>; phys = <&pcie0_phy>; phy-names = "pciephy"; - max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ + max-link-speed = <4>; num-lanes = <2>; status = "disabled"; @@ -3888,7 +3888,7 @@ power-domains = <&gcc PCIE_1_GDSC>; phys = <&pcie1_phy>; phy-names = "pciephy"; - max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ + max-link-speed = <4>; num-lanes = <4>; status = "disabled"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie 2024-04-30 16:31 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie Mrinmay Sarkar @ 2024-04-30 17:50 ` Dmitry Baryshkov 2024-05-06 11:04 ` Mrinmay Sarkar 0 siblings, 1 reply; 6+ messages in thread From: Dmitry Baryshkov @ 2024-04-30 17:50 UTC (permalink / raw) To: Mrinmay Sarkar Cc: andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, manivannan.sadhasivam, quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, quic_krichai, quic_vbadigan, quic_schintav, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel On Tue, 30 Apr 2024 at 19:33, Mrinmay Sarkar <quic_msarkar@quicinc.com> wrote: > > Adding this change to set max link speed to gen4 as sa8775p supports > gen4 so that pcie link can be enumerated as gen4. Previous patches mentioned stability issues. Were they solved? > > Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 0c52180..aad2cd7 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -3730,7 +3730,7 @@ > power-domains = <&gcc PCIE_0_GDSC>; > phys = <&pcie0_phy>; > phy-names = "pciephy"; > - max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ > + max-link-speed = <4>; > num-lanes = <2>; > > status = "disabled"; > @@ -3888,7 +3888,7 @@ > power-domains = <&gcc PCIE_1_GDSC>; > phys = <&pcie1_phy>; > phy-names = "pciephy"; > - max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ I think you've just sent a patchset which adds this node. Is there any reason for setting the max-link-speed to 3 just to change it to 4 immediately? > + max-link-speed = <4>; > num-lanes = <4>; > > status = "disabled"; > -- > 2.7.4 > > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie 2024-04-30 17:50 ` Dmitry Baryshkov @ 2024-05-06 11:04 ` Mrinmay Sarkar 0 siblings, 0 replies; 6+ messages in thread From: Mrinmay Sarkar @ 2024-05-06 11:04 UTC (permalink / raw) To: Dmitry Baryshkov Cc: andersson, krzysztof.kozlowski+dt, conor+dt, konrad.dybcio, manivannan.sadhasivam, quic_shazhuss, quic_nitegupt, quic_ramkri, quic_nayiluri, quic_krichai, quic_vbadigan, quic_schintav, Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel On 4/30/2024 11:20 PM, Dmitry Baryshkov wrote: > On Tue, 30 Apr 2024 at 19:33, Mrinmay Sarkar <quic_msarkar@quicinc.com> wrote: >> Adding this change to set max link speed to gen4 as sa8775p supports >> gen4 so that pcie link can be enumerated as gen4. > Previous patches mentioned stability issues. Were they solved? Hi Dmitry, Thanks for review. Actually earlier gen4 related equalization setting was missing in driver. That's why gen4 was not stable and it was coming to gen3. With this below driver change gen4 is stable now https://lore.kernel.org/all/20240501163610.8900-1-quic_schintav@quicinc.com/ >> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> index 0c52180..aad2cd7 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >> @@ -3730,7 +3730,7 @@ >> power-domains = <&gcc PCIE_0_GDSC>; >> phys = <&pcie0_phy>; >> phy-names = "pciephy"; >> - max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ >> + max-link-speed = <4>; >> num-lanes = <2>; >> >> status = "disabled"; >> @@ -3888,7 +3888,7 @@ >> power-domains = <&gcc PCIE_1_GDSC>; >> phys = <&pcie1_phy>; >> phy-names = "pciephy"; >> - max-link-speed = <3>; /* FIXME: Limiting the Gen speed due to stability issues */ > I think you've just sent a patchset which adds this node. Is there any > reason for setting the max-link-speed to 3 just to change it to 4 > immediately? Earlier we were not sure about the root cause of the issue so limited the speed to gen3. Now as we have the solution for this issue so moving to gen4. > Thanks, > Mrinmay >> + max-link-speed = <4>; >> num-lanes = <4>; >> >> status = "disabled"; >> -- >> 2.7.4 >> >> > > -- > With best wishes > > Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-24 14:51 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-04-30 16:31 [PATCH v1 0/2] Adding iommus property and setting max link speed for PCIe Mrinmay Sarkar 2024-04-30 16:31 ` [PATCH v1 1/2] arm64: dts: qcom: sa8775p: Adding iommus property in pcie DT nodes Mrinmay Sarkar 2024-05-24 14:51 ` Manivannan Sadhasivam 2024-04-30 16:31 ` [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Set max link speed to gen4 for ep pcie Mrinmay Sarkar 2024-04-30 17:50 ` Dmitry Baryshkov 2024-05-06 11:04 ` Mrinmay Sarkar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox