* [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two)
@ 2024-06-05 10:56 Krzysztof Kozlowski
2024-06-05 16:55 ` Conor Dooley
2024-06-06 20:55 ` Rob Herring (Arm)
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-05 10:56 UTC (permalink / raw)
To: Sumit Semwal, Caleb Connolly, Neil Armstrong, Jessica Zhang,
Sam Ravnborg, David Airlie, Daniel Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Wronek, dri-devel,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DSI-attached devices could respond to more than one virtual channel
number, thus their bindings are supposed to constrain the 'reg' property
to match hardware. Add missing 'reg' constrain for DSI-attached display
panels, based on DTS sources in Linux kernel (assume all devices take
only one channel number).
Few bindings missed previous fixup: LG SW43408 and Raydium RM69380.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This should apply on any tree.
---
.../devicetree/bindings/display/panel/lg,sw43408.yaml | 4 +++-
.../devicetree/bindings/display/panel/raydium,rm69380.yaml | 5 +++--
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/lg,sw43408.yaml b/Documentation/devicetree/bindings/display/panel/lg,sw43408.yaml
index 1e08648f5bc7..bbaaa783d184 100644
--- a/Documentation/devicetree/bindings/display/panel/lg,sw43408.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lg,sw43408.yaml
@@ -21,7 +21,9 @@ properties:
items:
- const: lg,sw43408
- reg: true
+ reg:
+ maxItems: 1
+
port: true
vddi-supply: true
vpnl-supply: true
diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml
index b17765b2b351..ec445ff5631c 100644
--- a/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml
+++ b/Documentation/devicetree/bindings/display/panel/raydium,rm69380.yaml
@@ -28,6 +28,9 @@ properties:
to work with the indicated panel. The raydium,rm69380 compatible shall
always be provided as a fallback.
+ reg:
+ maxItems: 1
+
avdd-supply:
description: Analog voltage rail
@@ -38,8 +41,6 @@ properties:
maxItems: 1
description: phandle of gpio for reset line - This should be active low
- reg: true
-
required:
- compatible
- reg
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two)
2024-06-05 10:56 [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two) Krzysztof Kozlowski
@ 2024-06-05 16:55 ` Conor Dooley
2024-06-06 20:55 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-06-05 16:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Sumit Semwal, Caleb Connolly, Neil Armstrong, Jessica Zhang,
Sam Ravnborg, David Airlie, Daniel Vetter, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Wronek, dri-devel,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On Wed, Jun 05, 2024 at 12:56:59PM +0200, Krzysztof Kozlowski wrote:
> DSI-attached devices could respond to more than one virtual channel
> number, thus their bindings are supposed to constrain the 'reg' property
> to match hardware. Add missing 'reg' constrain for DSI-attached display
> panels, based on DTS sources in Linux kernel (assume all devices take
> only one channel number).
>
> Few bindings missed previous fixup: LG SW43408 and Raydium RM69380.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two)
2024-06-05 10:56 [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two) Krzysztof Kozlowski
2024-06-05 16:55 ` Conor Dooley
@ 2024-06-06 20:55 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-06-06 20:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, devicetree, Caleb Connolly, linux-kernel,
Jessica Zhang, Thomas Zimmermann, dri-devel, David Wronek,
Daniel Vetter, Conor Dooley, Maarten Lankhorst, David Airlie,
Maxime Ripard, Neil Armstrong, Sumit Semwal, Sam Ravnborg
On Wed, 05 Jun 2024 12:56:59 +0200, Krzysztof Kozlowski wrote:
> DSI-attached devices could respond to more than one virtual channel
> number, thus their bindings are supposed to constrain the 'reg' property
> to match hardware. Add missing 'reg' constrain for DSI-attached display
> panels, based on DTS sources in Linux kernel (assume all devices take
> only one channel number).
>
> Few bindings missed previous fixup: LG SW43408 and Raydium RM69380.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This should apply on any tree.
> ---
> .../devicetree/bindings/display/panel/lg,sw43408.yaml | 4 +++-
> .../devicetree/bindings/display/panel/raydium,rm69380.yaml | 5 +++--
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-06 20:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-05 10:56 [PATCH] dt-bindings: display: panel: constrain 'reg' in DSI panels (part two) Krzysztof Kozlowski
2024-06-05 16:55 ` Conor Dooley
2024-06-06 20:55 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox