Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Kaustabh Chakraborty <kauschluss@disroot.org>,
	linux-iio@vger.kernel.org, denis.ciocca@st.com,
	devicetree@vger.kernel.org, linus.walleij@linaro.org,
	robh+dt@kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer
Date: Sun, 23 Jun 2024 15:30:22 +0100	[thread overview]
Message-ID: <20240623-lure-rubber-27c1f8f7ec66@spud> (raw)
In-Reply-To: <20240623110305.5d961052@jic23-huawei>

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

On Sun, Jun 23, 2024 at 11:03:05AM +0100, Jonathan Cameron wrote:
> On Sat, 22 Jun 2024 18:03:46 +0530
> Kaustabh Chakraborty <kauschluss@disroot.org> wrote:
> 
> > LIS2DS12 is an accelerometer by STMicroelectronics. It is identifiable by
> > its WhoAmI value 0x43.
> > 
> > Its register interface is not compatible with existing parts. For example:
> > 
> > - The full-scale values are present in register 0x20, in bits 2 and 3
> >   (mask 0x0c). Most other supported sensors have the register address set
> >   to 0x21, 0x23, 0x24, or 0x25. There is one sensor setting though
> >   (bearing WhoAmI 0x3b) which has it's address set to 0x20, but the mask is
> >   set to 0x20, not 0x0c.
> > 
> > - The full-scale values 2G, 4G, 8G, and 16G correspond to the register
> >   values 0x00, 0x02, 0x03, 0x01 respectively. None of the sensor settings
> >   have the value 0x01 associated with 16G.
> > 
> > Add the compatible string without any fallback.
> > 
> > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> Given the only requested change was this description and everyone seemed
> happy with it in previous thread, I'll pick this series up now.

ye, fine in my books. I should've prob acked explicitly when I assented
to the wording on the previous version.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2024-06-23 14:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-22 12:33 [PATCH v5 1/2] iio: accel: st_accel: add support for LIS2DS12 Kaustabh Chakraborty
2024-06-22 12:33 ` [PATCH v5 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer Kaustabh Chakraborty
2024-06-23 10:03   ` Jonathan Cameron
2024-06-23 14:30     ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240623-lure-rubber-27c1f8f7ec66@spud \
    --to=conor@kernel.org \
    --cc=denis.ciocca@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kauschluss@disroot.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox