[PATCH] dt-bindings: iio: ad4695: fix common-mode-channel

[PATCH] dt-bindings: iio: ad4695: fix common-mode-channel

[David Lechner]

The common-mode-channel property is a scalar, not an array, so we should
not be using items: in the schema when specifying allowable values.

Reported-by: Rob Herring <robh@kernel.org>
Closes: https://lore.kernel.org/linux-iio/CAL_JsqKaddw8FnPfdnhKhHUb8AcTxFadc_eZmxjX0QxFR80=mw@mail.gmail.com/
Fixes: b40cafc11436 ("dt-bindings: iio: adc: add AD4695 and similar ADCs")
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml
index a2e824e26691..310f046e139f 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml
@@ -136,8 +136,7 @@ patternProperties:
           and OxFE is COM. Macros are available for these values in
           dt-bindings/iio/adi,ad4695.h. Values 1 to 15 correspond to INx inputs.
           Only odd numbered INx inputs can be used as common mode channels.
-        items:
-          enum: [1, 3, 5, 7, 9, 11, 13, 15, 0xFE, 0xFF]
+        enum: [1, 3, 5, 7, 9, 11, 13, 15, 0xFE, 0xFF]
         default: 0xFF
 
       adi,no-high-z:
@@ -202,8 +201,7 @@ allOf:
             reg:
               maximum: 7
             common-mode-channel:
-              items:
-                enum: [1, 3, 5, 7, 0xFE, 0xFF]
+              enum: [1, 3, 5, 7, 0xFE, 0xFF]
         "^channel@[8-9a-f]$": false
 
 unevaluatedProperties: false

---
base-commit: 7cad163c39cb642ed587d3eeb37a5637ee02740f
change-id: 20240808-iio-adc-ad4695-fix-dt-bindings-520ade561235

Re: [PATCH] dt-bindings: iio: ad4695: fix common-mode-channel

[Krzysztof Kozlowski]

On 08/08/2024 23:12, David Lechner wrote:
> The common-mode-channel property is a scalar, not an array, so we should
> not be using items: in the schema when specifying allowable values.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-iio/CAL_JsqKaddw8FnPfdnhKhHUb8AcTxFadc_eZmxjX0QxFR80=mw@mail.gmail.com/
> Fixes: b40cafc11436 ("dt-bindings: iio: adc: add AD4695 and similar ADCs")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: iio: ad4695: fix common-mode-channel

[Rob Herring (Arm)]

On Thu, 08 Aug 2024 16:12:08 -0500, David Lechner wrote:
> The common-mode-channel property is a scalar, not an array, so we should
> not be using items: in the schema when specifying allowable values.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Closes: https://lore.kernel.org/linux-iio/CAL_JsqKaddw8FnPfdnhKhHUb8AcTxFadc_eZmxjX0QxFR80=mw@mail.gmail.com/
> Fixes: b40cafc11436 ("dt-bindings: iio: adc: add AD4695 and similar ADCs")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Thanks for the quick fix.

Acked-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH] dt-bindings: iio: ad4695: fix common-mode-channel

[Jonathan Cameron]

On Fri, 9 Aug 2024 12:06:40 -0600
"Rob Herring (Arm)" <robh@kernel.org> wrote:

> On Thu, 08 Aug 2024 16:12:08 -0500, David Lechner wrote:
> > The common-mode-channel property is a scalar, not an array, so we should
> > not be using items: in the schema when specifying allowable values.
> > 
> > Reported-by: Rob Herring <robh@kernel.org>
> > Closes: https://lore.kernel.org/linux-iio/CAL_JsqKaddw8FnPfdnhKhHUb8AcTxFadc_eZmxjX0QxFR80=mw@mail.gmail.com/
> > Fixes: b40cafc11436 ("dt-bindings: iio: adc: add AD4695 and similar ADCs")
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >   
> 
> Thanks for the quick fix.
> 
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> 


Applied and pushed out for next to pick up. 
Thanks,

Jonathan