Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes
@ 2024-08-11 15:17 Krzysztof Kozlowski
  2024-08-12 16:08 ` Conor Dooley
  2024-09-02 12:55 ` Srinivas Kandagatla
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-11 15:17 UTC (permalink / raw)
  To: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Fabrice Gasnier,
	devicetree, linux-stm32, linux-arm-kernel, linux-kernel
  Cc: Krzysztof Kozlowski

All nodes need an explicit additionalProperties or unevaluatedProperties
unless a $ref has one that's false.  Fixing this for STM32
Factory-programmed data binding needs referencing fixed layout schema
for children.  Add reference to the NVMEM deprecated cells for the
schema to be complete.

This fixes dt_binding_check warning:

  st,stm32-romem.yaml: ^.*@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
index 92bfe25f0571..3b2aa605a551 100644
--- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
+++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
@@ -17,6 +17,7 @@ maintainers:
 
 allOf:
   - $ref: nvmem.yaml#
+  - $ref: nvmem-deprecated-cells.yaml#
 
 properties:
   compatible:
@@ -32,6 +33,8 @@ properties:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    $ref: layouts/fixed-cell.yaml
+    unevaluatedProperties: false
 
     properties:
       st,non-secure-otp:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes
  2024-08-11 15:17 [PATCH] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes Krzysztof Kozlowski
@ 2024-08-12 16:08 ` Conor Dooley
  2024-09-02 12:55 ` Srinivas Kandagatla
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-08-12 16:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Srinivas Kandagatla, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Maxime Coquelin, Alexandre Torgue, Fabrice Gasnier,
	devicetree, linux-stm32, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Sun, Aug 11, 2024 at 05:17:37PM +0200, Krzysztof Kozlowski wrote:
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false.  Fixing this for STM32
> Factory-programmed data binding needs referencing fixed layout schema
> for children.  Add reference to the NVMEM deprecated cells for the
> schema to be complete.
> 
> This fixes dt_binding_check warning:
> 
>   st,stm32-romem.yaml: ^.*@[0-9a-f]+$: Missing additionalProperties/unevaluatedProperties constraint
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes
  2024-08-11 15:17 [PATCH] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes Krzysztof Kozlowski
  2024-08-12 16:08 ` Conor Dooley
@ 2024-09-02 12:55 ` Srinivas Kandagatla
  1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2024-09-02 12:55 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, Fabrice Gasnier, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel, Krzysztof Kozlowski


On Sun, 11 Aug 2024 17:17:37 +0200, Krzysztof Kozlowski wrote:
> All nodes need an explicit additionalProperties or unevaluatedProperties
> unless a $ref has one that's false.  Fixing this for STM32
> Factory-programmed data binding needs referencing fixed layout schema
> for children.  Add reference to the NVMEM deprecated cells for the
> schema to be complete.
> 
> This fixes dt_binding_check warning:
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes
      commit: 0d1d52a2d43b56d6bd33328583c81d85c1aa97f6

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-02 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-11 15:17 [PATCH] dt-bindings: nvmem: st,stm32-romem: add missing "unevaluatedProperties" on child nodes Krzysztof Kozlowski
2024-08-12 16:08 ` Conor Dooley
2024-09-02 12:55 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox