* [PATCH] dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then:
@ 2024-08-20 6:31 Krzysztof Kozlowski
2024-08-20 16:40 ` Conor Dooley
2024-08-21 21:32 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-20 6:31 UTC (permalink / raw)
To: Loic Poulain, Robert Foss, Andi Shyti, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-i2c, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Richard Acayan
Top level defines clocks as variable from 3 to 6 items, so each clause
in if:then: should narrow it further with explicit min and maxItems.
Without minItems, the constrain from top-level is being applied, thus
qcom,msm8996-cci allows between 3 and 4 clocks.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Older dtschema behaved differently and missing minItems was implied in
if:then:. However the preferred policy is to be explicit about such
schema - define strict constraints in if:then:.
Cc: Richard Acayan <mailingradian@gmail.com>
---
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index c33ae7b63b84..7dab3852c7f8 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -130,6 +130,7 @@ allOf:
then:
properties:
clocks:
+ minItems: 4
maxItems: 4
clock-names:
items:
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then:
2024-08-20 6:31 [PATCH] dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then: Krzysztof Kozlowski
@ 2024-08-20 16:40 ` Conor Dooley
2024-08-21 21:32 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-08-20 16:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Loic Poulain, Robert Foss, Andi Shyti, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-i2c, linux-arm-msm,
devicetree, linux-kernel, Richard Acayan
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Tue, Aug 20, 2024 at 08:31:24AM +0200, Krzysztof Kozlowski wrote:
> Top level defines clocks as variable from 3 to 6 items, so each clause
> in if:then: should narrow it further with explicit min and maxItems.
> Without minItems, the constrain from top-level is being applied, thus
> qcom,msm8996-cci allows between 3 and 4 clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then:
2024-08-20 6:31 [PATCH] dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then: Krzysztof Kozlowski
2024-08-20 16:40 ` Conor Dooley
@ 2024-08-21 21:32 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2024-08-21 21:32 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Loic Poulain, Robert Foss, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-i2c, linux-arm-msm, devicetree, linux-kernel,
Richard Acayan
Hi Krzysztof,
On Tue, Aug 20, 2024 at 08:31:24AM GMT, Krzysztof Kozlowski wrote:
> Top level defines clocks as variable from 3 to 6 items, so each clause
> in if:then: should narrow it further with explicit min and maxItems.
> Without minItems, the constrain from top-level is being applied, thus
> qcom,msm8996-cci allows between 3 and 4 clocks.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Merged in i2c/i2c-host.
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-21 21:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-20 6:31 [PATCH] dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then: Krzysztof Kozlowski
2024-08-20 16:40 ` Conor Dooley
2024-08-21 21:32 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox