* [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master
@ 2024-08-22 13:27 Krzysztof Kozlowski
2024-08-22 15:53 ` Conor Dooley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-22 13:27 UTC (permalink / raw)
To: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley, Andi Shyti,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andrew Jeffery,
Rayn Chen, linux-i2c, openbmc, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
Cc: Krzysztof Kozlowski
'multi-master' property is defined by core i2c-controller schema in
dtschema package, so binding which references it and has
unevaluatedProperties:false, does not need to mention it. It is
completely redundant here.
Suggested-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Reference:
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml#L114
---
Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 5 -----
1 file changed, 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
index 6df27b47b922..5b9bd2feda3b 100644
--- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
@@ -44,11 +44,6 @@ properties:
description: frequency of the bus clock in Hz defaults to 100 kHz when not
specified
- multi-master:
- type: boolean
- description:
- states that there is another master active on this bus
-
required:
- reg
- compatible
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master
2024-08-22 13:27 [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master Krzysztof Kozlowski
@ 2024-08-22 15:53 ` Conor Dooley
2024-08-23 0:47 ` Andi Shyti
2024-08-23 3:48 ` Andrew Jeffery
2 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-08-22 15:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley, Andi Shyti,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andrew Jeffery,
Rayn Chen, linux-i2c, openbmc, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
On Thu, Aug 22, 2024 at 03:27:08PM +0200, Krzysztof Kozlowski wrote:
> 'multi-master' property is defined by core i2c-controller schema in
> dtschema package, so binding which references it and has
> unevaluatedProperties:false, does not need to mention it. It is
> completely redundant here.
>
> Suggested-by: Andi Shyti <andi.shyti@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master
2024-08-22 13:27 [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master Krzysztof Kozlowski
2024-08-22 15:53 ` Conor Dooley
@ 2024-08-23 0:47 ` Andi Shyti
2024-08-23 3:48 ` Andrew Jeffery
2 siblings, 0 replies; 4+ messages in thread
From: Andi Shyti @ 2024-08-23 0:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Brendan Higgins, Benjamin Herrenschmidt, Joel Stanley,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Andrew Jeffery,
Rayn Chen, linux-i2c, openbmc, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
Hi Krzysztof,
On Thu, Aug 22, 2024 at 03:27:08PM GMT, Krzysztof Kozlowski wrote:
> 'multi-master' property is defined by core i2c-controller schema in
> dtschema package, so binding which references it and has
> unevaluatedProperties:false, does not need to mention it. It is
> completely redundant here.
>
> Suggested-by: Andi Shyti <andi.shyti@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks for taking care of this! Merged to i2c/i2c-host.
Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master
2024-08-22 13:27 [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master Krzysztof Kozlowski
2024-08-22 15:53 ` Conor Dooley
2024-08-23 0:47 ` Andi Shyti
@ 2024-08-23 3:48 ` Andrew Jeffery
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Jeffery @ 2024-08-23 3:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Brendan Higgins, Benjamin Herrenschmidt,
Joel Stanley, Andi Shyti, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Rayn Chen, linux-i2c, openbmc, devicetree,
linux-arm-kernel, linux-aspeed, linux-kernel
On Thu, 2024-08-22 at 15:27 +0200, Krzysztof Kozlowski wrote:
> 'multi-master' property is defined by core i2c-controller schema in
> dtschema package, so binding which references it and has
> unevaluatedProperties:false, does not need to mention it. It is
> completely redundant here.
>
> Suggested-by: Andi Shyti <andi.shyti@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-23 3:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 13:27 [PATCH] dt-bindings: i2c: aspeed: drop redundant multi-master Krzysztof Kozlowski
2024-08-22 15:53 ` Conor Dooley
2024-08-23 0:47 ` Andi Shyti
2024-08-23 3:48 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox