* [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings
@ 2024-08-30 7:01 Alexander Shiyan
2024-08-30 13:57 ` Conor Dooley
2024-09-10 8:44 ` Tomi Valkeinen
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Shiyan @ 2024-08-30 7:01 UTC (permalink / raw)
To: linux-media
Cc: Tomi Valkeinen, Mauro Carvalho Chehab, devicetree,
Alexander Shiyan
The ds90ub960 driver can now be used for the DS90UB954 chip as it has
a similar register set and configuration.
Let's add an additional compatibility line to the bindings.
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
index 0b71e6f911a8..86d43d949dd3 100644
--- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
@@ -19,6 +19,7 @@ allOf:
properties:
compatible:
enum:
+ - ti,ds90ub954-q1
- ti,ds90ub960-q1
- ti,ds90ub9702-q1
--
2.39.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings
2024-08-30 7:01 [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings Alexander Shiyan
@ 2024-08-30 13:57 ` Conor Dooley
2024-09-10 8:44 ` Tomi Valkeinen
1 sibling, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-08-30 13:57 UTC (permalink / raw)
To: Alexander Shiyan
Cc: linux-media, Tomi Valkeinen, Mauro Carvalho Chehab, devicetree
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
On Fri, Aug 30, 2024 at 10:01:17AM +0300, Alexander Shiyan wrote:
> The ds90ub960 driver can now be used for the DS90UB954 chip as it has
> a similar register set and configuration.
> Let's add an additional compatibility line to the bindings.
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
FYI, your threading is broken on this series, patch 1 & 2 are linked,
but the binding patch is not.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 0b71e6f911a8..86d43d949dd3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -19,6 +19,7 @@ allOf:
> properties:
> compatible:
> enum:
> + - ti,ds90ub954-q1
> - ti,ds90ub960-q1
> - ti,ds90ub9702-q1
>
> --
> 2.39.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings
2024-08-30 7:01 [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings Alexander Shiyan
2024-08-30 13:57 ` Conor Dooley
@ 2024-09-10 8:44 ` Tomi Valkeinen
2024-10-01 8:24 ` Alexander Shiyan
1 sibling, 1 reply; 4+ messages in thread
From: Tomi Valkeinen @ 2024-09-10 8:44 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: Mauro Carvalho Chehab, devicetree, linux-media
Hi,
On 30/08/2024 10:01, Alexander Shiyan wrote:
> The ds90ub960 driver can now be used for the DS90UB954 chip as it has
> a similar register set and configuration.
> Let's add an additional compatibility line to the bindings.
>
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
> Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> index 0b71e6f911a8..86d43d949dd3 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> @@ -19,6 +19,7 @@ allOf:
> properties:
> compatible:
> enum:
> + - ti,ds90ub954-q1
> - ti,ds90ub960-q1
> - ti,ds90ub9702-q1
>
The binding lists 6 ports as required, but UB954 only has 3 ports.
Tomi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings
2024-09-10 8:44 ` Tomi Valkeinen
@ 2024-10-01 8:24 ` Alexander Shiyan
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Shiyan @ 2024-10-01 8:24 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Mauro Carvalho Chehab, devicetree, linux-media
Hello Toni.
I don't know how to use condition blocks for YAML format. Can You help me?
If I understand correctly, it is necessary to create conditions here
for ti,ds90ub954-q1:
"link@[0-1]$" instead of "link@[0-3]$" and rewrite all port@x part.
Thanks!
вт, 10 сент. 2024 г. в 11:44, Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>:
>
> Hi,
>
> On 30/08/2024 10:01, Alexander Shiyan wrote:
> > The ds90ub960 driver can now be used for the DS90UB954 chip as it has
> > a similar register set and configuration.
> > Let's add an additional compatibility line to the bindings.
> >
> > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> > index 0b71e6f911a8..86d43d949dd3 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml
> > @@ -19,6 +19,7 @@ allOf:
> > properties:
> > compatible:
> > enum:
> > + - ti,ds90ub954-q1
> > - ti,ds90ub960-q1
> > - ti,ds90ub9702-q1
> >
>
> The binding lists 6 ports as required, but UB954 only has 3 ports.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-01 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 7:01 [PATCH 3/3] media: dt-bindings: i2c: ds90ub960: Add DS90UB954 chip to DS90UB960 bindings Alexander Shiyan
2024-08-30 13:57 ` Conor Dooley
2024-09-10 8:44 ` Tomi Valkeinen
2024-10-01 8:24 ` Alexander Shiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox