From: Alexandru Ardelean <aardelean@baylibre.com>
To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: jic23@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
lars@metafoo.de, michael.hennerich@analog.com,
gstols@baylibre.com, Alexandru Ardelean <aardelean@baylibre.com>,
David Lechner <dlechner@baylibre.com>
Subject: [PATCH v5 3/9] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct()
Date: Sat, 7 Sep 2024 09:50:36 +0300 [thread overview]
Message-ID: <20240907065043.771364-4-aardelean@baylibre.com> (raw)
In-Reply-To: <20240907065043.771364-1-aardelean@baylibre.com>
The ad7606_scan_direct() function returns 'int', which is fine for 16-bit
samples.
But when going to 18-bit samples, these need to be implemented as 32-bit
(or int) type.
In that case when getting samples (which can be negative), we'd get random
error codes.
So, the easiest thing is to just move the 'val' pointer to
'ad7606_scan_direct()'. This doesn't qualify as a fix, it's just a
preparation for 18-bit ADCs (of the AD7606 family).
Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
---
drivers/iio/adc/ad7606.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
index 8ebfe8abc3f4..fec728f5b3e9 100644
--- a/drivers/iio/adc/ad7606.c
+++ b/drivers/iio/adc/ad7606.c
@@ -114,7 +114,8 @@ static irqreturn_t ad7606_trigger_handler(int irq, void *p)
return IRQ_HANDLED;
}
-static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch)
+static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch,
+ int *val)
{
struct ad7606_state *st = iio_priv(indio_dev);
int ret;
@@ -129,7 +130,7 @@ static int ad7606_scan_direct(struct iio_dev *indio_dev, unsigned int ch)
ret = ad7606_read_samples(st);
if (ret == 0)
- ret = st->data[ch];
+ *val = sign_extend32(st->data[ch], 15);
error_ret:
gpiod_set_value(st->gpio_convst, 0);
@@ -149,10 +150,9 @@ static int ad7606_read_raw(struct iio_dev *indio_dev,
switch (m) {
case IIO_CHAN_INFO_RAW:
iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
- ret = ad7606_scan_direct(indio_dev, chan->address);
+ ret = ad7606_scan_direct(indio_dev, chan->address, val);
if (ret < 0)
return ret;
- *val = (short) ret;
return IIO_VAL_INT;
}
unreachable();
--
2.46.0
next prev parent reply other threads:[~2024-09-07 6:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 6:50 [PATCH v5 0/9] iio: adc: ad7606: add support for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 1/9] iio: adc: ad7606: remove frstdata check for serial mode Alexandru Ardelean
2024-09-07 14:51 ` Jonathan Cameron
2024-09-07 17:58 ` Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 2/9] iio: adc: ad7606: add 'bits' parameter to channels macros Alexandru Ardelean
2024-09-07 14:53 ` Jonathan Cameron
2024-09-07 6:50 ` Alexandru Ardelean [this message]
2024-09-07 6:50 ` [PATCH v5 4/9] iio: adc: ad7606: split a 'ad7606_sw_mode_setup()' from probe Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 5/9] iio: adc: ad7606: wrap channel ranges & scales into struct Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 6/9] iio: adc: ad7606: rework available attributes for SW channels Alexandru Ardelean
2024-09-07 15:03 ` Jonathan Cameron
2024-09-07 18:10 ` Alexandru Ardelean
2024-09-08 10:47 ` Jonathan Cameron
2024-09-07 6:50 ` [PATCH v5 7/9] dt-bindings: iio: adc: document diff-channels corner case for some ADCs Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 8/9] dt-bindings: iio: adc: add docs for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 9/9] iio: adc: ad7606: add support " Alexandru Ardelean
2024-09-07 15:20 ` Jonathan Cameron
2024-09-07 14:50 ` [PATCH v5 0/9] " Jonathan Cameron
2024-09-07 18:16 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240907065043.771364-4-aardelean@baylibre.com \
--to=aardelean@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gstols@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox