From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <aardelean@baylibre.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
lars@metafoo.de, michael.hennerich@analog.com,
gstols@baylibre.com
Subject: Re: [PATCH v5 2/9] iio: adc: ad7606: add 'bits' parameter to channels macros
Date: Sat, 7 Sep 2024 15:53:42 +0100 [thread overview]
Message-ID: <20240907155342.56109b37@jic23-huawei> (raw)
In-Reply-To: <20240907065043.771364-3-aardelean@baylibre.com>
On Sat, 7 Sep 2024 09:50:35 +0300
Alexandru Ardelean <aardelean@baylibre.com> wrote:
> There are some newer additions to the AD7606 family, which support 18 bit
> precision.
> Up until now, all chips were 16 bit.
Trivial but this is really odd style. Sort of has a paragraph and
a 'sub paragraph' going on.
Go with this:
There are some newer additions to the AD7606 family, which support 18 bit
precision. Up until now, all chips were 16 bit.
This change adds a 'bits' parameter to the AD760X_CHANNEL macro and renames
'ad7606_channels' -> 'ad7606_channels_16bit' for the current devices.
etc.
Patch looks fine to me.
>
> This change adds a 'bits' parameter to the AD760X_CHANNEL macro and renames
> 'ad7606_channels' -> 'ad7606_channels_16bit' for the current devices.
>
> The AD7606_SW_CHANNEL() macro is also introduced, as a short-hand for IIO
> channels in SW mode.
>
> Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>
next prev parent reply other threads:[~2024-09-07 14:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 6:50 [PATCH v5 0/9] iio: adc: ad7606: add support for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 1/9] iio: adc: ad7606: remove frstdata check for serial mode Alexandru Ardelean
2024-09-07 14:51 ` Jonathan Cameron
2024-09-07 17:58 ` Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 2/9] iio: adc: ad7606: add 'bits' parameter to channels macros Alexandru Ardelean
2024-09-07 14:53 ` Jonathan Cameron [this message]
2024-09-07 6:50 ` [PATCH v5 3/9] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct() Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 4/9] iio: adc: ad7606: split a 'ad7606_sw_mode_setup()' from probe Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 5/9] iio: adc: ad7606: wrap channel ranges & scales into struct Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 6/9] iio: adc: ad7606: rework available attributes for SW channels Alexandru Ardelean
2024-09-07 15:03 ` Jonathan Cameron
2024-09-07 18:10 ` Alexandru Ardelean
2024-09-08 10:47 ` Jonathan Cameron
2024-09-07 6:50 ` [PATCH v5 7/9] dt-bindings: iio: adc: document diff-channels corner case for some ADCs Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 8/9] dt-bindings: iio: adc: add docs for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-07 6:50 ` [PATCH v5 9/9] iio: adc: ad7606: add support " Alexandru Ardelean
2024-09-07 15:20 ` Jonathan Cameron
2024-09-07 14:50 ` [PATCH v5 0/9] " Jonathan Cameron
2024-09-07 18:16 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240907155342.56109b37@jic23-huawei \
--to=jic23@kernel.org \
--cc=aardelean@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=gstols@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox