* [PATCH 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM @ 2024-09-13 17:56 Garrett Giordano 2024-09-13 17:56 ` [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano 2024-09-13 17:56 ` [PATCH 2/2] arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay Garrett Giordano 0 siblings, 2 replies; 6+ messages in thread From: Garrett Giordano @ 2024-09-13 17:56 UTC (permalink / raw) To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, w.egorov Cc: linux-arm-kernel, devicetree, linux-kernel, upstream This patch set moves our 1.4GHz opp table definition out of our overlay and into our som dtsi. This change goes along with our updated PMIC, which is now configured to output 0.85v by default. We drop the overlay as it is no longer needed. Garrett Giordano (2): arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay .../boot/dts/ti/k3-am62-phycore-som.dtsi | 11 ++++++++-- .../k3-am625-phyboard-lyra-1-4-ghz-opp.dtso | 20 ------------------- 2 files changed, 9 insertions(+), 22 deletions(-) delete mode 100644 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz 2024-09-13 17:56 [PATCH 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano @ 2024-09-13 17:56 ` Garrett Giordano 2024-09-13 18:09 ` Nishanth Menon 2024-09-13 17:56 ` [PATCH 2/2] arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay Garrett Giordano 1 sibling, 1 reply; 6+ messages in thread From: Garrett Giordano @ 2024-09-13 17:56 UTC (permalink / raw) To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, w.egorov Cc: linux-arm-kernel, devicetree, linux-kernel, upstream The am625 is capable of running at 1.4 GHz when VDD_CORE is increased from 0.75V to 0.85V. Here we add a 1.4 GHz node to the a53_opp_table and increase the VDD_CORE voltage accordingly. Signed-off-by: Garrett Giordano <ggiordano@phytec.com> --- arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi index ac8959f3d953..8acbd4facf37 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi @@ -205,6 +205,13 @@ AM62X_IOPAD(0x01f4, PIN_INPUT, 0) /* (D16) EXTINTn */ }; }; +&a53_opp_table { + opp-1400000000 { + opp-hz = /bits/ 64 <1400000000>; + opp-supported-hw = <0x01 0x0004>; + }; +}; + &mcu_m4fss { mboxes = <&mailbox0_cluster0 &mbox_m4_0>; memory-region = <&mcu_m4fss_dma_memory_region>, @@ -265,8 +272,8 @@ pmic@30 { regulators { vdd_core: buck1 { regulator-name = "VDD_CORE"; - regulator-min-microvolt = <750000>; - regulator-max-microvolt = <750000>; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <850000>; regulator-boot-on; regulator-always-on; }; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz 2024-09-13 17:56 ` [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano @ 2024-09-13 18:09 ` Nishanth Menon 2024-09-27 23:33 ` Garrett Giordano 0 siblings, 1 reply; 6+ messages in thread From: Nishanth Menon @ 2024-09-13 18:09 UTC (permalink / raw) To: Garrett Giordano Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, w.egorov, linux-arm-kernel, devicetree, linux-kernel, upstream On 10:56-20240913, Garrett Giordano wrote: > The am625 is capable of running at 1.4 GHz when VDD_CORE is increased > from 0.75V to 0.85V. Here we add a 1.4 GHz node to the a53_opp_table and > increase the VDD_CORE voltage accordingly. The entire argument in introducing the 1.4Ghz overlay seems to have been to let users have the choice. What has changed since then? Ref: commit 7a5775a3da906dab059b8de60a2b88f6016cb4b8 btw, instead of putting a patch to delete the dtso, you should probably consider a revert patch instead. > > Signed-off-by: Garrett Giordano <ggiordano@phytec.com> > --- > arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi > index ac8959f3d953..8acbd4facf37 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi > @@ -205,6 +205,13 @@ AM62X_IOPAD(0x01f4, PIN_INPUT, 0) /* (D16) EXTINTn */ > }; > }; > > +&a53_opp_table { > + opp-1400000000 { > + opp-hz = /bits/ 64 <1400000000>; > + opp-supported-hw = <0x01 0x0004>; > + }; > +}; > + > &mcu_m4fss { > mboxes = <&mailbox0_cluster0 &mbox_m4_0>; > memory-region = <&mcu_m4fss_dma_memory_region>, > @@ -265,8 +272,8 @@ pmic@30 { > regulators { > vdd_core: buck1 { > regulator-name = "VDD_CORE"; > - regulator-min-microvolt = <750000>; > - regulator-max-microvolt = <750000>; > + regulator-min-microvolt = <850000>; > + regulator-max-microvolt = <850000>; > regulator-boot-on; > regulator-always-on; > }; > -- > 2.25.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz 2024-09-13 18:09 ` Nishanth Menon @ 2024-09-27 23:33 ` Garrett Giordano 0 siblings, 0 replies; 6+ messages in thread From: Garrett Giordano @ 2024-09-27 23:33 UTC (permalink / raw) To: Nishanth Menon Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, w.egorov, linux-arm-kernel, devicetree, linux-kernel, upstream Hey Nishanth, On 9/13/24 11:09, Nishanth Menon wrote: > On 10:56-20240913, Garrett Giordano wrote: >> The am625 is capable of running at 1.4 GHz when VDD_CORE is increased >> from 0.75V to 0.85V. Here we add a 1.4 GHz node to the a53_opp_table and >> increase the VDD_CORE voltage accordingly. > The entire argument in introducing the 1.4Ghz overlay seems to have been > to let users have the choice. What has changed since then? I talked with the team and we came back with the following: - Our default PMIC configuration changed for 850000 uV / 1.4 GHz operations - All available users will receive a PCN on update with instructions towards 850000 uV / 1.4 GHz operations These changes make this overlay obsolete. > > Ref: commit 7a5775a3da906dab059b8de60a2b88f6016cb4b8 > > btw, instead of putting a patch to delete the dtso, you should > probably consider a revert patch instead. Thank you, I will send a v2 Monday reverting this patch instead. This will also address the Makefile edits. Regards, Garrett >> Signed-off-by: Garrett Giordano <ggiordano@phytec.com> >> --- >> arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi >> index ac8959f3d953..8acbd4facf37 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi >> @@ -205,6 +205,13 @@ AM62X_IOPAD(0x01f4, PIN_INPUT, 0) /* (D16) EXTINTn */ >> }; >> }; >> >> +&a53_opp_table { >> + opp-1400000000 { >> + opp-hz = /bits/ 64 <1400000000>; >> + opp-supported-hw = <0x01 0x0004>; >> + }; >> +}; >> + >> &mcu_m4fss { >> mboxes = <&mailbox0_cluster0 &mbox_m4_0>; >> memory-region = <&mcu_m4fss_dma_memory_region>, >> @@ -265,8 +272,8 @@ pmic@30 { >> regulators { >> vdd_core: buck1 { >> regulator-name = "VDD_CORE"; >> - regulator-min-microvolt = <750000>; >> - regulator-max-microvolt = <750000>; >> + regulator-min-microvolt = <850000>; >> + regulator-max-microvolt = <850000>; >> regulator-boot-on; >> regulator-always-on; >> }; >> -- >> 2.25.1 >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay 2024-09-13 17:56 [PATCH 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano 2024-09-13 17:56 ` [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano @ 2024-09-13 17:56 ` Garrett Giordano 2024-09-13 18:07 ` Nishanth Menon 1 sibling, 1 reply; 6+ messages in thread From: Garrett Giordano @ 2024-09-13 17:56 UTC (permalink / raw) To: nm, vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, w.egorov Cc: linux-arm-kernel, devicetree, linux-kernel, upstream Remove the k3-am625-phyboard-lyra-1-4-ghz-opp overlay. We now configure the a53_opp_table to include a 1.4 GHz node and set our VDD_CORE to 0.85v in the k3-am62-phycore-som.dtsi. This change is to match our PMIC which is now set to output 0.85v by default. Signed-off-by: Garrett Giordano <ggiordano@phytec.com> --- .../k3-am625-phyboard-lyra-1-4-ghz-opp.dtso | 20 ------------------- 1 file changed, 20 deletions(-) delete mode 100644 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso deleted file mode 100644 index 6ec6d57ec49c..000000000000 --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso +++ /dev/null @@ -1,20 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only OR MIT -/* - * Copyright (C) 2024 PHYTEC America LLC - * Author: Nathan Morrisson <nmorrisson@phytec.com> - */ - -/dts-v1/; -/plugin/; - -&vdd_core { - regulator-min-microvolt = <850000>; - regulator-max-microvolt = <850000>; -}; - -&a53_opp_table { - opp-1400000000 { - opp-hz = /bits/ 64 <1400000000>; - opp-supported-hw = <0x01 0x0004>; - }; -}; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay 2024-09-13 17:56 ` [PATCH 2/2] arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay Garrett Giordano @ 2024-09-13 18:07 ` Nishanth Menon 0 siblings, 0 replies; 6+ messages in thread From: Nishanth Menon @ 2024-09-13 18:07 UTC (permalink / raw) To: Garrett Giordano Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, w.egorov, linux-arm-kernel, devicetree, linux-kernel, upstream On 10:56-20240913, Garrett Giordano wrote: > Remove the k3-am625-phyboard-lyra-1-4-ghz-opp overlay. We now > configure the a53_opp_table to include a 1.4 GHz node and set our > VDD_CORE to 0.85v in the k3-am62-phycore-som.dtsi. This change is to > match our PMIC which is now set to output 0.85v by default. > > Signed-off-by: Garrett Giordano <ggiordano@phytec.com> > --- > .../k3-am625-phyboard-lyra-1-4-ghz-opp.dtso | 20 ------------------- > 1 file changed, 20 deletions(-) > delete mode 100644 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso > > diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso > deleted file mode 100644 > index 6ec6d57ec49c..000000000000 > --- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso > +++ /dev/null > @@ -1,20 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0-only OR MIT > -/* > - * Copyright (C) 2024 PHYTEC America LLC > - * Author: Nathan Morrisson <nmorrisson@phytec.com> > - */ > - > -/dts-v1/; > -/plugin/; > - > -&vdd_core { > - regulator-min-microvolt = <850000>; > - regulator-max-microvolt = <850000>; > -}; > - > -&a53_opp_table { > - opp-1400000000 { > - opp-hz = /bits/ 64 <1400000000>; > - opp-supported-hw = <0x01 0x0004>; > - }; > -}; > -- > 2.25.1 > Did you build test this? Reason I ask is because you might have missed the Makefile edits needed? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-27 23:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-13 17:56 [PATCH 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano 2024-09-13 17:56 ` [PATCH 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano 2024-09-13 18:09 ` Nishanth Menon 2024-09-27 23:33 ` Garrett Giordano 2024-09-13 17:56 ` [PATCH 2/2] arm64: dts: ti: Remove k3-am625-phyboard-lyra-1-4-ghz-opp overlay Garrett Giordano 2024-09-13 18:07 ` Nishanth Menon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).