* [PATCH v3] dt-bindings: display: mediatek: split: add subschema property constraints
@ 2024-10-04 2:24 Moudy Ho
2024-10-04 2:59 ` Moudy Ho (何宗原)
0 siblings, 1 reply; 2+ messages in thread
From: Moudy Ho @ 2024-10-04 2:24 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, jason-jh . lin, Macpaul Lin
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Moudy Ho
The display node in mt8195.dtsi was triggering a CHECK_DTBS error due
to an excessively long 'clocks' property:
display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long
To resolve this issue, the constraints for 'clocks' and
other properties within the subschemas will be reinforced.
Fixes: 739058a9c5c3 ("dt-bindings: display: mediatek: split: add compatible for MT8195")
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
--
This is based on [v2] dt-bindings: display: mediatek: split: add clocks count constraint for MT8195
Changes since v2:
- Revise the commit message.
- Enhance the descriptions of 'clocks'.
- Strengthen the conditions within the subschema.
Changes since v1:
- Adding functional descriptions and quantity restrictions.
---
.../display/mediatek/mediatek,split.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
index e4affc854f3d..0ffcd9d2b718 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
@@ -57,6 +57,9 @@ properties:
clocks:
items:
- description: SPLIT Clock
+ - description: Used for interfacing with the HDMI RX signal source.
+ - description: Paired with receiving HDMI RX metadata.
+ minItems: 1
required:
- compatible
@@ -72,9 +75,30 @@ allOf:
const: mediatek,mt8195-mdp3-split
then:
+ properties:
+ clocks:
+ maxItems: 3
+
+ power-domains:
+ maxItems: 1
+
required:
- mediatek,gce-client-reg
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt8173-mdp3-split
+
+ then:
+ properties:
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
additionalProperties: false
examples:
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] dt-bindings: display: mediatek: split: add subschema property constraints
2024-10-04 2:24 [PATCH v3] dt-bindings: display: mediatek: split: add subschema property constraints Moudy Ho
@ 2024-10-04 2:59 ` Moudy Ho (何宗原)
0 siblings, 0 replies; 2+ messages in thread
From: Moudy Ho (何宗原) @ 2024-10-04 2:59 UTC (permalink / raw)
To: chunkuang.hu@kernel.org, Jason-JH Lin (林睿祥),
tzimmermann@suse.de, simona@ffwll.ch, mripard@kernel.org,
p.zabel@pengutronix.de, maarten.lankhorst@linux.intel.com,
conor+dt@kernel.org, robh@kernel.org,
Macpaul Lin (林智斌), airlied@gmail.com,
matthias.bgg@gmail.com, krzk+dt@kernel.org,
AngeloGioacchino Del Regno
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Hi,
This patch contains an incorrect compatible name; please excuse the
oversight and discard this patch.
Sincerely,
Moudy Ho
On Fri, 2024-10-04 at 10:24 +0800, Moudy Ho wrote:
> The display node in mt8195.dtsi was triggering a CHECK_DTBS error due
> to an excessively long 'clocks' property:
> display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too
> long
>
> To resolve this issue, the constraints for 'clocks' and
> other properties within the subschemas will be reinforced.
>
> Fixes: 739058a9c5c3 ("dt-bindings: display: mediatek: split: add
> compatible for MT8195")
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
>
> --
> This is based on [v2] dt-bindings: display: mediatek: split: add
> clocks count constraint for MT8195
>
> Changes since v2:
> - Revise the commit message.
> - Enhance the descriptions of 'clocks'.
> - Strengthen the conditions within the subschema.
>
> Changes since v1:
> - Adding functional descriptions and quantity restrictions.
> ---
> .../display/mediatek/mediatek,split.yaml | 24
> +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> index e4affc854f3d..0ffcd9d2b718 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.y
> aml
> @@ -57,6 +57,9 @@ properties:
> clocks:
> items:
> - description: SPLIT Clock
> + - description: Used for interfacing with the HDMI RX signal
> source.
> + - description: Paired with receiving HDMI RX metadata.
> + minItems: 1
>
> required:
> - compatible
> @@ -72,9 +75,30 @@ allOf:
> const: mediatek,mt8195-mdp3-split
>
> then:
> + properties:
> + clocks:
> + maxItems: 3
> +
> + power-domains:
> + maxItems: 1
> +
> required:
> - mediatek,gce-client-reg
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8173-mdp3-split
> +
> + then:
> + properties:
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> additionalProperties: false
>
> examples:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-04 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-04 2:24 [PATCH v3] dt-bindings: display: mediatek: split: add subschema property constraints Moudy Ho
2024-10-04 2:59 ` Moudy Ho (何宗原)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox