[PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3

[PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3

[Uwe Kleine-König]

Using 3 cells allows to pass additional flags and is the normal
abstraction for new PWM descriptions. There are no device trees yet to
adapt to this change.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,

missed that during review of that new binding. Just noticed that now
when (internally) reviewing a machine dt using that device.

There is no need for driver adaptions, the pwm core handles both cases
just fine.

Best regards
Uwe

 Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
index ec6115d3796b..aa35209f74cf 100644
--- a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
+++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
@@ -27,7 +27,7 @@ properties:
     maxItems: 1
 
   "#pwm-cells":
-    const: 2
+    const: 3
 
   clocks:
     maxItems: 1
@@ -44,5 +44,5 @@ examples:
        compatible = "adi,axi-pwmgen-2.00.a";
        reg = <0x44b00000 0x1000>;
        clocks = <&spi_clk>;
-       #pwm-cells = <2>;
+       #pwm-cells = <3>;
     };
-- 
2.45.2

RE: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3

[Sa, Nuno]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Sent: Thursday, October 24, 2024 12:26 PM
> To: Hennerich, Michael <Michael.Hennerich@analog.com>; Sa, Nuno
> <Nuno.Sa@analog.com>; Rob Herring <robh@kernel.org>; Krzysztof
> Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>
> Cc: Trevor Gamblin <tgamblin@baylibre.com>; linux-pwm@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3
> 
> [External]
> 
> Using 3 cells allows to pass additional flags and is the normal
> abstraction for new PWM descriptions. There are no device trees yet to
> adapt to this change.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> Hello,
> 
> missed that during review of that new binding. Just noticed that now
> when (internally) reviewing a machine dt using that device.
> 
> There is no need for driver adaptions, the pwm core handles both cases
> just fine.
> 
> Best regards
> Uwe
> 
>  Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> index ec6115d3796b..aa35209f74cf 100644
> --- a/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> +++ b/Documentation/devicetree/bindings/pwm/adi,axi-pwmgen.yaml
> @@ -27,7 +27,7 @@ properties:
>      maxItems: 1
> 
>    "#pwm-cells":
> -    const: 2
> +    const: 3
> 
>    clocks:
>      maxItems: 1
> @@ -44,5 +44,5 @@ examples:
>         compatible = "adi,axi-pwmgen-2.00.a";
>         reg = <0x44b00000 0x1000>;
>         clocks = <&spi_clk>;
> -       #pwm-cells = <2>;
> +       #pwm-cells = <3>;
>      };
> --
> 2.45.2

Re: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

On Thu, Oct 24, 2024 at 12:25:54PM +0200, Uwe Kleine-König wrote:
> Using 3 cells allows to pass additional flags and is the normal
> abstraction for new PWM descriptions. There are no device trees yet to
> adapt to this change.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> missed that during review of that new binding. Just noticed that now
> when (internally) reviewing a machine dt using that device.
> 
> There is no need for driver adaptions, the pwm core handles both cases
> just fine.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3

[Trevor Gamblin]

On 2024-10-24 06:25, Uwe Kleine-König wrote:
> Using 3 cells allows to pass additional flags and is the normal
> abstraction for new PWM descriptions. There are no device trees yet to
> adapt to this change.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> missed that during review of that new binding. Just noticed that now
> when (internally) reviewing a machine dt using that device.
>
> There is no need for driver adaptions, the pwm core handles both cases
> just fine.
>
> Best regards
> Uwe
Reviewed-by: Trevor Gamblin <tgamblin@baylibre.com>

Re: [PATCH] dt-bindings: pwm: adi,axi-pwmgen: Increase #pwm-cells to 3

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hello,

On Thu, Oct 24, 2024 at 12:25:54PM +0200, Uwe Kleine-König wrote:
> Using 3 cells allows to pass additional flags and is the normal
> abstraction for new PWM descriptions. There are no device trees yet to
> adapt to this change.

With so much feedback I applied the patch already to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
with the tags for Nuno, Conor and Trevor.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]