Devicetree
 help / color / mirror / Atom feed
* [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings
       [not found] ` <20241103163908.11890-1-wenliang202407@163.com>
@ 2024-11-03 16:39   ` Wenliang
  2024-11-03 16:46     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Wenliang @ 2024-11-03 16:39 UTC (permalink / raw)
  To: linux
  Cc: book, jdelvare, linux-hwmon, robh, krzk+dt, conor+dt, devicetree,
	linux-kernel, Conor Dooley

From: book <book@100ask.localdomain>

SY24655 is similar to INA226. Its supply voltage and pin definitions
are therefore the same. Compared to INA226, SY24655 has two additional
registers for configuring and calculating average power.

Signed-off-by: book <book@100ask.localdomain>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 6ae961732e6b..05a9cb36cd82 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -20,6 +20,7 @@ description: |
 properties:
   compatible:
     enum:
+      - silergy,sy24655
       - ti,ina209
       - ti,ina219
       - ti,ina220
-- 
2.47.0.229.g8f8d6eee53


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings
  2024-11-03 16:39   ` [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings Wenliang
@ 2024-11-03 16:46     ` Krzysztof Kozlowski
  2024-11-03 16:52       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-03 16:46 UTC (permalink / raw)
  To: Wenliang, linux
  Cc: book, jdelvare, linux-hwmon, robh, krzk+dt, conor+dt, devicetree,
	linux-kernel, Conor Dooley

On 03/11/2024 17:39, Wenliang wrote:
> From: book <book@100ask.localdomain>
> 
> SY24655 is similar to INA226. Its supply voltage and pin definitions
> are therefore the same. Compared to INA226, SY24655 has two additional
> registers for configuring and calculating average power.
> 
> Signed-off-by: book <book@100ask.localdomain>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

NAK, this never happened. If you think otherwise: provide proof, please.

Nothing improved in this binding, actually it got even worse with fake
email and probably name as well.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings
  2024-11-03 16:46     ` Krzysztof Kozlowski
@ 2024-11-03 16:52       ` Krzysztof Kozlowski
  2024-11-03 22:39         ` Conor Dooley
  0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-03 16:52 UTC (permalink / raw)
  To: Wenliang, linux
  Cc: book, jdelvare, linux-hwmon, robh, krzk+dt, conor+dt, devicetree,
	linux-kernel, Conor Dooley

On 03/11/2024 17:46, Krzysztof Kozlowski wrote:
> On 03/11/2024 17:39, Wenliang wrote:
>> From: book <book@100ask.localdomain>
>>
>> SY24655 is similar to INA226. Its supply voltage and pin definitions
>> are therefore the same. Compared to INA226, SY24655 has two additional
>> registers for configuring and calculating average power.
>>
>> Signed-off-by: book <book@100ask.localdomain>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> NAK, this never happened. If you think otherwise: provide proof, please.

Hm, now I found previous v3, so ack happened, but patch still has
incorrect author.

Please really carefully read submitting patches document, especially
parts about sending new versions, changelogs, subjects.


> 
> Nothing improved in this binding, actually it got even worse with fake
> email and probably name as well.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings
  2024-11-03 16:52       ` Krzysztof Kozlowski
@ 2024-11-03 22:39         ` Conor Dooley
  0 siblings, 0 replies; 4+ messages in thread
From: Conor Dooley @ 2024-11-03 22:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Wenliang, linux, book, jdelvare, linux-hwmon, robh, krzk+dt,
	conor+dt, devicetree, linux-kernel, Conor Dooley

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sun, Nov 03, 2024 at 05:52:59PM +0100, Krzysztof Kozlowski wrote:
> On 03/11/2024 17:46, Krzysztof Kozlowski wrote:
> > On 03/11/2024 17:39, Wenliang wrote:
> >> From: book <book@100ask.localdomain>
> >>
> >> SY24655 is similar to INA226. Its supply voltage and pin definitions
> >> are therefore the same. Compared to INA226, SY24655 has two additional
> >> registers for configuring and calculating average power.
> >>
> >> Signed-off-by: book <book@100ask.localdomain>
> >> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > NAK, this never happened. If you think otherwise: provide proof, please.
> 
> Hm, now I found previous v3, so ack happened, but patch still has
> incorrect author.

I didn't ack it with this weird authorship, so that needs to be fixed
before the ack can be applied.

> 
> Please really carefully read submitting patches document, especially
> parts about sending new versions, changelogs, subjects.
> 
> 
> > 
> > Nothing improved in this binding, actually it got even worse with fake
> > email and probably name as well.
> 
> 
> Best regards,
> Krzysztof
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-11-03 22:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <706d4821-2637-4aac-869b-822f69aebbfa@roeck-us.net>
     [not found] ` <20241103163908.11890-1-wenliang202407@163.com>
2024-11-03 16:39   ` [PATCH linux dev-6.11 v3 2/2] dt-bindings: Add SY24655 to ina2xx devicetree bindings Wenliang
2024-11-03 16:46     ` Krzysztof Kozlowski
2024-11-03 16:52       ` Krzysztof Kozlowski
2024-11-03 22:39         ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox