From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh@kernel.org>, <conor+dt@kernel.org>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adf4371: add differential ref
Date: Sun, 15 Dec 2024 12:35:12 +0000 [thread overview]
Message-ID: <20241215123512.1d2bbb3d@jic23-huawei> (raw)
In-Reply-To: <20241209104201.25205-1-antoniu.miclaus@analog.com>
On Mon, 9 Dec 2024 12:41:31 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add support for enabling differential input reference.
>
> By default the single-ended input is enabled.
>
> Input frequency boundaries are change based on the mode selected
> (single-ended/differential).
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> changes in v2:
> - improve commit body.
It still has the same question I raised on v1. Why is this not
selecting between what I think is two different clocks given they
are wired to either one pin or two.
refin, refin-diff
Please add a cover letter to all series of more than 1 patch as it
gives a place for general explanations and discussion.
Thanks,
Jonathan
> Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> index 1cb2adaf66f9..dd9a592d0026 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> @@ -40,6 +40,11 @@ properties:
> output stage will shut down until the ADF4371/ADF4372 achieves lock as
> measured by the digital lock detect circuitry.
>
> + adi,ref-differential-enable:
> + type: boolean
> + description:
> + If this property is present, differential input reference is enabled.
> +
> required:
> - compatible
> - reg
prev parent reply other threads:[~2024-12-15 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 10:41 [PATCH v2 1/3] dt-bindings: iio: adf4371: add differential ref Antoniu Miclaus
2024-12-09 10:41 ` [PATCH v2 2/3] iio: frequency: " Antoniu Miclaus
2024-12-09 10:41 ` [PATCH v2 3/3] iio: frequency: adf4371: add ref doubler Antoniu Miclaus
2024-12-19 11:28 ` Dan Carpenter
2024-12-15 12:35 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241215123512.1d2bbb3d@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox