From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: ahaslam@baylibre.com, krzk+dt@kernel.org, dlechner@baylibre.com,
Michael.Hennerich@analog.com, robh@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low
Date: Sun, 15 Dec 2024 13:03:13 +0000 [thread overview]
Message-ID: <20241215130313.781aebb7@jic23-huawei> (raw)
In-Reply-To: <20241106-tableful-outdoors-298ad815a107@spud>
On Wed, 6 Nov 2024 15:47:01 +0000
Conor Dooley <conor@kernel.org> wrote:
> On Wed, Nov 06, 2024 at 11:38:24AM +0100, ahaslam@baylibre.com wrote:
> > From: Axel Haslam <ahaslam@baylibre.com>
> >
> > On the example, the ldac gpio is flagged as active high, when in reality
> > its an active low gpio. Fix the example by using the active low flag for
> > the ldac gpio.
> >
> > Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> > Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied thanks. I'd dropped the ball on this one, so only noticed when reviewing
the older stuff in patchwork for dependencies that had resolved.
Jonathan
next prev parent reply other threads:[~2024-12-15 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 10:38 [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low ahaslam
2024-11-06 15:47 ` Conor Dooley
2024-12-15 13:03 ` Jonathan Cameron [this message]
2024-12-14 20:24 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241215130313.781aebb7@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=ahaslam@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox