From: David Lechner <dlechner@baylibre.com>
To: ahaslam@baylibre.com, jic23@kernel.org
Cc: Michael.Hennerich@analog.com, robh@kernel.org,
conor+dt@kernel.org, krzk+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low
Date: Sat, 14 Dec 2024 14:24:05 -0600 [thread overview]
Message-ID: <ebd71e3d-1902-402b-a84e-819b0976ba4b@baylibre.com> (raw)
In-Reply-To: <20241106103824.579292-1-ahaslam@baylibre.com>
On 11/6/24 4:38 AM, ahaslam@baylibre.com wrote:
> From: Axel Haslam <ahaslam@baylibre.com>
>
> On the example, the ldac gpio is flagged as active high, when in reality
> its an active low gpio. Fix the example by using the active low flag for
> the ldac gpio.
>
> Fixes: baaa92d284d5 ("dt-bindings: iio: dac: ad5791: Add optional reset, clr and ldac gpios")
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---
> Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> index 79cb4b78a88a..2bd89e0aa46b 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> @@ -91,7 +91,7 @@ examples:
> vrefn-supply = <&dac_vrefn>;
> reset-gpios = <&gpio_bd 16 GPIO_ACTIVE_LOW>;
> clear-gpios = <&gpio_bd 17 GPIO_ACTIVE_LOW>;
> - ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_HIGH>;
> + ldac-gpios = <&gpio_bd 18 GPIO_ACTIVE_LOW>;
> };
> };
> ...
Hi Jonathan, any reason this one didn't get picked up yet?
prev parent reply other threads:[~2024-12-14 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 10:38 [PATCH] dt-bindings: iio: dac: ad5791: ldac gpio is active low ahaslam
2024-11-06 15:47 ` Conor Dooley
2024-12-15 13:03 ` Jonathan Cameron
2024-12-14 20:24 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebd71e3d-1902-402b-a84e-819b0976ba4b@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=ahaslam@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox