From: Conor Dooley <conor@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: remove post-init-providers property
Date: Tue, 17 Dec 2024 18:30:11 +0000 [thread overview]
Message-ID: <20241217-armless-unstable-7165d81cb35d@spud> (raw)
In-Reply-To: <877c7zno1n.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]
On Tue, Dec 17, 2024 at 12:36:21AM +0000, Kuninori Morimoto wrote:
> commit f8da001ae7a ("ASoC: audio-graph-card2: Purge absent supplies for
> device tree nodes") marks multi/dpcm/c2c nodes as no suppliers. We no
> longer need to use post-init-providers property to break fw_devlink cycle
> (And no one is using it yet). Let's remove it.
>
> Fixes: a2187d0dadf ("ASoC: dt-bindings: renesas,rsnd: add post-init-providers property")
I'm not sure that this fixes tag is appropriate. I don't think this is a
fix for the cited commit, it is just now not required. If this were to
get backported, wouldn't stable be broken since the supply purging
commit doesn't appear to have a Fixes: tag or a CC: stable?
Thanks,
Conor.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> - add missing DT maintainers
> - Tidyup the git-log
>
> Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 6d0d1514cd421..e8a2acb926460 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -112,12 +112,6 @@ properties:
> description: List of necessary clock names.
> # details are defined below
>
> - post-init-providers:
> - description: At least if rsnd is using DPCM connection on Audio-Graph-Card2,
> - fw_devlink might doesn't have enough information to break the cycle. rsnd
> - driver will not be probed in such case. Same problem might occur with
> - Multi-CPU/Codec or Codec2Codec.
> -
> # ports is below
> port:
> $ref: audio-graph-port.yaml#/definitions/port-base
> --
> 2.43.0
>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-12-17 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 0:36 [PATCH v2] ASoC: dt-bindings: renesas,rsnd: remove post-init-providers property Kuninori Morimoto
2024-12-17 5:53 ` Krzysztof Kozlowski
2024-12-17 18:30 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217-armless-unstable-7165d81cb35d@spud \
--to=conor@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox