[PATCH v2] ASoC: dt-bindings: renesas,rsnd: remove post-init-providers property

[PATCH v2] ASoC: dt-bindings: renesas,rsnd: remove post-init-providers property

[Kuninori Morimoto]

commit f8da001ae7a ("ASoC: audio-graph-card2: Purge absent supplies for
device tree nodes") marks multi/dpcm/c2c nodes as no suppliers. We no
longer need to use post-init-providers property to break fw_devlink cycle
(And no one is using it yet). Let's remove it.

Fixes: a2187d0dadf ("ASoC: dt-bindings: renesas,rsnd: add post-init-providers property")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
	- add missing DT maintainers
	- Tidyup the git-log

 Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
index 6d0d1514cd421..e8a2acb926460 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
@@ -112,12 +112,6 @@ properties:
     description: List of necessary clock names.
     # details are defined below
 
-  post-init-providers:
-    description: At least if rsnd is using DPCM connection on Audio-Graph-Card2,
-      fw_devlink might doesn't have enough information to break the cycle. rsnd
-      driver will not be probed in such case. Same problem might occur with
-      Multi-CPU/Codec or Codec2Codec.
-
   # ports is below
   port:
     $ref: audio-graph-port.yaml#/definitions/port-base
-- 
2.43.0

Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: remove post-init-providers property

[Krzysztof Kozlowski]

On 17/12/2024 01:36, Kuninori Morimoto wrote:
> commit f8da001ae7a ("ASoC: audio-graph-card2: Purge absent supplies for
> device tree nodes") marks multi/dpcm/c2c nodes as no suppliers. We no
> longer need to use post-init-providers property to break fw_devlink cycle
> (And no one is using it yet). Let's remove it.
> 
> Fixes: a2187d0dadf ("ASoC: dt-bindings: renesas,rsnd: add post-init-providers property")
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> 	- add missing DT maintainers
Only some of them? And some old addresses? You CC-ed an address, which
suggests you do not work on mainline kernel or you do not use
get_maintainers.pl/b4/patman. Please rebase and always work on mainline
or start using mentioned tools, so correct addresses will be used.


Best regards,
Krzysztof

Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: remove post-init-providers property

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]

On Tue, Dec 17, 2024 at 12:36:21AM +0000, Kuninori Morimoto wrote:
> commit f8da001ae7a ("ASoC: audio-graph-card2: Purge absent supplies for
> device tree nodes") marks multi/dpcm/c2c nodes as no suppliers. We no
> longer need to use post-init-providers property to break fw_devlink cycle
> (And no one is using it yet). Let's remove it.
> 
> Fixes: a2187d0dadf ("ASoC: dt-bindings: renesas,rsnd: add post-init-providers property")

I'm not sure that this fixes tag is appropriate. I don't think this is a
fix for the cited commit, it is just now not required. If this were to
get backported, wouldn't stable be broken since the supply purging
commit doesn't appear to have a Fixes: tag or a CC: stable?

Thanks,
Conor.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> 	- add missing DT maintainers
> 	- Tidyup the git-log
> 
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 6d0d1514cd421..e8a2acb926460 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -112,12 +112,6 @@ properties:
>      description: List of necessary clock names.
>      # details are defined below
>  
> -  post-init-providers:
> -    description: At least if rsnd is using DPCM connection on Audio-Graph-Card2,
> -      fw_devlink might doesn't have enough information to break the cycle. rsnd
> -      driver will not be probed in such case. Same problem might occur with
> -      Multi-CPU/Codec or Codec2Codec.
> -
>    # ports is below
>    port:
>      $ref: audio-graph-port.yaml#/definitions/port-base
> -- 
> 2.43.0
> 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]