* [PATCH v2 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings
[not found] <20250113035023.365697-1-wenliang202407@163.com>
@ 2025-01-13 3:50 ` Wenliang Yan
2025-01-13 17:12 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Wenliang Yan @ 2025-01-13 3:50 UTC (permalink / raw)
To: linux, Jean Delvare, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Wenliang Yan, Jonathan Corbet, linux-hwmon, devicetree,
linux-kernel
Add the sq52206 compatible to the ina2xx.yaml
Signed-off-by: Wenliang Yan <wenliang202407@163.com>
---
The new features added to sq52206 compared to ina238 do not
affect the differences in hardware properties.The properties
described in the ina2xx.yaml are applicable to the sq52206.
Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 05a9cb36cd82..f0b7758ab29f 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -20,6 +20,7 @@ description: |
properties:
compatible:
enum:
+ - silergy,sq52206
- silergy,sy24655
- ti,ina209
- ti,ina219
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings
2025-01-13 3:50 ` [PATCH v2 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings Wenliang Yan
@ 2025-01-13 17:12 ` Conor Dooley
2025-01-14 7:43 ` [PATCH v2 2/2] hwmon:(ina238)Add support for SQ52206 Wenliang Yan
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2025-01-13 17:12 UTC (permalink / raw)
To: Wenliang Yan
Cc: linux, Jean Delvare, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jonathan Corbet, linux-hwmon, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Mon, Jan 13, 2025 at 11:50:22AM +0800, Wenliang Yan wrote:
> Add the sq52206 compatible to the ina2xx.yaml
>
> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
> ---
>
> The new features added to sq52206 compared to ina238 do not
> affect the differences in hardware properties.The properties
> described in the ina2xx.yaml are applicable to the sq52206.
This blurb is a bit confusing, as it makes it seem like the devices are
compatible. The driver patch, however, suggests otherwise. Please
mention in your commit message what differs between the new device
you're adding and existing ones.
>
> Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> index 05a9cb36cd82..f0b7758ab29f 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -20,6 +20,7 @@ description: |
> properties:
> compatible:
> enum:
> + - silergy,sq52206
> - silergy,sy24655
> - ti,ina209
> - ti,ina219
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] hwmon:(ina238)Add support for SQ52206
2025-01-13 17:12 ` Conor Dooley
@ 2025-01-14 7:43 ` Wenliang Yan
0 siblings, 0 replies; 3+ messages in thread
From: Wenliang Yan @ 2025-01-14 7:43 UTC (permalink / raw)
To: conor
Cc: conor+dt, corbet, devicetree, jdelvare, krzk+dt, linux-hwmon,
linux-kernel, linux, robh, wenliang202407
At 2025-01-14 01:12:32, "Conor Dooley" <conor@kernel.org> wrote:
>On Mon, Jan 13, 2025 at 11:50:22AM +0800, Wenliang Yan wrote:
>> Add the sq52206 compatible to the ina2xx.yaml
>>
>> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
>> ---
>>
>> The new features added to sq52206 compared to ina238 do not
>> affect the differences in hardware properties.The properties
>> described in the ina2xx.yaml are applicable to the sq52206.
>
>This blurb is a bit confusing, as it makes it seem like the devices are
>compatible. The driver patch, however, suggests otherwise. Please
>mention in your commit message what differs between the new device
>you're adding and existing ones.
>
Sorry for not mentioning their differences.
sq52206 has a difference, the shunt gain value 1 is mapped to
ADCRANGE=10/11, the value 2 is mapped to ADCRANGE=01, and the value 2 is
mapped to ADCRANGE=00.
>>
>> Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> index 05a9cb36cd82..f0b7758ab29f 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> @@ -20,6 +20,7 @@ description: |
>> properties:
>> compatible:
>> enum:
>> + - silergy,sq52206
>> - silergy,sy24655
>> - ti,ina209
>> - ti,ina219
>> --
>> 2.43.0
>>
Thanks,
Wenliang Yan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-14 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250113035023.365697-1-wenliang202407@163.com>
2025-01-13 3:50 ` [PATCH v2 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings Wenliang Yan
2025-01-13 17:12 ` Conor Dooley
2025-01-14 7:43 ` [PATCH v2 2/2] hwmon:(ina238)Add support for SQ52206 Wenliang Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox