[PATCH 2/3] dt-bindings: iio: chemical: sensirion,senxx: Add yaml description

[PATCH 2/3] dt-bindings: iio: chemical: sensirion,senxx: Add yaml description

[Hermes Zhang]

Add documentation for the SEN5x/SEN6x environmental sensor from Sensirion.

Signed-off-by: Hermes Zhang <Hermes.Zhang@axis.com>
---
 .../iio/chemical/sensirion,senxx.yaml         | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml

diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
new file mode 100644
index 000000000000..4d998eabe441
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/chemical/sensirion,senxx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sensirion SEN5x/SEN6x environmental sensor
+
+maintainers:
+  - Hermes Zhang <chenhuiz@axis.com>
+
+description: |
+  The SEN5x/SEN6x is a sensor module family combining the measurement of air
+  quality parameters: particulate matter, VOC, NOx, humidity, and temperature.
+
+  Datasheet:
+  https://sensirion.com/media/documents/6791EFA0/62A1F68F/Sensirion_Datasheet_Environmental_Node_SEN5x.pdf
+  https://sensirion.com/media/documents/FAFC548D/6731FFFA/Sensirion_Datasheet_SEN6x.pdf
+
+properties:
+  compatible:
+    enum:
+      - sensirion,sen50
+      - sensirion,sen54
+      - sensirion,sen55
+      - sensirion,sen60
+      - sensirion,sen65
+      - sensirion,sen66
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      sen55@69 {
+        compatible = "sensirion,sen55";
+        reg = <0x69>;
+      };
+    };
-- 
2.45.2

Re: [PATCH 2/3] dt-bindings: iio: chemical: sensirion,senxx: Add yaml description

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2305 bytes --]

On Thu, Feb 06, 2025 at 02:15:16PM +0800, Hermes Zhang wrote:
> Add documentation for the SEN5x/SEN6x environmental sensor from Sensirion.
> 
> Signed-off-by: Hermes Zhang <Hermes.Zhang@axis.com>
> ---
>  .../iio/chemical/sensirion,senxx.yaml         | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
> new file mode 100644
> index 000000000000..4d998eabe441
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml

filename matching a compatible please.

> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sensirion,senxx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SEN5x/SEN6x environmental sensor
> +
> +maintainers:
> +  - Hermes Zhang <chenhuiz@axis.com>
> +
> +description: |
> +  The SEN5x/SEN6x is a sensor module family combining the measurement of air
> +  quality parameters: particulate matter, VOC, NOx, humidity, and temperature.
> +
> +  Datasheet:
> +  https://sensirion.com/media/documents/6791EFA0/62A1F68F/Sensirion_Datasheet_Environmental_Node_SEN5x.pdf
> +  https://sensirion.com/media/documents/FAFC548D/6731FFFA/Sensirion_Datasheet_SEN6x.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sen50
> +      - sensirion,sen54
> +      - sensirion,sen55
> +      - sensirion,sen60
> +      - sensirion,sen65
> +      - sensirion,sen66

I'd like a note in the commit message as to how all of these devices are
different please.

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg

No supplies needed for this device? Seems like you would need at least
one, no?

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      sen55@69 {
> +        compatible = "sensirion,sen55";
> +        reg = <0x69>;
> +      };
> +    };
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/3] dt-bindings: iio: chemical: sensirion,senxx: Add yaml description

[Hermes Zhang]

Hi,

On 2025/2/7 2:20, Conor Dooley wrote:
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
> new file mode 100644
> index 000000000000..4d998eabe441
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
> filename matching a compatible please.
So sensirion,sen66.yaml?
> +  https://sensirion.com/media/documents/6791EFA0/62A1F68F/Sensirion_Datasheet_Environmental_Node_SEN5x.pdf
> +  https://sensirion.com/media/documents/FAFC548D/6731FFFA/Sensirion_Datasheet_SEN6x.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sen50
> +      - sensirion,sen54
> +      - sensirion,sen55
> +      - sensirion,sen60
> +      - sensirion,sen65
> +      - sensirion,sen66
> I'd like a note in the commit message as to how all of these devices are
> different please.
Sure, will fix in v2.
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
> No supplies needed for this device? Seems like you would need at least
> one, no?

You mean the vdd-supply? The chip require a e.g. 3.3v VDD, but in our 
HW, we have no gpio/regulator to control it, connect directly by the HW, 
should I still need to have one vdd-supply here?


Best Regards,

Hermes

Re: [PATCH 2/3] dt-bindings: iio: chemical: sensirion,senxx: Add yaml description

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On Sat, Feb 08, 2025 at 03:07:08PM +0800, Hermes Zhang wrote:
> Hi,
> 
> On 2025/2/7 2:20, Conor Dooley wrote:
> > diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
> > new file mode 100644
> > index 000000000000..4d998eabe441
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
> > filename matching a compatible please.
> So sensirion,sen66.yaml?
> > +  https://sensirion.com/media/documents/6791EFA0/62A1F68F/Sensirion_Datasheet_Environmental_Node_SEN5x.pdf
> > +  https://sensirion.com/media/documents/FAFC548D/6731FFFA/Sensirion_Datasheet_SEN6x.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - sensirion,sen50
> > +      - sensirion,sen54
> > +      - sensirion,sen55
> > +      - sensirion,sen60
> > +      - sensirion,sen65
> > +      - sensirion,sen66
> > I'd like a note in the commit message as to how all of these devices are
> > different please.
> Sure, will fix in v2.
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > No supplies needed for this device? Seems like you would need at least
> > one, no?
> 
> You mean the vdd-supply? The chip require a e.g. 3.3v VDD, but in our HW, we
> have no gpio/regulator to control it, connect directly by the HW, should I
> still need to have one vdd-supply here?

Might not be controllable in your case, but if the device needs power
from somewhere it should have one in the binding.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/3] dt-bindings: iio: chemical: sensirion,senxx: Add yaml description

[Hermes Zhang]

On 2025/2/12 2:44, Conor Dooley wrote:
> On Sat, Feb 08, 2025 at 03:07:08PM +0800, Hermes Zhang wrote:
>> Hi,
>>
>> On 2025/2/7 2:20, Conor Dooley wrote:
>>> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
>>> new file mode 100644
>>> index 000000000000..4d998eabe441
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,senxx.yaml
>>> filename matching a compatible please.
>> So sensirion,sen66.yaml?
>>> +  https://sensirion.com/media/documents/6791EFA0/62A1F68F/Sensirion_Datasheet_Environmental_Node_SEN5x.pdf
>>> +  https://sensirion.com/media/documents/FAFC548D/6731FFFA/Sensirion_Datasheet_SEN6x.pdf
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - sensirion,sen50
>>> +      - sensirion,sen54
>>> +      - sensirion,sen55
>>> +      - sensirion,sen60
>>> +      - sensirion,sen65
>>> +      - sensirion,sen66
>>> I'd like a note in the commit message as to how all of these devices are
>>> different please.
>> Sure, will fix in v2.
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>> +
>>>> +required:
>>>> +  - compatible
>>>> +  - reg
>>> No supplies needed for this device? Seems like you would need at least
>>> one, no?
>> You mean the vdd-supply? The chip require a e.g. 3.3v VDD, but in our HW, we
>> have no gpio/regulator to control it, connect directly by the HW, should I
>> still need to have one vdd-supply here?
> Might not be controllable in your case, but if the device needs power
> from somewhere it should have one in the binding.

OK, I see. I will add it in v2. Thanks.


Best Regards,

Hermes