* [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix
@ 2025-02-27 12:57 Maud Spierings via B4 Relay
2025-02-27 12:57 ` [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig Maud Spierings via B4 Relay
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Maud Spierings via B4 Relay @ 2025-02-27 12:57 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, Joseph McNally
Cc: linux-hwmon, linux-kernel, devicetree, Maud Spierings
Fix some small mistakes in the Kconfig and bindings yaml, also fix the
incorrect sensor table for the ncpXXxh103 sensor.
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
Maud Spierings (3):
hwmon: (ntc_thermistor) Fix module name in the Kconfig
dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles
hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table
.../devicetree/bindings/hwmon/ntc-thermistor.yaml | 2 +-
drivers/hwmon/Kconfig | 2 +-
drivers/hwmon/ntc_thermistor.c | 66 +++++++++++-----------
3 files changed, 35 insertions(+), 35 deletions(-)
---
base-commit: be5c7bbb3a64baf884481a1ba0c2f8fb2f93f7c3
change-id: 20250227-ntc_thermistor_fixes-6043c862956a
Best regards,
--
Maud Spierings <maudspierings@gocontroll.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig
2025-02-27 12:57 [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Maud Spierings via B4 Relay
@ 2025-02-27 12:57 ` Maud Spierings via B4 Relay
2025-03-02 16:32 ` Guenter Roeck
2025-02-27 12:57 ` [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles Maud Spierings via B4 Relay
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Maud Spierings via B4 Relay @ 2025-02-27 12:57 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, Joseph McNally
Cc: linux-hwmon, linux-kernel, devicetree, Maud Spierings
From: Maud Spierings <maudspierings@gocontroll.com>
The module name is incorrectly stated with a hyphen while it is an
underscore.
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
drivers/hwmon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index f114d0c55d7831fc5d914d19a6e543cb2dbb5659..56494ab85b83b1c10a7dbf3085abea2900e9aaa1 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1625,7 +1625,7 @@ config SENSORS_NTC_THERMISTOR
B57891S0103 from EPCOS.
This driver can also be built as a module. If so, the module
- will be called ntc-thermistor.
+ will be called ntc_thermistor.
config SENSORS_NCT6683
tristate "Nuvoton NCT6683D"
--
2.48.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles
2025-02-27 12:57 [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Maud Spierings via B4 Relay
2025-02-27 12:57 ` [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig Maud Spierings via B4 Relay
@ 2025-02-27 12:57 ` Maud Spierings via B4 Relay
2025-02-28 19:01 ` Conor Dooley
2025-03-02 16:33 ` Guenter Roeck
2025-02-27 12:57 ` [PATCH 3/3] hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table Maud Spierings via B4 Relay
2025-02-28 8:28 ` [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Linus Walleij
3 siblings, 2 replies; 9+ messages in thread
From: Maud Spierings via B4 Relay @ 2025-02-27 12:57 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, Joseph McNally
Cc: linux-hwmon, linux-kernel, devicetree, Maud Spierings
From: Maud Spierings <maudspierings@gocontroll.com>
Fix the comment stating that the "ntp," compatible strings are deprecated
which should be "ntc,"
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
index 3d0146e20d3e10747c3049911b9419e9ccdab83d..b8e500e6cd9f861fbbabd79a14d882341dbb387c 100644
--- a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
@@ -76,7 +76,7 @@ properties:
- const: murata,ncp03wf104
- const: murata,ncp15xh103
- const: samsung,1404-001221
- # Deprecated "ntp," compatible strings
+ # Deprecated "ntc," compatible strings
- const: ntc,ncp15wb473
deprecated: true
- const: ntc,ncp18wb473
--
2.48.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table
2025-02-27 12:57 [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Maud Spierings via B4 Relay
2025-02-27 12:57 ` [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig Maud Spierings via B4 Relay
2025-02-27 12:57 ` [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles Maud Spierings via B4 Relay
@ 2025-02-27 12:57 ` Maud Spierings via B4 Relay
2025-03-02 16:35 ` Guenter Roeck
2025-02-28 8:28 ` [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Linus Walleij
3 siblings, 1 reply; 9+ messages in thread
From: Maud Spierings via B4 Relay @ 2025-02-27 12:57 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, Joseph McNally
Cc: linux-hwmon, linux-kernel, devicetree, Maud Spierings
From: Maud Spierings <maudspierings@gocontroll.com>
I could not find a single table that has the values currently present in
the table, change it to the actual values that can be found in [1]/[2]
and [3] (page 15 column 2)
[1]: https://www.murata.com/products/productdetail?partno=NCP15XH103F03RC
[2]: https://www.murata.com/products/productdata/8796836626462/NTHCG83.txt?1437969843000
[3]: https://nl.mouser.com/datasheet/2/281/r44e-522712.pdf
Fixes: 54ce3a0d8011 ("hwmon: (ntc_thermistor) Add support for ncpXXxh103")
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
drivers/hwmon/ntc_thermistor.c | 66 +++++++++++++++++++++---------------------
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index b5352900463fb9b4fc68605a73feb8875961f554..0d29c8f97ba7c2f264588b6309b91ca494012ad6 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -181,40 +181,40 @@ static const struct ntc_compensation ncpXXwf104[] = {
};
static const struct ntc_compensation ncpXXxh103[] = {
- { .temp_c = -40, .ohm = 247565 },
- { .temp_c = -35, .ohm = 181742 },
- { .temp_c = -30, .ohm = 135128 },
- { .temp_c = -25, .ohm = 101678 },
- { .temp_c = -20, .ohm = 77373 },
- { .temp_c = -15, .ohm = 59504 },
- { .temp_c = -10, .ohm = 46222 },
- { .temp_c = -5, .ohm = 36244 },
- { .temp_c = 0, .ohm = 28674 },
- { .temp_c = 5, .ohm = 22878 },
- { .temp_c = 10, .ohm = 18399 },
- { .temp_c = 15, .ohm = 14910 },
- { .temp_c = 20, .ohm = 12169 },
+ { .temp_c = -40, .ohm = 195652 },
+ { .temp_c = -35, .ohm = 148171 },
+ { .temp_c = -30, .ohm = 113347 },
+ { .temp_c = -25, .ohm = 87559 },
+ { .temp_c = -20, .ohm = 68237 },
+ { .temp_c = -15, .ohm = 53650 },
+ { .temp_c = -10, .ohm = 42506 },
+ { .temp_c = -5, .ohm = 33892 },
+ { .temp_c = 0, .ohm = 27219 },
+ { .temp_c = 5, .ohm = 22021 },
+ { .temp_c = 10, .ohm = 17926 },
+ { .temp_c = 15, .ohm = 14674 },
+ { .temp_c = 20, .ohm = 12081 },
{ .temp_c = 25, .ohm = 10000 },
- { .temp_c = 30, .ohm = 8271 },
- { .temp_c = 35, .ohm = 6883 },
- { .temp_c = 40, .ohm = 5762 },
- { .temp_c = 45, .ohm = 4851 },
- { .temp_c = 50, .ohm = 4105 },
- { .temp_c = 55, .ohm = 3492 },
- { .temp_c = 60, .ohm = 2985 },
- { .temp_c = 65, .ohm = 2563 },
- { .temp_c = 70, .ohm = 2211 },
- { .temp_c = 75, .ohm = 1915 },
- { .temp_c = 80, .ohm = 1666 },
- { .temp_c = 85, .ohm = 1454 },
- { .temp_c = 90, .ohm = 1275 },
- { .temp_c = 95, .ohm = 1121 },
- { .temp_c = 100, .ohm = 990 },
- { .temp_c = 105, .ohm = 876 },
- { .temp_c = 110, .ohm = 779 },
- { .temp_c = 115, .ohm = 694 },
- { .temp_c = 120, .ohm = 620 },
- { .temp_c = 125, .ohm = 556 },
+ { .temp_c = 30, .ohm = 8315 },
+ { .temp_c = 35, .ohm = 6948 },
+ { .temp_c = 40, .ohm = 5834 },
+ { .temp_c = 45, .ohm = 4917 },
+ { .temp_c = 50, .ohm = 4161 },
+ { .temp_c = 55, .ohm = 3535 },
+ { .temp_c = 60, .ohm = 3014 },
+ { .temp_c = 65, .ohm = 2586 },
+ { .temp_c = 70, .ohm = 2228 },
+ { .temp_c = 75, .ohm = 1925 },
+ { .temp_c = 80, .ohm = 1669 },
+ { .temp_c = 85, .ohm = 1452 },
+ { .temp_c = 90, .ohm = 1268 },
+ { .temp_c = 95, .ohm = 1110 },
+ { .temp_c = 100, .ohm = 974 },
+ { .temp_c = 105, .ohm = 858 },
+ { .temp_c = 110, .ohm = 758 },
+ { .temp_c = 115, .ohm = 672 },
+ { .temp_c = 120, .ohm = 596 },
+ { .temp_c = 125, .ohm = 531 },
};
/*
--
2.48.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix
2025-02-27 12:57 [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Maud Spierings via B4 Relay
` (2 preceding siblings ...)
2025-02-27 12:57 ` [PATCH 3/3] hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table Maud Spierings via B4 Relay
@ 2025-02-28 8:28 ` Linus Walleij
3 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2025-02-28 8:28 UTC (permalink / raw)
To: maudspierings
Cc: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Joseph McNally, linux-hwmon, linux-kernel,
devicetree
On Thu, Feb 27, 2025 at 1:57 PM Maud Spierings via B4 Relay
<devnull+maudspierings.gocontroll.com@kernel.org> wrote:
> Fix some small mistakes in the Kconfig and bindings yaml, also fix the
> incorrect sensor table for the ncpXXxh103 sensor.
>
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
The series:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles
2025-02-27 12:57 ` [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles Maud Spierings via B4 Relay
@ 2025-02-28 19:01 ` Conor Dooley
2025-03-02 16:33 ` Guenter Roeck
1 sibling, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2025-02-28 19:01 UTC (permalink / raw)
To: maudspierings
Cc: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Linus Walleij, Joseph McNally, linux-hwmon,
linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On Thu, Feb 27, 2025 at 01:57:52PM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
>
> Fix the comment stating that the "ntp," compatible strings are deprecated
> which should be "ntc,"
>
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
> ---
> Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> index 3d0146e20d3e10747c3049911b9419e9ccdab83d..b8e500e6cd9f861fbbabd79a14d882341dbb387c 100644
> --- a/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ntc-thermistor.yaml
> @@ -76,7 +76,7 @@ properties:
> - const: murata,ncp03wf104
> - const: murata,ncp15xh103
> - const: samsung,1404-001221
> - # Deprecated "ntp," compatible strings
> + # Deprecated "ntc," compatible strings
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> - const: ntc,ncp15wb473
> deprecated: true
> - const: ntc,ncp18wb473
>
> --
> 2.48.1
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig
2025-02-27 12:57 ` [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig Maud Spierings via B4 Relay
@ 2025-03-02 16:32 ` Guenter Roeck
0 siblings, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2025-03-02 16:32 UTC (permalink / raw)
To: maudspierings
Cc: Jean Delvare, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Linus Walleij, Joseph McNally, linux-hwmon, linux-kernel,
devicetree
On Thu, Feb 27, 2025 at 01:57:51PM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
>
> The module name is incorrectly stated with a hyphen while it is an
> underscore.
>
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles
2025-02-27 12:57 ` [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles Maud Spierings via B4 Relay
2025-02-28 19:01 ` Conor Dooley
@ 2025-03-02 16:33 ` Guenter Roeck
1 sibling, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2025-03-02 16:33 UTC (permalink / raw)
To: maudspierings
Cc: Jean Delvare, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Linus Walleij, Joseph McNally, linux-hwmon, linux-kernel,
devicetree
On Thu, Feb 27, 2025 at 01:57:52PM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
>
> Fix the comment stating that the "ntp," compatible strings are deprecated
> which should be "ntc,"
>
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table
2025-02-27 12:57 ` [PATCH 3/3] hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table Maud Spierings via B4 Relay
@ 2025-03-02 16:35 ` Guenter Roeck
0 siblings, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2025-03-02 16:35 UTC (permalink / raw)
To: maudspierings
Cc: Jean Delvare, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Linus Walleij, Joseph McNally, linux-hwmon, linux-kernel,
devicetree
On Thu, Feb 27, 2025 at 01:57:53PM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@gocontroll.com>
>
> I could not find a single table that has the values currently present in
> the table, change it to the actual values that can be found in [1]/[2]
> and [3] (page 15 column 2)
>
> [1]: https://www.murata.com/products/productdetail?partno=NCP15XH103F03RC
> [2]: https://www.murata.com/products/productdata/8796836626462/NTHCG83.txt?1437969843000
> [3]: https://nl.mouser.com/datasheet/2/281/r44e-522712.pdf
>
> Fixes: 54ce3a0d8011 ("hwmon: (ntc_thermistor) Add support for ncpXXxh103")
>
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-03-02 16:35 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-27 12:57 [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Maud Spierings via B4 Relay
2025-02-27 12:57 ` [PATCH 1/3] hwmon: (ntc_thermistor) Fix module name in the Kconfig Maud Spierings via B4 Relay
2025-03-02 16:32 ` Guenter Roeck
2025-02-27 12:57 ` [PATCH 2/3] dt-bindings: hwmon: ntc-thermistor: fix typo regarding the deprecation of the ntc, compatibles Maud Spierings via B4 Relay
2025-02-28 19:01 ` Conor Dooley
2025-03-02 16:33 ` Guenter Roeck
2025-02-27 12:57 ` [PATCH 3/3] hwmon: (ntc_thermistor) Fix the ncpXXxh103 sensor table Maud Spierings via B4 Relay
2025-03-02 16:35 ` Guenter Roeck
2025-02-28 8:28 ` [PATCH 0/3] hwmon: (ntc_thermistor) typo fixes and incorrect table fix Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox