public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: PCI: Revert "dt-bindings: PCI: qcom: Use SDX55 'reg' definition for IPQ9574"
@ 2025-03-06 12:03 Krzysztof Kozlowski
  2025-03-06 12:51 ` Krzysztof Wilczyński
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-06 12:03 UTC (permalink / raw)
  To: Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas,
	Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Varadarajan Narayanan, linux-arm-msm, linux-pci, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski, Konrad Dybcio

Revert commit 829aa3693f8d ("dt-bindings: PCI: qcom: Use SDX55 'reg'
definition for IPQ9574") because it affected existing DTS (already
released), without any valid reason and without explanation.

Reverted commit 829aa3693f8d ("dt-bindings: PCI: qcom: Use SDX55 'reg'
definition for IPQ9574") also introduces new warnings:

  ipq9574-rdp449.dtb: pcie@10000000: reg-names:0: 'parf' was expected

Reported-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: 829aa3693f8d ("dt-bindings: PCI: qcom: Use SDX55 'reg' definition for IPQ9574")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Drop double "::" in subject.
---
 Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 6696a36009da..8f628939209e 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -170,6 +170,7 @@ allOf:
             enum:
               - qcom,pcie-ipq6018
               - qcom,pcie-ipq8074-gen3
+              - qcom,pcie-ipq9574
     then:
       properties:
         reg:
@@ -210,7 +211,6 @@ allOf:
         compatible:
           contains:
             enum:
-              - qcom,pcie-ipq9574
               - qcom,pcie-sdx55
     then:
       properties:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] dt-bindings: PCI: Revert "dt-bindings: PCI: qcom: Use SDX55 'reg' definition for IPQ9574"
  2025-03-06 12:03 [PATCH v2] dt-bindings: PCI: Revert "dt-bindings: PCI: qcom: Use SDX55 'reg' definition for IPQ9574" Krzysztof Kozlowski
@ 2025-03-06 12:51 ` Krzysztof Wilczyński
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2025-03-06 12:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Lorenzo Pieralisi, Manivannan Sadhasivam, Rob Herring,
	Bjorn Helgaas, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
	Varadarajan Narayanan, linux-arm-msm, linux-pci, devicetree,
	linux-kernel, Konrad Dybcio

Hello,

> Revert commit 829aa3693f8d ("dt-bindings: PCI: qcom: Use SDX55 'reg'
> definition for IPQ9574") because it affected existing DTS (already
> released), without any valid reason and without explanation.
> 
> Reverted commit 829aa3693f8d ("dt-bindings: PCI: qcom: Use SDX55 'reg'
> definition for IPQ9574") also introduces new warnings:
> 
>   ipq9574-rdp449.dtb: pcie@10000000: reg-names:0: 'parf' was expected

I removed the offending commit from the dt-bindings branch.

The next branch will be updated in due course.

Thank you!

	Krzysztof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-06 12:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06 12:03 [PATCH v2] dt-bindings: PCI: Revert "dt-bindings: PCI: qcom: Use SDX55 'reg' definition for IPQ9574" Krzysztof Kozlowski
2025-03-06 12:51 ` Krzysztof Wilczyński

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox