From: "Krzysztof Wilczyński" <kw@linux.com>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@amd.com,
bharat.kumar.gogada@amd.com
Subject: Re: [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init_port
Date: Tue, 11 Mar 2025 16:27:36 +0900 [thread overview]
Message-ID: <20250311072736.GB277060@rocinante> (raw)
In-Reply-To: <20250311072402.1049990-1-thippeswamy.havalige@amd.com>
Hello,
> Fix an incorrect conditional check in xilinx_cpm_pcie_init_port().
>
> The previous condition mistakenly skipped initialization for all
> versions except CPM5NC_HOST. This is now corrected to ensure that only
> the CPM5NC_HOST is skipped while other versions proceed with
> initialization.
[...]
> {
> const struct xilinx_cpm_variant *variant = port->variant;
>
> - if (variant->version != CPM5NC_HOST)
> + if (variant->version == CPM5NC_HOST)
> return;
>
> if (cpm_pcie_link_up(port))
Ouch! Nice catch.
I will pull and squash this against the existing code directly on the branch.
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-03-11 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 7:24 [PATCH] PCI: xilinx-cpm: Fix incorrect version check in init_port Thippeswamy Havalige
2025-03-11 7:27 ` Krzysztof Wilczyński [this message]
2025-03-11 9:58 ` Havalige, Thippeswamy
2025-03-11 14:50 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311072736.GB277060@rocinante \
--to=kw@linux.com \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox