* [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property
@ 2025-02-13 20:32 David Heidelberg
2025-03-19 20:17 ` Andreas Kemnade
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Heidelberg @ 2025-02-13 20:32 UTC (permalink / raw)
To: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Pavel Machek, Pali Rohár
Cc: David Heidelberg, linux-omap, devicetree, linux-kernel
This property is irrelevant for the ad5820 DAC,
the driver nor the hardware indicate use of channel cells.
Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 --
1 file changed, 2 deletions(-)
diff --git ./arch/arm/boot/dts/ti/omap/omap3-n900.dts ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
index 4bde3342bb959..c50ca572d1b9b 100644
--- ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
+++ ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
@@ -816,8 +816,6 @@ ad5820: dac@c {
reg = <0x0c>;
VANA-supply = <&vaux4>;
-
- #io-channel-cells = <0>;
};
};
--
2.47.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property
2025-02-13 20:32 [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property David Heidelberg
@ 2025-03-19 20:17 ` Andreas Kemnade
2025-03-19 22:56 ` Sebastian Reichel
2025-04-11 0:39 ` Kevin Hilman
2 siblings, 0 replies; 5+ messages in thread
From: Andreas Kemnade @ 2025-03-19 20:17 UTC (permalink / raw)
To: David Heidelberg
Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Pavel Machek, Pali Rohár, linux-omap, devicetree,
linux-kernel
Am Thu, 13 Feb 2025 21:32:03 +0100
schrieb David Heidelberg <david@ixit.cz>:
> This property is irrelevant for the ad5820 DAC,
> the driver nor the hardware indicate use of channel cells.
>
> Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property
2025-02-13 20:32 [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property David Heidelberg
2025-03-19 20:17 ` Andreas Kemnade
@ 2025-03-19 22:56 ` Sebastian Reichel
2025-03-20 8:48 ` Pavel Machek
2025-04-11 0:39 ` Kevin Hilman
2 siblings, 1 reply; 5+ messages in thread
From: Sebastian Reichel @ 2025-03-19 22:56 UTC (permalink / raw)
To: David Heidelberg
Cc: Tony Lindgren, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Pavel Machek, Pali Rohár, linux-omap, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
Hi,
On Thu, Feb 13, 2025 at 09:32:03PM +0100, David Heidelberg wrote:
> This property is irrelevant for the ad5820 DAC,
> the driver nor the hardware indicate use of channel cells.
>
> Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support")
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
I certainly don't think this is a fix and probably just stay, see:
https://lore.kernel.org/all/ih3ykzxrnpbwg4bvkmpoo2tashcxidir4r4zofhlvrs7udkp7o@6qtqh6wtmkwd/
-- Sebastian
> arch/arm/boot/dts/ti/omap/omap3-n900.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git ./arch/arm/boot/dts/ti/omap/omap3-n900.dts ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
> index 4bde3342bb959..c50ca572d1b9b 100644
> --- ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
> +++ ./arch/arm/boot/dts/ti/omap/omap3-n900.dts
> @@ -816,8 +816,6 @@ ad5820: dac@c {
> reg = <0x0c>;
>
> VANA-supply = <&vaux4>;
> -
> - #io-channel-cells = <0>;
> };
> };
>
> --
> 2.47.2
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property
2025-03-19 22:56 ` Sebastian Reichel
@ 2025-03-20 8:48 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2025-03-20 8:48 UTC (permalink / raw)
To: Sebastian Reichel
Cc: David Heidelberg, Tony Lindgren, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pali Rohár, linux-omap, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Hi!
> > This property is irrelevant for the ad5820 DAC,
> > the driver nor the hardware indicate use of channel cells.
> >
> > Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support")
> > Signed-off-by: David Heidelberg <david@ixit.cz>
> > ---
>
> I certainly don't think this is a fix and probably just stay, see:
>
> https://lore.kernel.org/all/ih3ykzxrnpbwg4bvkmpoo2tashcxidir4r4zofhlvrs7udkp7o@6qtqh6wtmkwd/
The idea is that we can simplify binding document at that
point. Currently we are getting feedback that it is not needed on that
side :-(
Best regards,
Pavel
> > @@ -816,8 +816,6 @@ ad5820: dac@c {
> > reg = <0x0c>;
> >
> > VANA-supply = <&vaux4>;
> > -
> > - #io-channel-cells = <0>;
> > };
> > };
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property
2025-02-13 20:32 [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property David Heidelberg
2025-03-19 20:17 ` Andreas Kemnade
2025-03-19 22:56 ` Sebastian Reichel
@ 2025-04-11 0:39 ` Kevin Hilman
2 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2025-04-11 0:39 UTC (permalink / raw)
To: David Heidelberg, Tony Lindgren, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Pavel Machek, Pali Rohár
Cc: David Heidelberg, linux-omap, devicetree, linux-kernel
David Heidelberg <david@ixit.cz> writes:
> This property is irrelevant for the ad5820 DAC,
> the driver nor the hardware indicate use of channel cells.
>
> Fixes: d510d12f26f4 ("ARM: dts: nokia n900: update dts with camera support")
> Signed-off-by: David Heidelberg <david@ixit.cz>
Queued for v6.16,
Thanks,
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-11 0:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-13 20:32 [PATCH] ARM: dts: nokia n900: remove useless io-channel-cells property David Heidelberg
2025-03-19 20:17 ` Andreas Kemnade
2025-03-19 22:56 ` Sebastian Reichel
2025-03-20 8:48 ` Pavel Machek
2025-04-11 0:39 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox