From: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Abel Vesa <abel.vesa@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 06/10] phy: phy-snps-eusb2: make repeater optional
Date: Fri, 21 Mar 2025 15:58:50 +0200 [thread overview]
Message-ID: <20250321135854.1431375-7-ivo.ivanov.ivanov1@gmail.com> (raw)
In-Reply-To: <20250321135854.1431375-1-ivo.ivanov.ivanov1@gmail.com>
As described in the device tree bindings, it's not necessary for the
SNPS eUSB2 phy to be connected to a repeater. In configurations where
there are such instances, the driver probing fails and the usb
controller does not work.
Make the repeater optional to avoid that, which also lets us use
the eUSB2 phy when it's connected to a repeater that is not configurable
by the kernel (for example it's missing a driver), as long as it has
been configured beforehand (usually by the bootloader).
Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/phy/phy-snps-eusb2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
index fa878389f..8ccd432a0 100644
--- a/drivers/phy/phy-snps-eusb2.c
+++ b/drivers/phy/phy-snps-eusb2.c
@@ -428,7 +428,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
return dev_err_probe(dev, ret,
"failed to get regulator supplies\n");
- phy->repeater = devm_of_phy_get_by_index(dev, np, 0);
+ phy->repeater = devm_of_phy_optional_get(dev, np, 0);
if (IS_ERR(phy->repeater))
return dev_err_probe(dev, PTR_ERR(phy->repeater),
"failed to get repeater\n");
--
2.43.0
next prev parent reply other threads:[~2025-03-21 13:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 13:58 [PATCH v3 00/10] phy: samsung: add Exynos2200 SNPS eUSB2 driver Ivaylo Ivanov
2025-03-21 13:58 ` [PATCH v3 01/10] dt-bindings: phy: add exynos2200 eusb2 phy support Ivaylo Ivanov
2025-03-24 8:45 ` Krzysztof Kozlowski
2025-03-21 13:58 ` [PATCH v3 02/10] dt-bindings: phy: samsung,usb3-drd-phy: add exynos2200 support Ivaylo Ivanov
2025-03-25 15:16 ` Rob Herring
2025-03-21 13:58 ` [PATCH v3 03/10] phy: move phy-qcom-snps-eusb2 out of its vendor sub-directory Ivaylo Ivanov
2025-03-21 14:15 ` Dmitry Baryshkov
2025-03-21 14:17 ` Ivaylo Ivanov
2025-03-21 13:58 ` [PATCH v3 04/10] phy: phy-snps-eusb2: refactor constructs names Ivaylo Ivanov
2025-03-21 14:17 ` Dmitry Baryshkov
2025-03-21 13:58 ` [PATCH v3 05/10] phy: phy-snps-eusb2: split phy init code Ivaylo Ivanov
2025-03-21 14:31 ` Dmitry Baryshkov
2025-03-21 14:34 ` neil.armstrong
2025-03-21 13:58 ` Ivaylo Ivanov [this message]
2025-03-21 15:13 ` [PATCH v3 06/10] phy: phy-snps-eusb2: make repeater optional Dmitry Baryshkov
2025-03-21 13:58 ` [PATCH v3 07/10] phy: phy-snps-eusb2: make reset control optional Ivaylo Ivanov
2025-03-21 13:58 ` [PATCH v3 08/10] phy: phy-snps-eusb2: refactor reference clock init Ivaylo Ivanov
2025-03-21 15:53 ` Dmitry Baryshkov
2025-03-21 13:58 ` [PATCH v3 09/10] phy: phy-snps-eusb2: add support for exynos2200 Ivaylo Ivanov
2025-03-21 15:53 ` Dmitry Baryshkov
2025-03-21 13:58 ` [PATCH v3 10/10] phy: exynos5-usbdrd: support Exynos USBDRD 3.2 4nm controller Ivaylo Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321135854.1431375-7-ivo.ivanov.ivanov1@gmail.com \
--to=ivo.ivanov.ivanov1@gmail.com \
--cc=abel.vesa@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox