[PATCH 0/6] Enhancements for PCIe Cadence Controllers

[PATCH 0/6] Enhancements for PCIe Cadence Controllers

[Manikandan Karunakaran Pillai]

Enhances the exiting Cadence PCIe controller drivers to support second
generation PCIe controller also referred as HPA(High Performance
Architecture) controllers.

Comments from the earlier patch submission on the same enhancements are
taken into consideration. The previous submitted patch links is
https://patchwork.kernel.org/project/linux-pci/patch/
CH2PPF4D26F8E1CB68755477DCA7AA9C6EBA2EE2@CH2PPF4D26F8E1C.namprd07.prod.outlook.com/

The changes are tested on 2 platforms. The legacy controller changes are
tested on an TI J7200 EVM and HPA changes are tested on an FPGA platform
available within Cadence.

Manikandan K Pillai (6):
  dt-bindings: pci: cadence: Add property "hpa" for PCIe controllers
  PCI: cadence: Add header support for PCIe next generation controllers
  PCI: cadence: Add architecture information for PCIe controller
  PCI: cadence: Add support for PCIe Endpoint HPA controller
  PCI: cadence: Add callback functions for Root Port and EP controllers
  PCI: cadence:  Update support for TI J721e boards

 .../bindings/pci/cdns,cdns-pcie-ep.yaml       |   4 +
 .../bindings/pci/cdns,cdns-pcie-host.yaml     |   7 +
 drivers/pci/controller/cadence/pci-j721e.c    |   8 +
 .../pci/controller/cadence/pcie-cadence-ep.c  | 179 +++++++++--
 .../controller/cadence/pcie-cadence-host.c    | 257 ++++++++++++++--
 .../controller/cadence/pcie-cadence-plat.c    |  30 ++
 drivers/pci/controller/cadence/pcie-cadence.c | 195 +++++++++++-
 drivers/pci/controller/cadence/pcie-cadence.h | 290 +++++++++++++++++-
 8 files changed, 922 insertions(+), 48 deletions(-)

-- 
2.27.0

Re: [PATCH 0/6] Enhancements for PCIe Cadence Controllers

[Bjorn Helgaas]

On Mon, Mar 24, 2025 at 09:08:09AM +0000, Manikandan Karunakaran Pillai wrote:
> Enhances the exiting Cadence PCIe controller drivers to support second
> generation PCIe controller also referred as HPA(High Performance
> Architecture) controllers.
> 
> Comments from the earlier patch submission on the same enhancements are
> taken into consideration. The previous submitted patch links is
> https://patchwork.kernel.org/project/linux-pci/patch/
> CH2PPF4D26F8E1CB68755477DCA7AA9C6EBA2EE2@CH2PPF4D26F8E1C.namprd07.prod.outlook.com/

Thanks for splitting this into several patches.

Thanks also for the pointer to the previous version.  It would be
easier to follow if you could include the lore URL, e.g.,

  https://lore.kernel.org/r/CH2PPF4D26F8E1CB68755477DCA7AA9C6EBA2EE2@CH2PPF4D26F8E1C.namprd07.prod.outlook.com/

because lore is more widely used and more stable than patchwork.  It's
helpful if you can also include a little changelog of what changed
since the previous version.

When you post the next version of this (no hurry, since the merge
window is open and nothing new will be merged until v6.15-rc1), can
you please send the individual patches as responses to the cover
letter?  That keeps the whole series together and makes it easy for b4
to download the entire series at once.  "git format-patch" and "git
send-email" will do that for you automatically.

Bjorn

Re: [PATCH 0/6] Enhancements for PCIe Cadence Controllers

[manivannan.sadhasivam]

On Mon, Mar 24, 2025 at 09:08:09AM +0000, Manikandan Karunakaran Pillai wrote:
> Enhances the exiting Cadence PCIe controller drivers to support second
> generation PCIe controller also referred as HPA(High Performance
> Architecture) controllers.
> 
> Comments from the earlier patch submission on the same enhancements are
> taken into consideration. The previous submitted patch links is
> https://patchwork.kernel.org/project/linux-pci/patch/
> CH2PPF4D26F8E1CB68755477DCA7AA9C6EBA2EE2@CH2PPF4D26F8E1C.namprd07.prod.outlook.com/
> 
> The changes are tested on 2 platforms. The legacy controller changes are
> tested on an TI J7200 EVM and HPA changes are tested on an FPGA platform
> available within Cadence.
> 
> Manikandan K Pillai (6):
>   dt-bindings: pci: cadence: Add property "hpa" for PCIe controllers
>   PCI: cadence: Add header support for PCIe next generation controllers
>   PCI: cadence: Add architecture information for PCIe controller
>   PCI: cadence: Add support for PCIe Endpoint HPA controller
>   PCI: cadence: Add callback functions for Root Port and EP controllers
>   PCI: cadence:  Update support for TI J721e boards
> 

Your series is broken in some form that neither lore nor my email client could
find all patches linked to the cover letter. Please use a better tooling like b4
and resubmit.

- Mani

>  .../bindings/pci/cdns,cdns-pcie-ep.yaml       |   4 +
>  .../bindings/pci/cdns,cdns-pcie-host.yaml     |   7 +
>  drivers/pci/controller/cadence/pci-j721e.c    |   8 +
>  .../pci/controller/cadence/pcie-cadence-ep.c  | 179 +++++++++--
>  .../controller/cadence/pcie-cadence-host.c    | 257 ++++++++++++++--
>  .../controller/cadence/pcie-cadence-plat.c    |  30 ++
>  drivers/pci/controller/cadence/pcie-cadence.c | 195 +++++++++++-
>  drivers/pci/controller/cadence/pcie-cadence.h | 290 +++++++++++++++++-
>  8 files changed, 922 insertions(+), 48 deletions(-)
> 
> -- 
> 2.27.0
> 

-- 
மணிவண்ணன் சதாசிவம்