From: Yixun Lan <dlan@gentoo.org>
To: "Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Guodong Xu <guodong@riscstar.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
drew@pdp7.com, inochiama@gmail.com, geert+renesas@glider.be,
heylenay@4d2.org, tglx@linutronix.de, hal.feng@starfivetech.com,
unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
elder@riscstar.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [PATCH 7/9] riscv: dts: spacemit: Add PWM14 backlight support for BPI-F3
Date: Mon, 14 Apr 2025 08:03:44 +0000 [thread overview]
Message-ID: <20250414080344-GYA28186@gentoo> (raw)
In-Reply-To: <5lfnxricxm2k3fuf6nfvjd6cbkmsjkx7inoi52uy5uwwvld7sq@abn4i62tdics>
Hi Uwe,
On 07:58 Mon 14 Apr , Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Apr 11, 2025 at 09:14:21PM +0800, Guodong Xu wrote:
> > +&pwm14 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pwm14_1_cfg>;
> > + status = "disabled";
> > +};
>
> I wonder if the pinctrl properties can better be added to the SoC's
> .dtsi file. (Only applies if this is a canonical choice, i.e. there is
> no other possible output configuration.)
>
I'd agree it's a good idea and should follow, but unfortunately in the
practical case, all pwm able to route to at least two different pins..
https://developer.spacemit.com/documentation?token=YiJZwXA2Ri4nJikV9E1cp6nqnMh
see section: 4.5 Multi-Function I/O Pin Assignments
--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55
next prev parent reply other threads:[~2025-04-14 8:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 13:14 [PATCH 0/9] pwm: Update PWM_PXA driver for SpacemiT K1 Guodong Xu
2025-04-11 13:14 ` [PATCH 1/9] dt-bindings: pwm: marvell,pxa: add optional property resets Guodong Xu
2025-04-11 16:44 ` Conor Dooley
2025-04-15 8:52 ` Philipp Zabel
2025-04-15 9:54 ` Guodong Xu
2025-04-15 10:12 ` Yixun Lan
2025-04-15 12:11 ` Alex Elder
2025-04-15 12:28 ` Yixun Lan
2025-04-16 5:18 ` Uwe Kleine-König
2025-04-16 11:33 ` Alex Elder
2025-04-16 14:56 ` Uwe Kleine-König
2025-04-11 13:14 ` [PATCH 2/9] pwm: pxa: add optional reset control Guodong Xu
2025-04-11 13:14 ` [PATCH 3/9] dt-bindings: pwm: marvell,pxa: add support to spacemit K1 Guodong Xu
2025-04-11 16:43 ` Conor Dooley
2025-04-12 4:00 ` Guodong Xu
2025-04-11 13:14 ` [PATCH 4/9] pwm: pxa: add support for " Guodong Xu
2025-04-11 13:14 ` [PATCH 5/9] riscv: dts: spacemit: add PWM support for K1 SoC Guodong Xu
2025-04-11 13:14 ` [PATCH 6/9] riscv: dts: spacemit: Add pinctrl configurations for PWM0-PWM19 Guodong Xu
2025-04-11 22:50 ` Inochi Amaoto
2025-04-14 16:42 ` Samuel Holland
2025-04-11 13:14 ` [PATCH 7/9] riscv: dts: spacemit: Add PWM14 backlight support for BPI-F3 Guodong Xu
2025-04-11 14:05 ` Yixun Lan
2025-04-11 14:23 ` Alex Elder
2025-04-11 14:45 ` Yixun Lan
2025-04-11 23:28 ` Inochi Amaoto
2025-04-12 4:22 ` Guodong Xu
2025-04-11 22:54 ` Inochi Amaoto
2025-04-14 5:58 ` Uwe Kleine-König
2025-04-14 8:03 ` Yixun Lan [this message]
2025-04-11 13:14 ` [PATCH 8/9] pwm: Kconfig: add depends on ARCH_SPACEMIT to PWM_PXA Guodong Xu
2025-04-11 13:14 ` [PATCH 9/9] riscv: defconfig: Enable PWM support for SpacemiT K1 SoC Guodong Xu
2025-04-11 22:52 ` Inochi Amaoto
2025-04-12 4:02 ` Guodong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414080344-GYA28186@gentoo \
--to=dlan@gentoo.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@pdp7.com \
--cc=duje.mihanovic@skole.hr \
--cc=elder@riscstar.com \
--cc=geert+renesas@glider.be \
--cc=guodong@riscstar.com \
--cc=hal.feng@starfivetech.com \
--cc=heylenay@4d2.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=ukleinek@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox