* [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property
@ 2025-04-17 18:04 Peter Korsgaard
2025-04-22 13:26 ` Rob Herring
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Peter Korsgaard @ 2025-04-17 18:04 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Peter Korsgaard, Krzysztof Kozlowski, linux-hwmon, devicetree,
linux-kernel
TMP102 is powered by its V+ supply, document it. The property is called
"vcc-supply" since the plus sign (+) is not a valid property character.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
index 7e5b62a0215dd..4c89448eba0dc 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
@@ -23,6 +23,9 @@ properties:
"#thermal-sensor-cells":
const: 1
+ vcc-supply:
+ description: Power supply for tmp102
+
required:
- compatible
- reg
@@ -42,6 +45,7 @@ examples:
reg = <0x48>;
interrupt-parent = <&gpio7>;
interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
+ vcc-supply = <&supply>;
#thermal-sensor-cells = <1>;
};
};
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property
2025-04-17 18:04 [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property Peter Korsgaard
@ 2025-04-22 13:26 ` Rob Herring
2025-04-22 13:31 ` Peter Korsgaard
2025-04-23 14:03 ` Rob Herring (Arm)
2025-04-23 14:17 ` Guenter Roeck
2 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2025-04-22 13:26 UTC (permalink / raw)
To: Peter Korsgaard
Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Conor Dooley,
Krzysztof Kozlowski, linux-hwmon, devicetree, linux-kernel
On Thu, Apr 17, 2025 at 08:04:25PM +0200, Peter Korsgaard wrote:
> TMP102 is powered by its V+ supply, document it. The property is called
> "vcc-supply" since the plus sign (+) is not a valid property character.
Wouldn't "vplus-supply" or "vp-supply" work?
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> index 7e5b62a0215dd..4c89448eba0dc 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -23,6 +23,9 @@ properties:
> "#thermal-sensor-cells":
> const: 1
>
> + vcc-supply:
> + description: Power supply for tmp102
> +
> required:
> - compatible
> - reg
> @@ -42,6 +45,7 @@ examples:
> reg = <0x48>;
> interrupt-parent = <&gpio7>;
> interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> + vcc-supply = <&supply>;
> #thermal-sensor-cells = <1>;
> };
> };
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property
2025-04-22 13:26 ` Rob Herring
@ 2025-04-22 13:31 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2025-04-22 13:31 UTC (permalink / raw)
To: Rob Herring
Cc: Jean Delvare, Guenter Roeck, Krzysztof Kozlowski, Conor Dooley,
Krzysztof Kozlowski, linux-hwmon, devicetree, linux-kernel
>>>>> "Rob" == Rob Herring <robh@kernel.org> writes:
> On Thu, Apr 17, 2025 at 08:04:25PM +0200, Peter Korsgaard wrote:
>> TMP102 is powered by its V+ supply, document it. The property is called
>> "vcc-supply" since the plus sign (+) is not a valid property character.
> Wouldn't "vplus-supply" or "vp-supply" work?
It could, but gcc-supply is what we use for the very similar tmp108
binding, so I think it makes sense to use that here for consistency as
well:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=699383466851e3fb8284e1eefeed78ec30989b3b
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property
2025-04-17 18:04 [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property Peter Korsgaard
2025-04-22 13:26 ` Rob Herring
@ 2025-04-23 14:03 ` Rob Herring (Arm)
2025-04-23 14:17 ` Guenter Roeck
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2025-04-23 14:03 UTC (permalink / raw)
To: Peter Korsgaard
Cc: Krzysztof Kozlowski, Guenter Roeck, Krzysztof Kozlowski,
linux-hwmon, linux-kernel, devicetree, Conor Dooley, Jean Delvare
On Thu, 17 Apr 2025 20:04:25 +0200, Peter Korsgaard wrote:
> TMP102 is powered by its V+ supply, document it. The property is called
> "vcc-supply" since the plus sign (+) is not a valid property character.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property
2025-04-17 18:04 [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property Peter Korsgaard
2025-04-22 13:26 ` Rob Herring
2025-04-23 14:03 ` Rob Herring (Arm)
@ 2025-04-23 14:17 ` Guenter Roeck
2 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2025-04-23 14:17 UTC (permalink / raw)
To: Peter Korsgaard
Cc: Jean Delvare, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Krzysztof Kozlowski, linux-hwmon, devicetree, linux-kernel
On Thu, Apr 17, 2025 at 08:04:25PM +0200, Peter Korsgaard wrote:
> TMP102 is powered by its V+ supply, document it. The property is called
> "vcc-supply" since the plus sign (+) is not a valid property character.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-23 14:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-17 18:04 [PATCH 1/2] dt-bindings: hwmon: ti,tmp102: document optional V+ supply property Peter Korsgaard
2025-04-22 13:26 ` Rob Herring
2025-04-22 13:31 ` Peter Korsgaard
2025-04-23 14:03 ` Rob Herring (Arm)
2025-04-23 14:17 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox