[PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Alexey Charkov]

APC Rock is a development board based on WonderMedia WM8950 SoC
released around 2013. Paper is the same as Rock but lacking a
VGA port and shipped with a recycled cardboard case.

While at that, put myself as the maintainer, given that Tony is
unavailable as of lately.

Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
Split the series from v1 into separate bindings patches so as not to
spam all the subsystems with unrelated changes, per Rob's suggestion

Changes in v2:
- kept single-valued compatibles in a single enum (thanks Rob)
- dropped the empty overall description node

Link to v1: https://lore.kernel.org/all/20250416-wmt-updates-v1-7-f9af689cdfc2@gmail.com/
---
 Documentation/devicetree/bindings/arm/vt8500.yaml | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/vt8500.yaml b/Documentation/devicetree/bindings/arm/vt8500.yaml
index 5d5ad5a60451f569e6ef30c924a1964d02e1aa82..f2164144a7af29ca77761bc58fe7f4558e7d101c 100644
--- a/Documentation/devicetree/bindings/arm/vt8500.yaml
+++ b/Documentation/devicetree/bindings/arm/vt8500.yaml
@@ -7,19 +7,24 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: VIA/Wondermedia VT8500 Platforms
 
 maintainers:
-  - Tony Prisk <linux@prisktech.co.nz>
-description: test
+  - Alexey Charkov <alchark@gmail.com>
 
 properties:
   $nodename:
     const: '/'
   compatible:
-    items:
-      - enum:
-          - via,vt8500
-          - wm,wm8505
-          - wm,wm8650
-          - wm,wm8750
-          - wm,wm8850
+    oneOf:
+      - items:
+          - enum:
+              - via,vt8500
+              - wm,wm8505
+              - wm,wm8650
+              - wm,wm8750
+              - wm,wm8850
+
+      - description: VIA APC Rock and Paper boards
+        items:
+          - const: via,apc-rock
+          - const: wm,wm8950
 
 additionalProperties: true

---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250418-apc_paper_binding-8feae286710e

Best regards,
-- 
Alexey Charkov <alchark@gmail.com>

Re: [PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Rob Herring]

On Fri, Apr 18, 2025 at 07:24:25PM +0400, Alexey Charkov wrote:
> APC Rock is a development board based on WonderMedia WM8950 SoC
> released around 2013. Paper is the same as Rock but lacking a
> VGA port and shipped with a recycled cardboard case.
> 
> While at that, put myself as the maintainer, given that Tony is
> unavailable as of lately.
> 
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
> Split the series from v1 into separate bindings patches so as not to
> spam all the subsystems with unrelated changes, per Rob's suggestion
> 
> Changes in v2:
> - kept single-valued compatibles in a single enum (thanks Rob)
> - dropped the empty overall description node
> 
> Link to v1: https://lore.kernel.org/all/20250416-wmt-updates-v1-7-f9af689cdfc2@gmail.com/
> ---
>  Documentation/devicetree/bindings/arm/vt8500.yaml | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)

Do you want me to apply or you will take via vt8500 tree?

Rob

Re: [PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Alexey Charkov]

On Wed, Apr 23, 2025 at 7:35 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Apr 18, 2025 at 07:24:25PM +0400, Alexey Charkov wrote:
> > APC Rock is a development board based on WonderMedia WM8950 SoC
> > released around 2013. Paper is the same as Rock but lacking a
> > VGA port and shipped with a recycled cardboard case.
> >
> > While at that, put myself as the maintainer, given that Tony is
> > unavailable as of lately.
> >
> > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > ---
> > Split the series from v1 into separate bindings patches so as not to
> > spam all the subsystems with unrelated changes, per Rob's suggestion
> >
> > Changes in v2:
> > - kept single-valued compatibles in a single enum (thanks Rob)
> > - dropped the empty overall description node
> >
> > Link to v1: https://lore.kernel.org/all/20250416-wmt-updates-v1-7-f9af689cdfc2@gmail.com/
> > ---
> >  Documentation/devicetree/bindings/arm/vt8500.yaml | 23 ++++++++++++++---------
> >  1 file changed, 14 insertions(+), 9 deletions(-)
>
> Do you want me to apply or you will take via vt8500 tree?

We don't have a dedicated public vt8500 tree right now, so if you
could apply it would be much appreciated!

Best regards,
Alexey

Re: [PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Krzysztof Kozlowski]

On Wed, Apr 23, 2025 at 07:43:34PM GMT, Alexey Charkov wrote:
> On Wed, Apr 23, 2025 at 7:35 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, Apr 18, 2025 at 07:24:25PM +0400, Alexey Charkov wrote:
> > > APC Rock is a development board based on WonderMedia WM8950 SoC
> > > released around 2013. Paper is the same as Rock but lacking a
> > > VGA port and shipped with a recycled cardboard case.
> > >
> > > While at that, put myself as the maintainer, given that Tony is
> > > unavailable as of lately.
> > >
> > > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > > ---
> > > Split the series from v1 into separate bindings patches so as not to
> > > spam all the subsystems with unrelated changes, per Rob's suggestion
> > >
> > > Changes in v2:
> > > - kept single-valued compatibles in a single enum (thanks Rob)
> > > - dropped the empty overall description node
> > >
> > > Link to v1: https://lore.kernel.org/all/20250416-wmt-updates-v1-7-f9af689cdfc2@gmail.com/
> > > ---
> > >  Documentation/devicetree/bindings/arm/vt8500.yaml | 23 ++++++++++++++---------
> > >  1 file changed, 14 insertions(+), 9 deletions(-)
> >
> > Do you want me to apply or you will take via vt8500 tree?
> 
> We don't have a dedicated public vt8500 tree right now, so if you
> could apply it would be much appreciated!

We have.

I'll take it.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Krzysztof Kozlowski]

On Fri, Apr 18, 2025 at 07:24:25PM GMT, Alexey Charkov wrote:
> APC Rock is a development board based on WonderMedia WM8950 SoC
> released around 2013. Paper is the same as Rock but lacking a
> VGA port and shipped with a recycled cardboard case.
> 
> While at that, put myself as the maintainer, given that Tony is
> unavailable as of lately.
> 
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
> Split the series from v1 into separate bindings patches so as not to

Hm? That's odd.

> spam all the subsystems with unrelated changes, per Rob's suggestion
> 
> Changes in v2:
> - kept single-valued compatibles in a single enum (thanks Rob)
> - dropped the empty overall description node

...

> +
> +      - description: VIA APC Rock and Paper boards
> +        items:
> +          - const: via,apc-rock

Where is any user of this? Bindings always come with the user. Board
compatible comes with its user - board - both to SoC subsystem (in this
case me).

See also SoC maintainer profile describing this or my guides how to
properly target SoC subsystems:
https://lore.kernel.org/linux-samsung-soc/CADrjBPq_0nUYRABKpskRF_dhHu+4K=duPVZX==0pr+cjSL_caQ@mail.gmail.com/T/#m2d9130a1342ab201ab49670fa6c858ee3724c83c

and great example:
https://lore.kernel.org/all/20231121-topic-sm8650-upstream-dt-v3-0-db9d0507ffd3@linaro.org/


Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Alexey Charkov]

On Fri, Apr 25, 2025 at 2:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Fri, Apr 18, 2025 at 07:24:25PM GMT, Alexey Charkov wrote:
> > APC Rock is a development board based on WonderMedia WM8950 SoC
> > released around 2013. Paper is the same as Rock but lacking a
> > VGA port and shipped with a recycled cardboard case.
> >
> > While at that, put myself as the maintainer, given that Tony is
> > unavailable as of lately.
> >
> > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > ---
> > Split the series from v1 into separate bindings patches so as not to
>
> Hm? That's odd.

Now that you've asked it (and in light of your comment below) I
realize that Rob referred to rewrites of old textual bindings into
YAML schemas, and probably not this patch in particular.

> > spam all the subsystems with unrelated changes, per Rob's suggestion
> >
> > Changes in v2:
> > - kept single-valued compatibles in a single enum (thanks Rob)
> > - dropped the empty overall description node
>
> ...
>
> > +
> > +      - description: VIA APC Rock and Paper boards
> > +        items:
> > +          - const: via,apc-rock
>
> Where is any user of this? Bindings always come with the user. Board
> compatible comes with its user - board - both to SoC subsystem (in this
> case me).

The DTS addition was in the original "merged" series [1]. I will
resubmit it along with this binding change: it has no external
dependencies so should not create any hassle (i.e. it can be merged in
any order vs. other VT8500 DTS additions and cleanups that I'm doing).

> See also SoC maintainer profile describing this or my guides how to
> properly target SoC subsystems:
> https://lore.kernel.org/linux-samsung-soc/CADrjBPq_0nUYRABKpskRF_dhHu+4K=duPVZX==0pr+cjSL_caQ@mail.gmail.com/T/#m2d9130a1342ab201ab49670fa6c858ee3724c83c
>
> and great example:
> https://lore.kernel.org/all/20231121-topic-sm8650-upstream-dt-v3-0-db9d0507ffd3@linaro.org/

These are great explainers, thanks a lot for pointing them out!

Best regards,
Alexey

Re: [PATCH v2] dt-bindings: arm: vt8500: Add VIA APC Rock/Paper boards

[Alexey Charkov]

On Fri, Apr 25, 2025 at 3:41 PM Alexey Charkov <alchark@gmail.com> wrote:
>
> On Fri, Apr 25, 2025 at 2:19 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Fri, Apr 18, 2025 at 07:24:25PM GMT, Alexey Charkov wrote:
> > > APC Rock is a development board based on WonderMedia WM8950 SoC
> > > released around 2013. Paper is the same as Rock but lacking a
> > > VGA port and shipped with a recycled cardboard case.
> > >
> > > While at that, put myself as the maintainer, given that Tony is
> > > unavailable as of lately.
> > >
> > > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > > ---
> > > Split the series from v1 into separate bindings patches so as not to
> >
> > Hm? That's odd.
>
> Now that you've asked it (and in light of your comment below) I
> realize that Rob referred to rewrites of old textual bindings into
> YAML schemas, and probably not this patch in particular.
>
> > > spam all the subsystems with unrelated changes, per Rob's suggestion
> > >
> > > Changes in v2:
> > > - kept single-valued compatibles in a single enum (thanks Rob)
> > > - dropped the empty overall description node
> >
> > ...
> >
> > > +
> > > +      - description: VIA APC Rock and Paper boards
> > > +        items:
> > > +          - const: via,apc-rock
> >
> > Where is any user of this? Bindings always come with the user. Board
> > compatible comes with its user - board - both to SoC subsystem (in this
> > case me).
>
> The DTS addition was in the original "merged" series [1]. I will
> resubmit it along with this binding change: it has no external
> dependencies so should not create any hassle (i.e. it can be merged in
> any order vs. other VT8500 DTS additions and cleanups that I'm doing).

Lost this line:

[1] https://lore.kernel.org/all/20250416-wmt-updates-v1-12-f9af689cdfc2@gmail.com/

Best regards,
Alexey