From: Jonathan Cameron <jic23@kernel.org>
To: "Tóth János" <gomba007@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: chemical: Document SEN0322
Date: Sun, 4 May 2025 19:27:01 +0100 [thread overview]
Message-ID: <20250504192701.6ceb9daf@jic23-huawei> (raw)
In-Reply-To: <uju5lntp3hzibbrw6ej53xhgvkkpjory74l5et2jspwocuj2xr@bbterxtg3ba7>
On Mon, 28 Apr 2025 16:45:32 +0200
Tóth János <gomba007@gmail.com> wrote:
> Hi!
>
> > No other properties like supplies or configuration? If so, this could go
> > to trivial-devices.
>
> I don't think so, I'll add it as a trivial-device then.
vcc-supply?
It is very common to see later boards have controllable supplies
(or someone to enable that on an existing board for power saving) so
good and trivial to support just turning the supply on when we probe
the driver and off when we remove it.
>
> > > + sen0322@73 {
> >
> > Node names should be generic. See also an explanation and list of
> > examples (not exhaustive) in DT specification:
> > https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> >
> > Choose something from above or similar devices.
>
> Noted, thanks!
>
> Best regards,
> János
>
>
next prev parent reply other threads:[~2025-05-04 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:50 [PATCH 0/2] Add support for the DFRobot SEN0322 oxygen sensor Tóth János via B4 Relay
2025-04-28 10:50 ` [PATCH 1/2] dt-bindings: iio: chemical: Document SEN0322 Tóth János via B4 Relay
2025-04-28 14:30 ` Krzysztof Kozlowski
2025-04-28 14:45 ` Tóth János
2025-05-04 18:27 ` Jonathan Cameron [this message]
2025-05-05 6:32 ` Tóth János
2025-05-05 13:23 ` Jonathan Cameron
2025-04-28 10:50 ` [PATCH 2/2] iio: chemical: Add driver for SEN0322 Tóth János via B4 Relay
2025-05-04 18:40 ` Jonathan Cameron
2025-05-05 6:22 ` Tóth János
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250504192701.6ceb9daf@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gomba007@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox