From: Krzysztof Kozlowski <krzk@kernel.org>
To: gomba007@gmail.com, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: chemical: Document SEN0322
Date: Mon, 28 Apr 2025 16:30:15 +0200 [thread overview]
Message-ID: <9463c3b0-ce67-4c67-a8e9-91b4ffd09a58@kernel.org> (raw)
In-Reply-To: <20250428-iio-chemical-sen0322-v1-1-9b18363ffe42@gmail.com>
On 28/04/2025 12:50, Tóth János via B4 Relay wrote:
> +
> +description: >
> + DFRobot SEN0322 is an oxygen sensor. It supports I2C for communication.
> +
> + Datasheet:
> + https://wiki.dfrobot.com/Gravity_I2C_Oxygen_Sensor_SKU_SEN0322
> +
> +properties:
> + compatible:
> + const: dfrobot,sen0322
> +
> + reg:
> + maxItems: 1
No other properties like supplies or configuration? If so, this could go
to trivial-devices.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sen0322@73 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Choose something from above or similar devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-28 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 10:50 [PATCH 0/2] Add support for the DFRobot SEN0322 oxygen sensor Tóth János via B4 Relay
2025-04-28 10:50 ` [PATCH 1/2] dt-bindings: iio: chemical: Document SEN0322 Tóth János via B4 Relay
2025-04-28 14:30 ` Krzysztof Kozlowski [this message]
2025-04-28 14:45 ` Tóth János
2025-05-04 18:27 ` Jonathan Cameron
2025-05-05 6:32 ` Tóth János
2025-05-05 13:23 ` Jonathan Cameron
2025-04-28 10:50 ` [PATCH 2/2] iio: chemical: Add driver for SEN0322 Tóth János via B4 Relay
2025-05-04 18:40 ` Jonathan Cameron
2025-05-05 6:22 ` Tóth János
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9463c3b0-ce67-4c67-a8e9-91b4ffd09a58@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gomba007@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox