Re: [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string adi,adt7411

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

On Fri, May 23, 2025 at 09:02:12AM -0700, Guenter Roeck wrote:
> On 5/23/25 08:30, Conor Dooley wrote:
> > On Fri, May 23, 2025 at 11:13:37AM -0400, Frank Li wrote:
> > > Add compatible string adi,adt7411, which is temperature sensor and
> > > 8-Channel ADC.
> > 
> > Usually for iio devices supplies are meant to be documented, and this
> > device has one.
> > 
> 
> FWIW, the driver supporting this chip is some 15 years old. I don't think
> anyone was talking about supplies at that time.

That extra context is helpful.

> Also, this is currently implemented as hwmon driver. Is there an effort
> to move the driver out of hwmon and into iio ? Fine with me if this is
> where things are going (one less driver to maintain), but I would caution
> that this will result in an ABI break for users of the hwmon driver.

What subsystem doesn't really matter, particularly the difference
between what is a hwmon or not seems to be up to the whims of the first
submitter for some devices. I don't know anything about moving drivers
or w/e, I am literally just reviewing this one patch that landed in my
inbox that had a supply missing.

If this is some 15 year old device, then I can live without the supply
I suppose.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Really trivial-devices should have an optional supply in it, if someone
comes along with a generic name for that supply..

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]