Devicetree
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Conor Dooley <conor@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Noah Wang <noahwang.wang@outlook.com>,
	Naresh Solanki <naresh.solanki@9elements.com>,
	Michal Simek <michal.simek@amd.com>,
	Fabio Estevam <festevam@gmail.com>,
	Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>,
	Grant Peltier <grantpeltier93@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string adi,adt7411
Date: Fri, 23 May 2025 12:26:05 -0400	[thread overview]
Message-ID: <aDChnSd6Z1lu5eBB@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <e11aade8-f646-4d94-942c-6186f06fe783@roeck-us.net>

On Fri, May 23, 2025 at 09:02:12AM -0700, Guenter Roeck wrote:
> On 5/23/25 08:30, Conor Dooley wrote:
> > On Fri, May 23, 2025 at 11:13:37AM -0400, Frank Li wrote:
> > > Add compatible string adi,adt7411, which is temperature sensor and
> > > 8-Channel ADC.
> >
> > Usually for iio devices supplies are meant to be documented, and this
> > device has one.
> >
>
> FWIW, the driver supporting this chip is some 15 years old. I don't think
> anyone was talking about supplies at that time.
>
> Also, this is currently implemented as hwmon driver. Is there an effort
> to move the driver out of hwmon and into iio ? Fine with me if this is
> where things are going (one less driver to maintain), but I would caution
> that this will result in an ABI break for users of the hwmon driver.

I think no one want to move such old device. We just missed binding doc
for this compatible string.

Frank

>
> Thanks,
> Guenter
>
> > >
> > > Fix below CHECK_DTB warning:
> > >
> > > arch/arm/boot/dts/nxp/vf/vf610-zii-scu4-aib.dtb: /soc/bus@40080000/i2c@400e6000/adc@4a:
> > >      failed to match any schema with compatible: ['adi,adt7411']
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >   Documentation/devicetree/bindings/trivial-devices.yaml | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > index 27930708ccd58..38bc1937ff3c9 100644
> > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > @@ -41,6 +41,7 @@ properties:
> > >             - adi,ad5110
> > >               # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
> > >             - adi,adp5589
> > > +          - adi,adt7411 # Temperature Sensor and 8-Channel ADC
> > >               # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
> > >             - adi,lt7182s
> > >               # AMS iAQ-Core VOC Sensor
> > > --
> > > 2.34.1
> > >
>

  reply	other threads:[~2025-05-23 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 15:13 [PATCH 1/1] dt-bindings: trivial-devices: Add compatible string adi,adt7411 Frank Li
2025-05-23 15:30 ` Conor Dooley
2025-05-23 16:02   ` Guenter Roeck
2025-05-23 16:26     ` Frank Li [this message]
2025-05-23 16:37     ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDChnSd6Z1lu5eBB@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=grantpeltier93@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=michal.simek@amd.com \
    --cc=naresh.solanki@9elements.com \
    --cc=noahwang.wang@outlook.com \
    --cc=robh@kernel.org \
    --cc=rodrigo.gobbi.7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox